[GitHub] nifi pull request #2942: NIFI-5500

[wietze <gi...@git.apache.org>]

GitHub user wietze opened a pull request:

    https://github.com/apache/nifi/pull/2942

    NIFI-5500

    Thank you for submitting a contribution to Apache NiFi.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [x] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message?
    
    - [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    - [x] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
    - [x] Have you written or updated unit tests to verify your changes?
    - [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? 
    - [x] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
    - [x] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
    - [x] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
    
    ### For documentation related changes:
    - [x] Have you ensured that format looks appropriate for the output in which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/wietze/nifi NIFI-5500

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/2942.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2942
    
----
commit 25e2ee280e0b856b73de8cd0c8f039521a883f32
Author: Wietze <wi...@...>
Date:   2018-08-08T16:17:47Z

    Adding support for array fields when outputting to attributes when using QueryElasticsearchHttp

----


---

[GitHub] nifi pull request #2942: NIFI-5500: Array support in QueryElasticseachHttp

[jzonthemtn <gi...@git.apache.org>]

Github user jzonthemtn commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/2942#discussion_r210897472
  
    --- Diff: nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch/QueryElasticsearchHttp.java ---
    @@ -432,7 +432,17 @@ private int getPage(final Response getResponse, final URL url, final ProcessCont
                         Map<String, String> attributes = new HashMap<>();
                         for(Iterator<Entry<String, JsonNode>> it = source.fields(); it.hasNext(); ) {
                             Entry<String, JsonNode> entry = it.next();
    -                        attributes.put(ATTRIBUTE_PREFIX + entry.getKey(), entry.getValue().asText());
    +                        String text_value = "";
    +                        String separator = "";
    --- End diff --
    
    I think it might be better if the value of `separator` didn't change. What do you think about adding each item's text to an array and then doing something like a `StringUtils.join()` on it?


---

[GitHub] nifi issue #2942: NIFI-5500: Array support in QueryElasticseachHttp

[wietze <gi...@git.apache.org>]

Github user wietze commented on the issue:

    https://github.com/apache/nifi/pull/2942
  
    @jzonthemtn Fixed/optimised this in bc3712d  


---