[GitHub] [spark] srowen commented on a diff in pull request #37058: [SPARK-39661][SQL] Avoid creating unnecessary SLF4J Logger

[GitBox <gi...@apache.org>]

srowen commented on code in PR #37058:
URL: https://github.com/apache/spark/pull/37058#discussion_r915037435


##########
common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/BlockStoreClient.java:
##########
@@ -42,7 +42,7 @@
  * or external service.
  */
 public abstract class BlockStoreClient implements Closeable {
-  protected final Logger logger = LoggerFactory.getLogger(this.getClass());
+  protected static final Logger logger = LoggerFactory.getLogger(BlockStoreClient.class);

Review Comment:
   Yeah go ahead and make it LOGGER and let's try tests one more time. I'm sure it's not related so would probably merge anyway.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org