[GitHub] [dubbo-go] zouyx commented on a change in pull request #1479: Nacos client enhance

[GitBox <gi...@apache.org>]

zouyx commented on a change in pull request #1479:
URL: https://github.com/apache/dubbo-go/pull/1479#discussion_r713793321



##########
File path: common/url.go
##########
@@ -847,3 +848,12 @@ func SetCompareURLEqualFunc(f CompareURLEqualFunc) {
 func GetCompareURLEqualFunc() CompareURLEqualFunc {
 	return compareURLEqualFunc
 }
+
+//GetParamDuration get duration if param is invalid or missing will return 3s
+func (c *URL) GetParamDuration(s string, d string) time.Duration {
+

Review comment:
       delete blank line

##########
File path: registry/nacos/registry_test.go
##########
@@ -37,6 +37,7 @@ import (
 )
 
 func TestNacosRegistry_Register(t *testing.T) {
+	//t.Skip()

Review comment:
       delete this code?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org