[jira] [Issue Comment Edited] (CASSANDRA-2576) Rewrite into new file post streaming

["Stu Hood (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CASSANDRA-2576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13043107#comment-13043107 ] 

Stu Hood edited comment on CASSANDRA-2576 at 6/2/11 10:28 PM:
--------------------------------------------------------------

bq. Looks good, but why are we not adding row sizes and column counts to the estimated histograms for CommutativeRowIndexer#doIndexing ?
That should happen inside the SSTableWriter as things are being appended.

Thanks! I'll clean this up for commit as soon as 2468 goes in.

      was (Author: stuhood):
    bq. Looks good, but why are we not adding row sizes and column counts to the estimated histograms for CommutativeRowIndexer#doIndexing ?
That should happen inside the SSTableWriter as things are being appended.

Thanks!
  
> Rewrite into new file post streaming
> ------------------------------------
>
>                 Key: CASSANDRA-2576
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-2576
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Stu Hood
>            Assignee: Stu Hood
>             Fix For: 1.0
>
>         Attachments: 0001-CASSANDRA-2576-Don-t-depend-on-a-byte-for-byte-match-f.txt, 0002-CASSANDRA-2576-Rebuild-into-a-new-file-to-minimize-mag.txt
>
>
> Commutative/counter column families use a separate path to rebuild sstables post streaming, and that path currently rewrites the data within the streamed file. While this is great for space efficiency, it means a duplicated code path for writing sstables, which makes it more difficult to make changes like #674.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira