You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/08/28 22:00:14 UTC
[GitHub] [spark] msamirkhan opened a new pull request #29573: [SPARK-32731] Add tests for arrays/maps of nested structs to ReadSchemaSuite to test structs reuse
msamirkhan opened a new pull request #29573:
URL: https://github.com/apache/spark/pull/29573
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
-->
### What changes were proposed in this pull request?
Splitting tests originally posted in [PR|https://github.com/apache/spark/pull/29352] for SPARK-32531.
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
The added tests cover cases for maps and arrays of nested structs for different file formats. Eg, https://github.com/apache/spark/pull/29353 and https://github.com/apache/spark/pull/29354 add object reuse when reading ORC and Avro files. However, for dynamic data structures like arrays and maps, we do not know just by looking at the schema what the size of the data structure will be so it has to be allocated when reading the data points. The added tests provide coverage so that objects are not accidentally reused when encountering maps and arrays.
AFAIK this is not covered by existing tests.
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
No
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
build/sbt "sql/test:testOnly **ReadSchemaSuite"
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29573: [SPARK-32731][SQL][TEST] Add tests for arrays/maps of nested structs to ReadSchemaSuite to test structs reuse
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29573:
URL: https://github.com/apache/spark/pull/29573#issuecomment-683604362
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/128062/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29573: [SPARK-32731][SQL][TEST] Add tests for arrays/maps of nested structs to ReadSchemaSuite to test structs reuse
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29573:
URL: https://github.com/apache/spark/pull/29573#issuecomment-735664312
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29573: [SPARK-32731][SQL][TEST] Add tests for arrays/maps of nested structs to ReadSchemaSuite to test structs reuse
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29573:
URL: https://github.com/apache/spark/pull/29573#issuecomment-683508597
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29573: [SPARK-32731][SQL][TEST] Add tests for arrays/maps of nested structs to ReadSchemaSuite to test structs reuse
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29573:
URL: https://github.com/apache/spark/pull/29573#issuecomment-735603977
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29573: [SPARK-32731] Add tests for arrays/maps of nested structs to ReadSchemaSuite to test structs reuse
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29573:
URL: https://github.com/apache/spark/pull/29573#issuecomment-683165095
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29573: [SPARK-32731][SQL][TEST] Add tests for arrays/maps of nested structs to ReadSchemaSuite to test structs reuse
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29573:
URL: https://github.com/apache/spark/pull/29573#issuecomment-683604350
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29573: [SPARK-32731][SQL][TEST] Add tests for arrays/maps of nested structs to ReadSchemaSuite to test structs reuse
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29573:
URL: https://github.com/apache/spark/pull/29573#issuecomment-735612452
**[Test build #131968 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131968/testReport)** for PR 29573 at commit [`6035934`](https://github.com/apache/spark/commit/6035934e1b557dbd4d4d3facfbd5dfe826db0da1).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29573: [SPARK-32731][SQL][TEST] Add tests for arrays/maps of nested structs to ReadSchemaSuite to test structs reuse
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29573:
URL: https://github.com/apache/spark/pull/29573#issuecomment-683508376
**[Test build #128062 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128062/testReport)** for PR 29573 at commit [`6035934`](https://github.com/apache/spark/commit/6035934e1b557dbd4d4d3facfbd5dfe826db0da1).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29573: [SPARK-32731][SQL][TEST] Add tests for arrays/maps of nested structs to ReadSchemaSuite to test structs reuse
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29573:
URL: https://github.com/apache/spark/pull/29573#issuecomment-683508597
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29573: [SPARK-32731][SQL][TEST] Add tests for arrays/maps of nested structs to ReadSchemaSuite to test structs reuse
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29573:
URL: https://github.com/apache/spark/pull/29573#issuecomment-735755483
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #29573: [SPARK-32731][SQL][TEST] Add tests for arrays/maps of nested structs to ReadSchemaSuite to test structs reuse
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #29573:
URL: https://github.com/apache/spark/pull/29573#discussion_r592099376
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/ReadSchemaTest.scala
##########
@@ -72,6 +72,58 @@ trait ReadSchemaTest extends QueryTest with SharedSparkSession {
val options: Map[String, String] = Map.empty[String, String]
}
+trait ArrayWithNestedStructTest extends ReadSchemaTest {
Review comment:
The goal of `ReadSchemaTest` is the following (https://github.com/apache/spark/pull/29573/files#diff-ff46c4f16bf7cb1f09e74b70b0ba3bc6be62203824a2fe16c4c473e34fd18d7fR24).
```
Read schema suites have the following hierarchy and aims to guarantee users a backward-compatible read-schema change coverage
```
To simply put, it was about a kind of acceptable schema evolution. However, the new test suites `ArrayWithNestedStructTest` and `MapWithNestedStructTest` seems to have no schema evolution.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #29573: [SPARK-32731][SQL][TEST] Add tests for arrays/maps of nested structs to ReadSchemaSuite to test structs reuse
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #29573:
URL: https://github.com/apache/spark/pull/29573#issuecomment-735611286
ok to test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29573: [SPARK-32731][SQL][TEST] Add tests for arrays/maps of nested structs to ReadSchemaSuite to test structs reuse
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29573:
URL: https://github.com/apache/spark/pull/29573#issuecomment-735739055
**[Test build #131968 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131968/testReport)** for PR 29573 at commit [`6035934`](https://github.com/apache/spark/commit/6035934e1b557dbd4d4d3facfbd5dfe826db0da1).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* `trait ArrayWithNestedStructTest extends ReadSchemaTest `
* `trait MapWithNestedStructTest extends ReadSchemaTest `
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29573: [SPARK-32731][SQL][TEST] Add tests for arrays/maps of nested structs to ReadSchemaSuite to test structs reuse
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29573:
URL: https://github.com/apache/spark/pull/29573#issuecomment-735612452
**[Test build #131968 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131968/testReport)** for PR 29573 at commit [`6035934`](https://github.com/apache/spark/commit/6035934e1b557dbd4d4d3facfbd5dfe826db0da1).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29573: [SPARK-32731] Add tests for arrays/maps of nested structs to ReadSchemaSuite to test structs reuse
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29573:
URL: https://github.com/apache/spark/pull/29573#issuecomment-683166967
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29573: [SPARK-32731][SQL][TEST] Add tests for arrays/maps of nested structs to ReadSchemaSuite to test structs reuse
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29573:
URL: https://github.com/apache/spark/pull/29573#issuecomment-735603977
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun edited a comment on pull request #29573: [SPARK-32731][SQL][TEST] Add tests for arrays/maps of nested structs to ReadSchemaSuite to test structs reuse
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun edited a comment on pull request #29573:
URL: https://github.com/apache/spark/pull/29573#issuecomment-683548910
Thank you for pinging me, @HyukjinKwon .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29573: [SPARK-32731][SQL][TEST] Add tests for arrays/maps of nested structs to ReadSchemaSuite to test structs reuse
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29573:
URL: https://github.com/apache/spark/pull/29573#issuecomment-683166967
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #29573: [SPARK-32731][SQL][TEST] Add tests for arrays/maps of nested structs to ReadSchemaSuite to test structs reuse
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #29573:
URL: https://github.com/apache/spark/pull/29573#issuecomment-683507230
ok to test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #29573: [SPARK-32731][SQL][TEST] Add tests for arrays/maps of nested structs to ReadSchemaSuite to test structs reuse
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #29573:
URL: https://github.com/apache/spark/pull/29573#issuecomment-796494720
Oops. I missed this. Sorry, @msamirkhan and @HyukjinKwon .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29573: [SPARK-32731][SQL][TEST] Add tests for arrays/maps of nested structs to ReadSchemaSuite to test structs reuse
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29573:
URL: https://github.com/apache/spark/pull/29573#issuecomment-735560305
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29573: [SPARK-32731][SQL][TEST] Add tests for arrays/maps of nested structs to ReadSchemaSuite to test structs reuse
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29573:
URL: https://github.com/apache/spark/pull/29573#issuecomment-735755483
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29573: [SPARK-32731][SQL][TEST] Add tests for arrays/maps of nested structs to ReadSchemaSuite to test structs reuse
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29573:
URL: https://github.com/apache/spark/pull/29573#issuecomment-735560305
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #29573: [SPARK-32731][SQL][TEST] Add tests for arrays/maps of nested structs to ReadSchemaSuite to test structs reuse
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #29573:
URL: https://github.com/apache/spark/pull/29573#issuecomment-683548910
Thank you for ping me, @HyukjinKwon .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29573: [SPARK-32731][SQL][TEST] Add tests for arrays/maps of nested structs to ReadSchemaSuite to test structs reuse
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29573:
URL: https://github.com/apache/spark/pull/29573#issuecomment-735664332
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29573: [SPARK-32731] Add tests for arrays/maps of nested structs to ReadSchemaSuite to test structs reuse
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29573:
URL: https://github.com/apache/spark/pull/29573#issuecomment-683165095
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29573: [SPARK-32731][SQL][TEST] Add tests for arrays/maps of nested structs to ReadSchemaSuite to test structs reuse
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29573:
URL: https://github.com/apache/spark/pull/29573#issuecomment-683508376
**[Test build #128062 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128062/testReport)** for PR 29573 at commit [`6035934`](https://github.com/apache/spark/commit/6035934e1b557dbd4d4d3facfbd5dfe826db0da1).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29573: [SPARK-32731][SQL][TEST] Add tests for arrays/maps of nested structs to ReadSchemaSuite to test structs reuse
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29573:
URL: https://github.com/apache/spark/pull/29573#issuecomment-683604350
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] github-actions[bot] commented on pull request #29573: [SPARK-32731][SQL][TEST] Add tests for arrays/maps of nested structs to ReadSchemaSuite to test structs reuse
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #29573:
URL: https://github.com/apache/spark/pull/29573#issuecomment-796331286
We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
If you'd like to revive this PR, please reopen it and ask a committer to remove the Stale tag!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #29573: [SPARK-32731][SQL][TEST] Add tests for arrays/maps of nested structs to ReadSchemaSuite to test structs reuse
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #29573:
URL: https://github.com/apache/spark/pull/29573#issuecomment-683506810
cc @dongjoon-hyun
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29573: [SPARK-32731][SQL][TEST] Add tests for arrays/maps of nested structs to ReadSchemaSuite to test structs reuse
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29573:
URL: https://github.com/apache/spark/pull/29573#issuecomment-683603225
**[Test build #128062 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128062/testReport)** for PR 29573 at commit [`6035934`](https://github.com/apache/spark/commit/6035934e1b557dbd4d4d3facfbd5dfe826db0da1).
* This patch **fails due to an unknown error code, -9**.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* `trait ArrayWithNestedStructTest extends ReadSchemaTest `
* `trait MapWithNestedStructTest extends ReadSchemaTest `
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] github-actions[bot] closed pull request #29573: [SPARK-32731][SQL][TEST] Add tests for arrays/maps of nested structs to ReadSchemaSuite to test structs reuse
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #29573:
URL: https://github.com/apache/spark/pull/29573
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] github-actions[bot] commented on pull request #29573: [SPARK-32731][SQL][TEST] Add tests for arrays/maps of nested structs to ReadSchemaSuite to test structs reuse
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #29573:
URL: https://github.com/apache/spark/pull/29573#issuecomment-864478916
We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
If you'd like to revive this PR, please reopen it and ask a committer to remove the Stale tag!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org