You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2019/11/12 16:43:00 UTC

[jira] [Commented] (SOLR-13870) eliminate getNextAvailablePort() dependency in SolrJmxReporterTest

    [ https://issues.apache.org/jira/browse/SOLR-13870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16972606#comment-16972606 ] 

ASF subversion and git services commented on SOLR-13870:
--------------------------------------------------------

Commit 367fe2f341cca18fb3d22e203b8cd8a91dd36948 in lucene-solr's branch refs/heads/master from Chris M. Hostetter
[ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=367fe2f ]

SOLR-13870: SolrJmxReporterTest no longer depends on (buggy) getNextAvailablePort()


> eliminate getNextAvailablePort() dependency in SolrJmxReporterTest
> ------------------------------------------------------------------
>
>                 Key: SOLR-13870
>                 URL: https://issues.apache.org/jira/browse/SOLR-13870
>             Project: Solr
>          Issue Type: Sub-task
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: Chris M. Hostetter
>            Assignee: Chris M. Hostetter
>            Priority: Major
>         Attachments: SOLR-13870.patch
>
>
> {{SolrJmxReporterTest}} is currently the only solr test using (the problematic) {{SolrTestCaseJ4.getNextAvailablePort}} helper method in order to assign a RMI port for running a JMX server.
> This test doesn't actually care that it's using RMI for JMX, it only cares that:
> # an MBeanServer is initialized that it can query
> # that MBeanServer can be specified in the plugin configuration for the {{SolrJmxReporter}}
> We should cleanup the test initialization so that it no longer depends on RMI via the {{serviceUrl}} plugin configuration option, and instead just use the {{agentId}} to specify an MBeanServer bootstrapped by the test.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org