You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@aries.apache.org by "David Jencks (Created) (JIRA)" <ji...@apache.org> on 2012/01/27 00:39:40 UTC
[jira] [Created] (ARIES-817) Upgrade to asm 4 for java 7 support
Upgrade to asm 4 for java 7 support
-----------------------------------
Key: ARIES-817
URL: https://issues.apache.org/jira/browse/ARIES-817
Project: Aries
Issue Type: Improvement
Components: Application, Blueprint, Proxy
Reporter: David Jencks
Assignee: David Jencks
asm 3 generates java 7 incompatible classes. We need to upgrade to asm 4 to be able to support running on java 7. There are a few simple code changes needed in the proxy module, and a couple nasty workarounds for newly final methods and private fields. There is also a lot of work in integration tests and pom versions to make everything else work.
I plan to add patches here as I proceed and when everything works I'll think about committing.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: [jira] [Updated] (ARIES-817) Upgrade to asm 4 for java 7 support
Posted by Holly Cummins <ho...@googlemail.com>.
David B. wrote:
> Of course - there should be a rule that only 1 David is allowed per
> project ;)
+1
:)
[snip]
>>
>>>
>>>
>>>
>>>
>>>>
>>>>
>>>>
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>
>>>>
>>>>
>>
>>
>>
Holly
Re: [jira] [Updated] (ARIES-817) Upgrade to asm 4 for java 7 support
Posted by David Bosschaert <da...@gmail.com>.
Of course - there should be a rule that only 1 David is allowed per project ;)
Cheers,
David
On 27 January 2012 11:40, Emily Jiang <em...@googlemail.com> wrote:
> haha. I meant to talk to David Jencks:). Sure. np with spi-fly.
>
> On Fri, Jan 27, 2012 at 10:37 AM, David Bosschaert <
> david.bosschaert@gmail.com> wrote:
>
>> Hi Emily,
>>
>> Why don't you simply go ahead with your changes. spi-fly isn't part of
>> the main build yet so I should be able to work on that separately,
>> simply by looking at your changes...
>>
>> Cheers,
>>
>> David
>>
>> On 27 January 2012 10:16, Emily Jiang <em...@googlemail.com> wrote:
>> > Hi David,
>> >
>> > Looks like we need a bit more coordination:). I got proxy-impl (worked
>> > around the issue of overriding final methods) and web unit test working
>> > with asm4. At the moment, just trying to get its itest working. When you
>> > see this, can you contact me so that we can put the fixes together?
>> >
>> > Regards,
>> > Emily
>> >
>> > On Fri, Jan 27, 2012 at 9:20 AM, David Jencks (Updated) (JIRA) <
>> > jira@apache.org> wrote:
>> >
>> >>
>> >> [
>> >>
>> https://issues.apache.org/jira/browse/ARIES-817?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
>> ]
>> >>
>> >> David Jencks updated ARIES-817:
>> >> -------------------------------
>> >>
>> >> Attachment: ARIES-817-spi-fly.diff
>> >>
>> >> Most of spi-fly is easy to fix... would it be possible to pull in the
>> >> proxy modules' osgi friendly class writer rather than copying the code?
>> >>
>> >> I'd suggest waiting to commit this until I'm more sure the new code
>> works
>> >> with the rest of aries, but I could commit it now if you'd like.
>> >>
>> >> > Upgrade to asm 4 for java 7 support
>> >> > -----------------------------------
>> >> >
>> >> > Key: ARIES-817
>> >> > URL: https://issues.apache.org/jira/browse/ARIES-817
>> >> > Project: Aries
>> >> > Issue Type: Improvement
>> >> > Components: Application, Blueprint, Proxy
>> >> > Reporter: David Jencks
>> >> > Assignee: David Jencks
>> >> > Attachments: ARIES-817-spi-fly.diff
>> >> >
>> >> >
>> >> > asm 3 generates java 7 incompatible classes. We need to upgrade to
>> asm
>> >> 4 to be able to support running on java 7. There are a few simple code
>> >> changes needed in the proxy module, and a couple nasty workarounds for
>> >> newly final methods and private fields. There is also a lot of work in
>> >> integration tests and pom versions to make everything else work.
>> >> > I plan to add patches here as I proceed and when everything works I'll
>> >> think about committing.
>> >>
>> >> --
>> >> This message is automatically generated by JIRA.
>> >> If you think it was sent incorrectly, please contact your JIRA
>> >> administrators:
>> >>
>> https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
>> >> For more information on JIRA, see:
>> http://www.atlassian.com/software/jira
>> >>
>> >>
>> >>
>> >
>> >
>> > --
>> > Thanks
>> > Emily
>> > =================
>> > Emily Jiang
>> > ejiang@apache.org
>>
>
>
>
> --
> Thanks
> Emily
> =================
> Emily Jiang
> ejiang@apache.org
Re: [jira] [Updated] (ARIES-817) Upgrade to asm 4 for java 7 support
Posted by Emily Jiang <em...@googlemail.com>.
haha. I meant to talk to David Jencks:). Sure. np with spi-fly.
On Fri, Jan 27, 2012 at 10:37 AM, David Bosschaert <
david.bosschaert@gmail.com> wrote:
> Hi Emily,
>
> Why don't you simply go ahead with your changes. spi-fly isn't part of
> the main build yet so I should be able to work on that separately,
> simply by looking at your changes...
>
> Cheers,
>
> David
>
> On 27 January 2012 10:16, Emily Jiang <em...@googlemail.com> wrote:
> > Hi David,
> >
> > Looks like we need a bit more coordination:). I got proxy-impl (worked
> > around the issue of overriding final methods) and web unit test working
> > with asm4. At the moment, just trying to get its itest working. When you
> > see this, can you contact me so that we can put the fixes together?
> >
> > Regards,
> > Emily
> >
> > On Fri, Jan 27, 2012 at 9:20 AM, David Jencks (Updated) (JIRA) <
> > jira@apache.org> wrote:
> >
> >>
> >> [
> >>
> https://issues.apache.org/jira/browse/ARIES-817?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
> ]
> >>
> >> David Jencks updated ARIES-817:
> >> -------------------------------
> >>
> >> Attachment: ARIES-817-spi-fly.diff
> >>
> >> Most of spi-fly is easy to fix... would it be possible to pull in the
> >> proxy modules' osgi friendly class writer rather than copying the code?
> >>
> >> I'd suggest waiting to commit this until I'm more sure the new code
> works
> >> with the rest of aries, but I could commit it now if you'd like.
> >>
> >> > Upgrade to asm 4 for java 7 support
> >> > -----------------------------------
> >> >
> >> > Key: ARIES-817
> >> > URL: https://issues.apache.org/jira/browse/ARIES-817
> >> > Project: Aries
> >> > Issue Type: Improvement
> >> > Components: Application, Blueprint, Proxy
> >> > Reporter: David Jencks
> >> > Assignee: David Jencks
> >> > Attachments: ARIES-817-spi-fly.diff
> >> >
> >> >
> >> > asm 3 generates java 7 incompatible classes. We need to upgrade to
> asm
> >> 4 to be able to support running on java 7. There are a few simple code
> >> changes needed in the proxy module, and a couple nasty workarounds for
> >> newly final methods and private fields. There is also a lot of work in
> >> integration tests and pom versions to make everything else work.
> >> > I plan to add patches here as I proceed and when everything works I'll
> >> think about committing.
> >>
> >> --
> >> This message is automatically generated by JIRA.
> >> If you think it was sent incorrectly, please contact your JIRA
> >> administrators:
> >>
> https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
> >> For more information on JIRA, see:
> http://www.atlassian.com/software/jira
> >>
> >>
> >>
> >
> >
> > --
> > Thanks
> > Emily
> > =================
> > Emily Jiang
> > ejiang@apache.org
>
--
Thanks
Emily
=================
Emily Jiang
ejiang@apache.org
Re: [jira] [Updated] (ARIES-817) Upgrade to asm 4 for java 7 support
Posted by David Bosschaert <da...@gmail.com>.
Hi Emily,
Why don't you simply go ahead with your changes. spi-fly isn't part of
the main build yet so I should be able to work on that separately,
simply by looking at your changes...
Cheers,
David
On 27 January 2012 10:16, Emily Jiang <em...@googlemail.com> wrote:
> Hi David,
>
> Looks like we need a bit more coordination:). I got proxy-impl (worked
> around the issue of overriding final methods) and web unit test working
> with asm4. At the moment, just trying to get its itest working. When you
> see this, can you contact me so that we can put the fixes together?
>
> Regards,
> Emily
>
> On Fri, Jan 27, 2012 at 9:20 AM, David Jencks (Updated) (JIRA) <
> jira@apache.org> wrote:
>
>>
>> [
>> https://issues.apache.org/jira/browse/ARIES-817?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel]
>>
>> David Jencks updated ARIES-817:
>> -------------------------------
>>
>> Attachment: ARIES-817-spi-fly.diff
>>
>> Most of spi-fly is easy to fix... would it be possible to pull in the
>> proxy modules' osgi friendly class writer rather than copying the code?
>>
>> I'd suggest waiting to commit this until I'm more sure the new code works
>> with the rest of aries, but I could commit it now if you'd like.
>>
>> > Upgrade to asm 4 for java 7 support
>> > -----------------------------------
>> >
>> > Key: ARIES-817
>> > URL: https://issues.apache.org/jira/browse/ARIES-817
>> > Project: Aries
>> > Issue Type: Improvement
>> > Components: Application, Blueprint, Proxy
>> > Reporter: David Jencks
>> > Assignee: David Jencks
>> > Attachments: ARIES-817-spi-fly.diff
>> >
>> >
>> > asm 3 generates java 7 incompatible classes. We need to upgrade to asm
>> 4 to be able to support running on java 7. There are a few simple code
>> changes needed in the proxy module, and a couple nasty workarounds for
>> newly final methods and private fields. There is also a lot of work in
>> integration tests and pom versions to make everything else work.
>> > I plan to add patches here as I proceed and when everything works I'll
>> think about committing.
>>
>> --
>> This message is automatically generated by JIRA.
>> If you think it was sent incorrectly, please contact your JIRA
>> administrators:
>> https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
>> For more information on JIRA, see: http://www.atlassian.com/software/jira
>>
>>
>>
>
>
> --
> Thanks
> Emily
> =================
> Emily Jiang
> ejiang@apache.org
Re: [jira] [Updated] (ARIES-817) Upgrade to asm 4 for java 7 support
Posted by Emily Jiang <em...@googlemail.com>.
Hi David,
Looks like we need a bit more coordination:). I got proxy-impl (worked
around the issue of overriding final methods) and web unit test working
with asm4. At the moment, just trying to get its itest working. When you
see this, can you contact me so that we can put the fixes together?
Regards,
Emily
On Fri, Jan 27, 2012 at 9:20 AM, David Jencks (Updated) (JIRA) <
jira@apache.org> wrote:
>
> [
> https://issues.apache.org/jira/browse/ARIES-817?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel]
>
> David Jencks updated ARIES-817:
> -------------------------------
>
> Attachment: ARIES-817-spi-fly.diff
>
> Most of spi-fly is easy to fix... would it be possible to pull in the
> proxy modules' osgi friendly class writer rather than copying the code?
>
> I'd suggest waiting to commit this until I'm more sure the new code works
> with the rest of aries, but I could commit it now if you'd like.
>
> > Upgrade to asm 4 for java 7 support
> > -----------------------------------
> >
> > Key: ARIES-817
> > URL: https://issues.apache.org/jira/browse/ARIES-817
> > Project: Aries
> > Issue Type: Improvement
> > Components: Application, Blueprint, Proxy
> > Reporter: David Jencks
> > Assignee: David Jencks
> > Attachments: ARIES-817-spi-fly.diff
> >
> >
> > asm 3 generates java 7 incompatible classes. We need to upgrade to asm
> 4 to be able to support running on java 7. There are a few simple code
> changes needed in the proxy module, and a couple nasty workarounds for
> newly final methods and private fields. There is also a lot of work in
> integration tests and pom versions to make everything else work.
> > I plan to add patches here as I proceed and when everything works I'll
> think about committing.
>
> --
> This message is automatically generated by JIRA.
> If you think it was sent incorrectly, please contact your JIRA
> administrators:
> https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
> For more information on JIRA, see: http://www.atlassian.com/software/jira
>
>
>
--
Thanks
Emily
=================
Emily Jiang
ejiang@apache.org
[jira] [Commented] (ARIES-817) Upgrade to asm 4 for java 7 support
Posted by "David Jencks (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ARIES-817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13195366#comment-13195366 ]
David Jencks commented on ARIES-817:
------------------------------------
I opened an ASM issue to have asm support marking the SerialVersionUID field synthetic.
http://forge.ow2.org/tracker/index.php?func=detail&aid=316318&group_id=23&atid=350023
> Upgrade to asm 4 for java 7 support
> -----------------------------------
>
> Key: ARIES-817
> URL: https://issues.apache.org/jira/browse/ARIES-817
> Project: Aries
> Issue Type: Improvement
> Components: Application, Blueprint, Proxy
> Reporter: David Jencks
> Assignee: David Jencks
> Attachments: ARIES-817-proxy.diff, ARIES-817-spi-fly.diff
>
>
> asm 3 generates java 7 incompatible classes. We need to upgrade to asm 4 to be able to support running on java 7. There are a few simple code changes needed in the proxy module, and a couple nasty workarounds for newly final methods and private fields. There is also a lot of work in integration tests and pom versions to make everything else work.
> I plan to add patches here as I proceed and when everything works I'll think about committing.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ARIES-817) Upgrade to asm 4 for java 7 support
Posted by "Daniel Kulp (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ARIES-817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13194295#comment-13194295 ]
Daniel Kulp commented on ARIES-817:
-----------------------------------
David, do you know what issues it has with Java7? CXF uses ASM 3 and it seems to work fine on Java7 for the limited use cases that it hits. Just curious what we'd need to look out for.
> Upgrade to asm 4 for java 7 support
> -----------------------------------
>
> Key: ARIES-817
> URL: https://issues.apache.org/jira/browse/ARIES-817
> Project: Aries
> Issue Type: Improvement
> Components: Application, Blueprint, Proxy
> Reporter: David Jencks
> Assignee: David Jencks
>
> asm 3 generates java 7 incompatible classes. We need to upgrade to asm 4 to be able to support running on java 7. There are a few simple code changes needed in the proxy module, and a couple nasty workarounds for newly final methods and private fields. There is also a lot of work in integration tests and pom versions to make everything else work.
> I plan to add patches here as I proceed and when everything works I'll think about committing.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ARIES-817) Upgrade to asm 4 for java 7 support
Posted by "David Jencks (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ARIES-817?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Jencks updated ARIES-817:
-------------------------------
Attachment: ARIES-817-spi-fly.diff
Most of spi-fly is easy to fix... would it be possible to pull in the proxy modules' osgi friendly class writer rather than copying the code?
I'd suggest waiting to commit this until I'm more sure the new code works with the rest of aries, but I could commit it now if you'd like.
> Upgrade to asm 4 for java 7 support
> -----------------------------------
>
> Key: ARIES-817
> URL: https://issues.apache.org/jira/browse/ARIES-817
> Project: Aries
> Issue Type: Improvement
> Components: Application, Blueprint, Proxy
> Reporter: David Jencks
> Assignee: David Jencks
> Attachments: ARIES-817-spi-fly.diff
>
>
> asm 3 generates java 7 incompatible classes. We need to upgrade to asm 4 to be able to support running on java 7. There are a few simple code changes needed in the proxy module, and a couple nasty workarounds for newly final methods and private fields. There is also a lot of work in integration tests and pom versions to make everything else work.
> I plan to add patches here as I proceed and when everything works I'll think about committing.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ARIES-817) Upgrade to asm 4 for java 7 support
Posted by "David Bosschaert (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ARIES-817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13194528#comment-13194528 ]
David Bosschaert commented on ARIES-817:
----------------------------------------
The spi-fly component (OSGi RFC 167 implementation) also needs to get this done so I'll be following closely what changes you are making for this...
> Upgrade to asm 4 for java 7 support
> -----------------------------------
>
> Key: ARIES-817
> URL: https://issues.apache.org/jira/browse/ARIES-817
> Project: Aries
> Issue Type: Improvement
> Components: Application, Blueprint, Proxy
> Reporter: David Jencks
> Assignee: David Jencks
>
> asm 3 generates java 7 incompatible classes. We need to upgrade to asm 4 to be able to support running on java 7. There are a few simple code changes needed in the proxy module, and a couple nasty workarounds for newly final methods and private fields. There is also a lot of work in integration tests and pom versions to make everything else work.
> I plan to add patches here as I proceed and when everything works I'll think about committing.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ARIES-817) Upgrade to asm 4 for java 7 support
Posted by "David Jencks (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ARIES-817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13194369#comment-13194369 ]
David Jencks commented on ARIES-817:
------------------------------------
I don't know much, however I believe many generated classes fail java 7 class verification due to missing stack maps. Also apparently earlier asm's can't deal with java 7 class format.
> Upgrade to asm 4 for java 7 support
> -----------------------------------
>
> Key: ARIES-817
> URL: https://issues.apache.org/jira/browse/ARIES-817
> Project: Aries
> Issue Type: Improvement
> Components: Application, Blueprint, Proxy
> Reporter: David Jencks
> Assignee: David Jencks
>
> asm 3 generates java 7 incompatible classes. We need to upgrade to asm 4 to be able to support running on java 7. There are a few simple code changes needed in the proxy module, and a couple nasty workarounds for newly final methods and private fields. There is also a lot of work in integration tests and pom versions to make everything else work.
> I plan to add patches here as I proceed and when everything works I'll think about committing.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ARIES-817) Upgrade to asm 4 for java 7 support
Posted by "David Jencks (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ARIES-817?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Jencks updated ARIES-817:
-------------------------------
Attachment: ARIES-817-proxy.diff
One way to get asm4 into proxy.... I think Emily is also working on this.
> Upgrade to asm 4 for java 7 support
> -----------------------------------
>
> Key: ARIES-817
> URL: https://issues.apache.org/jira/browse/ARIES-817
> Project: Aries
> Issue Type: Improvement
> Components: Application, Blueprint, Proxy
> Reporter: David Jencks
> Assignee: David Jencks
> Attachments: ARIES-817-proxy.diff, ARIES-817-spi-fly.diff
>
>
> asm 3 generates java 7 incompatible classes. We need to upgrade to asm 4 to be able to support running on java 7. There are a few simple code changes needed in the proxy module, and a couple nasty workarounds for newly final methods and private fields. There is also a lot of work in integration tests and pom versions to make everything else work.
> I plan to add patches here as I proceed and when everything works I'll think about committing.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira