[GitHub] [hive] jcamachor commented on a change in pull request #848: HIVE-22486

[GitBox <gi...@apache.org>]

jcamachor commented on a change in pull request #848: HIVE-22486
URL: https://github.com/apache/hive/pull/848#discussion_r349354851
 
 

 ##########
 File path: ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveRelFieldTrimmer.java
 ##########
 @@ -674,10 +677,14 @@ public TrimResult trimFields(Project project, ImmutableBitSet fieldsUsed,
     // set columnAccessInfo for ViewColumnAuthorization
     for (Ord<RexNode> ord : Ord.zip(project.getProjects())) {
       if (fieldsUsed.get(ord.i)) {
-        if (this.columnAccessInfo != null && this.viewProjectToTableSchema != null
-            && this.viewProjectToTableSchema.containsKey(project)) {
+        if (this.viewProjectToTableSchema != null && this.viewProjectToTableSchema.containsKey(project)) {
           Table tab = this.viewProjectToTableSchema.get(project);
-          this.columnAccessInfo.add(tab.getCompleteName(), tab.getAllCols().get(ord.i).getName());
+          if (this.directColumnAccessInfo != null) {
+            this.directColumnAccessInfo.add(tab.getCompleteName(), tab.getAllCols().get(ord.i).getName());
+          }
+          if (this.allColumnAccessInfo != null) {
+            this.allColumnAccessInfo.add(tab.getCompleteName(), tab.getAllCols().get(ord.i).getName());
+          }
 
 Review comment:
   I have used a ColumnAccess internal object to represent this. Now it is cleaner because it uses a single ds. However, I kept the current APIs in ColumnAccessInfo so I do not have to make any changes all over for the time being. Can you take another look? Thanks

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org