You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by warneke <gi...@git.apache.org> on 2014/07/27 15:05:45 UTC
[GitHub] incubator-flink pull request: [FLINK-386] Duplicate dependencies i...
GitHub user warneke opened a pull request:
https://github.com/apache/incubator-flink/pull/80
[FLINK-386] Duplicate dependencies in lib folder
This set of changes cleans up/upgrades the dependencies of Flink and reduces the problem of duplicate libraries in the in lib folder as far as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/warneke/incubator-flink depcleanup
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-flink/pull/80.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #80
----
commit 28cc9cf744bac5f09a635a15bcce59579a561abe
Author: Daniel Warneke <wa...@apache.org>
Date: 2014-07-27T12:30:38Z
Upgraded to junit 4.11 and fixed code that used deprecated
commit 265177b14b09767af1968339723297965271aad0
Author: Daniel Warneke <wa...@apache.org>
Date: 2014-07-27T12:32:28Z
Changed scala dependency from 2.10.3 to 2.10.4 to avoid conflicts with scalatest dependency
commit 48488ef8bb88519596cb37706186feea0816d9fd
Author: Daniel Warneke <wa...@apache.org>
Date: 2014-07-27T12:33:39Z
Upgraded log4j and commons-logging dependency
commit e990f02e24ef43ecdf7f73630141036840dccdc6
Author: Daniel Warneke <wa...@apache.org>
Date: 2014-07-27T12:39:26Z
Removed superfluous dependency on commons-codec
commit e37275249e4cda1665a68f57a5a67678ff24d2b7
Author: Daniel Warneke <wa...@apache.org>
Date: 2014-07-27T12:40:47Z
Upgraded dependency versions in the base module
commit cacfc3f3fc49a765dca39f155abafa5608638a21
Author: Daniel Warneke <wa...@apache.org>
Date: 2014-07-27T12:43:53Z
Ensured consistency of avro versions across submodules
commit 45721ef8cf1c213a7dc8950cf8898dd0192dd77b
Author: Daniel Warneke <wa...@apache.org>
Date: 2014-07-27T12:44:53Z
Upgraded AWS dependency to version 1.8.1
commit 933b3c0f1267a29a4c033e574256665a053c5e16
Author: Daniel Warneke <wa...@apache.org>
Date: 2014-07-27T12:56:35Z
Unified configuration of jetty dependency
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-flink pull request: [FLINK-386] Duplicate dependencies i...
Posted by uce <gi...@git.apache.org>.
Github user uce commented on the pull request:
https://github.com/apache/incubator-flink/pull/80#issuecomment-50498033
I've tested this on a 25 node cluster and didn't run into any problems during compiliation or runtime.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-flink pull request: [FLINK-386] Duplicate dependencies i...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:
https://github.com/apache/incubator-flink/pull/80#issuecomment-50500024
Okay, then let us merge it into master. I think that afterwards, we can fork the 0.6 release branch to prepare the first release candidate.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-flink pull request: [FLINK-386] Duplicate dependencies i...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:
https://github.com/apache/incubator-flink/pull/80#issuecomment-50344798
An enhancement could be to exclude some of the hadoop dependencies for Hadoop 1. In Hadoop 1, there is no separation between core, mapred, hdfs, client, etc. So we have all the dependencies (JSP, jettison, jetty, hsqldb), which are most likely not needed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-flink pull request: [FLINK-386] Duplicate dependencies i...
Posted by warneke <gi...@git.apache.org>.
Github user warneke commented on the pull request:
https://github.com/apache/incubator-flink/pull/80#issuecomment-50389191
Yes, but do you really want to start to track down which dependency is used by which subsystem of Hadoop1? This is probably both cumbersome and error-prone.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-flink pull request: [FLINK-386] Duplicate dependencies i...
Posted by uce <gi...@git.apache.org>.
Github user uce commented on the pull request:
https://github.com/apache/incubator-flink/pull/80#issuecomment-50507788
OK, let me merge it in the next batch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-flink pull request: [FLINK-386] Duplicate dependencies i...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-flink/pull/80
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-flink pull request: [FLINK-386] Duplicate dependencies i...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:
https://github.com/apache/incubator-flink/pull/80#issuecomment-50344119
Nice one, looks very good to me.
I think we should make this part of the first release candidate.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---