[jira] [Created] (THRIFT-4103) make check fails in py.tornado intermittently on Travis CI

["James E. King, III (JIRA)" <ji...@apache.org>]

James E. King, III created THRIFT-4103:
------------------------------------------

             Summary: make check fails in py.tornado intermittently on Travis CI
                 Key: THRIFT-4103
                 URL: https://issues.apache.org/jira/browse/THRIFT-4103
             Project: Thrift
          Issue Type: Bug
          Components: Python - Library
    Affects Versions: 0.10.0
         Environment: Travis CI Build Job #8
            Reporter: James E. King, III
            Priority: Minor


In build job https://travis-ci.org/apache/thrift/jobs/204051491 there was a failure in py.twisted make check unrelated to the code that changed in node.js:

{noformat}
Making check in py.tornado
make[2]: Entering directory `/thrift/src/test/py.tornado'
../../compiler/cpp/thrift --gen py:tornado ../ThriftTest.thrift
[WARNING:/thrift/src/test/ThriftTest.thrift:45] No generator named 'noexist' could be found!
[WARNING:/thrift/src/test/ThriftTest.thrift:47] cpp generator does not accept 'noexist' as sub-namespace!
../../compiler/cpp/thrift --gen py:tornado ../SmallTest.thrift
[WARNING:/thrift/src/test/SmallTest.thrift:27] "senum" is deprecated and will be removed in a future compiler version.  This type should be replaced with "string".

[WARNING:/thrift/src/test/SmallTest.thrift:27] "senum" is deprecated and will be removed in a future compiler version.  This type should be replaced with "string".

./test_suite.py
..ERROR:thrift.TTornado:thrift exception in handle_stream
Traceback (most recent call last):
  File "/thrift/src/test/py.tornado/../../lib/py/build/lib.linux-x86_64-3.4/thrift/TTornado.py", line 183, in handle_stream
    yield self._processor.process(iprot, oprot)
  File "/usr/local/lib/python2.7/dist-packages/tornado/gen.py", line 1015, in run
    value = future.result()
  File "/usr/local/lib/python2.7/dist-packages/tornado/concurrent.py", line 237, in result
    raise_exc_info(self._exc_info)
  File "/usr/local/lib/python2.7/dist-packages/tornado/gen.py", line 285, in wrapper
    yielded = next(result)
  File "/thrift/src/test/py.tornado/gen-py.tornado/ThriftTest/ThriftTest.py", line 1410, in process_testException
    yield gen.maybe_future(self._handler.testException(args.arg))
  File "./test_suite.py", line 88, in testException
    raise ValueError("foo")
ValueError: foo
....F...
======================================================================
FAIL: test_oneway (__main__.ThriftTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/usr/local/lib/python2.7/dist-packages/tornado/testing.py", line 136, in __call__
    result = self.orig_method(*args, **kwargs)
  File "./test_suite.py", line 193, in test_oneway
    self.assertAlmostEqual(seconds, (end - start), places=3)
AssertionError: 0 != 0.0005118846893310547 within 3 places

----------------------------------------------------------------------
Ran 10 tests in 0.034s

FAILED (failures=1)
make[2]: *** [check] Error 1
make[2]: Leaving directory `/thrift/src/test/py.tornado'
make[1]: *** [check-recursive] Error 1
make[1]: Leaving directory `/thrift/src/test'
make: *** [check-recursive] Error 1
{noformat}

It looks like a test case is not accounting for floating precision properly.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)