You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by "LangInteger (via GitHub)" <gi...@apache.org> on 2023/04/27 12:24:00 UTC
[GitHub] [skywalking] LangInteger opened a new issue, #10740: [Bug] auto generated column alarm_record.alarm_message and events.message is too short
LangInteger opened a new issue, #10740:
URL: https://github.com/apache/skywalking/issues/10740
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no similar issues.
### Apache SkyWalking Component
OAP server (apache/skywalking)
### What happened
I have a look at the oap server log that we recently setup and I see some errors:
- tail -n 100 ./apache-skywalking-apm-bin/logs/skywalking-oap-server.log
### What you expected to happen
The alarm message and event should be stored correctly
### How to reproduce
- setup the brand new apache-skywalking-apm-9.4.0 server & ui
- setup agents on your services thus they can report data to oap server
- make your service name longer than 30 characters
- it's something like the picture
- make your API response time longer than 1s
- the automatically triggered `service_resp_time_percentile_rule` alarm by configuration in `apache-skywalking-apm-bin/config/alarm-settings.yml` will produce alarm messages and events that cannot be stored properly
### Anything else
The autoconfigured alarm message template is of good quality and the length is acceptable while it only leaves less than 30 characters long for the service name. I think it will be better if we can make the default value longer as I can see alarm_message.id and events.id are both of length 512 😄
I think the two table are defined in classes:
- org.apache.skywalking.oap.server.core.analysis.metrics.Event
- org.apache.skywalking.oap.server.core.alarm.AlarmRecord
Is the solution acceptable? Besides adding the length attribute to the `Column` annotation of the two fields, is there anything else needs to be done?
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #10740: [Bug] column alarm_record.alarm_message and events.message are too short
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on issue #10740:
URL: https://github.com/apache/skywalking/issues/10740#issuecomment-1525684810
You could try the dev version, if similar things happen, let's discuss more about that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng closed issue #10740: [Bug] column alarm_record.alarm_message and events.message are too short
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng closed issue #10740: [Bug] column alarm_record.alarm_message and events.message are too short
URL: https://github.com/apache/skywalking/issues/10740
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #10740: [Bug] column alarm_record.alarm_message and events.message are too short
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on issue #10740:
URL: https://github.com/apache/skywalking/issues/10740#issuecomment-1525631153
JDBC storage solution had been changed completely in 9.5.0.
What you report would happen but we wouldn't fix that as it is gone.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org