You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Trygve Laugstol (JIRA)" <ji...@codehaus.org> on 2008/02/15 16:59:30 UTC
[jira] Created: (MWAR-144) Custom filter list does not work
Custom filter list does not work
--------------------------------
Key: MWAR-144
URL: http://jira.codehaus.org/browse/MWAR-144
Project: Maven 2.x War Plugin
Issue Type: Bug
Affects Versions: 2.1-alpha-1
Reporter: Trygve Laugstol
When specifying filters on the plugin (not inside <project>) like this:
{code}
<configuration>
<resource>
<directory>polopoly-resources/config_ptest</directory>
<targetPath>WEB-INF/config</targetPath>
</resource>
<warName>ptest</warName>
<workDirectory>target/ptest-work</workDirectory>
<filters>
<filter>src/main/filters/filter.ptest.properties</filter>
</filters>
<webResources>
<resource>
<directory>src/main/resources</directory>
<targetPath>WEB-INF/classes</targetPath>
<filtering>true</filtering>
</resource>
</webResources>
{code}
the list of filters is ignored. If I move the <filters> list to inside the <project> they work as expected. The documentation explicitly say that this is possible under the section "Filtering webResources".
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MWAR-144) Custom filter list does not work
Posted by "Trygve Laugstol (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MWAR-144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_124148 ]
Trygve Laugstol commented on MWAR-144:
--------------------------------------
Verified, works like a charm!
> Custom filter list does not work
> --------------------------------
>
> Key: MWAR-144
> URL: http://jira.codehaus.org/browse/MWAR-144
> Project: Maven 2.x War Plugin
> Issue Type: Bug
> Affects Versions: 2.1-alpha-1
> Reporter: Trygve Laugstol
> Assignee: Olivier Lamy
> Fix For: 2.1-alpha-2
>
>
> When specifying filters on the plugin (not inside <project>) like this:
> {code}
> <configuration>
> <resource>
> <directory>polopoly-resources/config_ptest</directory>
> <targetPath>WEB-INF/config</targetPath>
> </resource>
> <warName>ptest</warName>
> <workDirectory>target/ptest-work</workDirectory>
> <filters>
> <filter>src/main/filters/filter.ptest.properties</filter>
> </filters>
> <webResources>
> <resource>
> <directory>src/main/resources</directory>
> <targetPath>WEB-INF/classes</targetPath>
> <filtering>true</filtering>
> </resource>
> </webResources>
> {code}
> the list of filters is ignored. If I move the <filters> list to inside the <project> they work as expected. The documentation explicitly say that this is possible under the section "Filtering webResources".
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (MWAR-144) Custom filter list does not work
Posted by "Olivier Lamy (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MWAR-144?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Olivier Lamy closed MWAR-144.
-----------------------------
Resolution: Fixed
fix in rev 628569.
> Custom filter list does not work
> --------------------------------
>
> Key: MWAR-144
> URL: http://jira.codehaus.org/browse/MWAR-144
> Project: Maven 2.x War Plugin
> Issue Type: Bug
> Affects Versions: 2.1-alpha-1
> Reporter: Trygve Laugstol
> Assignee: Olivier Lamy
> Fix For: 2.1-alpha-2
>
>
> When specifying filters on the plugin (not inside <project>) like this:
> {code}
> <configuration>
> <resource>
> <directory>polopoly-resources/config_ptest</directory>
> <targetPath>WEB-INF/config</targetPath>
> </resource>
> <warName>ptest</warName>
> <workDirectory>target/ptest-work</workDirectory>
> <filters>
> <filter>src/main/filters/filter.ptest.properties</filter>
> </filters>
> <webResources>
> <resource>
> <directory>src/main/resources</directory>
> <targetPath>WEB-INF/classes</targetPath>
> <filtering>true</filtering>
> </resource>
> </webResources>
> {code}
> the list of filters is ignored. If I move the <filters> list to inside the <project> they work as expected. The documentation explicitly say that this is possible under the section "Filtering webResources".
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MWAR-144) Custom filter list does not work
Posted by "Olivier Lamy (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MWAR-144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_123805 ]
Olivier Lamy commented on MWAR-144:
-----------------------------------
Did you try on last SNAPSHOT ?
Concerning plugin configuration :
{code:xml}
<filters>
<filter>src/main/filters/filter.ptest.properties</filter>
</filters>
{code}
I would prefer something like
{code:xml}
<filters>
<filter>${basedir}/src/main/filters/filter.ptest.properties</filter>
</filters>
{code}
> Custom filter list does not work
> --------------------------------
>
> Key: MWAR-144
> URL: http://jira.codehaus.org/browse/MWAR-144
> Project: Maven 2.x War Plugin
> Issue Type: Bug
> Affects Versions: 2.1-alpha-1
> Reporter: Trygve Laugstol
>
> When specifying filters on the plugin (not inside <project>) like this:
> {code}
> <configuration>
> <resource>
> <directory>polopoly-resources/config_ptest</directory>
> <targetPath>WEB-INF/config</targetPath>
> </resource>
> <warName>ptest</warName>
> <workDirectory>target/ptest-work</workDirectory>
> <filters>
> <filter>src/main/filters/filter.ptest.properties</filter>
> </filters>
> <webResources>
> <resource>
> <directory>src/main/resources</directory>
> <targetPath>WEB-INF/classes</targetPath>
> <filtering>true</filtering>
> </resource>
> </webResources>
> {code}
> the list of filters is ignored. If I move the <filters> list to inside the <project> they work as expected. The documentation explicitly say that this is possible under the section "Filtering webResources".
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MWAR-144) Custom filter list does not work
Posted by "Olivier Lamy (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MWAR-144?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Olivier Lamy updated MWAR-144:
------------------------------
Assignee: Olivier Lamy
Fix Version/s: 2.1-alpha-2
> Custom filter list does not work
> --------------------------------
>
> Key: MWAR-144
> URL: http://jira.codehaus.org/browse/MWAR-144
> Project: Maven 2.x War Plugin
> Issue Type: Bug
> Affects Versions: 2.1-alpha-1
> Reporter: Trygve Laugstol
> Assignee: Olivier Lamy
> Fix For: 2.1-alpha-2
>
>
> When specifying filters on the plugin (not inside <project>) like this:
> {code}
> <configuration>
> <resource>
> <directory>polopoly-resources/config_ptest</directory>
> <targetPath>WEB-INF/config</targetPath>
> </resource>
> <warName>ptest</warName>
> <workDirectory>target/ptest-work</workDirectory>
> <filters>
> <filter>src/main/filters/filter.ptest.properties</filter>
> </filters>
> <webResources>
> <resource>
> <directory>src/main/resources</directory>
> <targetPath>WEB-INF/classes</targetPath>
> <filtering>true</filtering>
> </resource>
> </webResources>
> {code}
> the list of filters is ignored. If I move the <filters> list to inside the <project> they work as expected. The documentation explicitly say that this is possible under the section "Filtering webResources".
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MWAR-144) Custom filter list does not work
Posted by "Trygve Laugstol (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MWAR-144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_124008 ]
Trygve Laugstol commented on MWAR-144:
--------------------------------------
No, I haven't. If the latest SNAPSHOT fixes is, consider this a documentation bug as it should be specified with a "since" description.
Also, if ${basedir} really is required (if it is a File[] array it isn't), that is also a bug. All file references are *always* relative to the project itself.
> Custom filter list does not work
> --------------------------------
>
> Key: MWAR-144
> URL: http://jira.codehaus.org/browse/MWAR-144
> Project: Maven 2.x War Plugin
> Issue Type: Bug
> Affects Versions: 2.1-alpha-1
> Reporter: Trygve Laugstol
> Assignee: Olivier Lamy
> Fix For: 2.1-alpha-2
>
>
> When specifying filters on the plugin (not inside <project>) like this:
> {code}
> <configuration>
> <resource>
> <directory>polopoly-resources/config_ptest</directory>
> <targetPath>WEB-INF/config</targetPath>
> </resource>
> <warName>ptest</warName>
> <workDirectory>target/ptest-work</workDirectory>
> <filters>
> <filter>src/main/filters/filter.ptest.properties</filter>
> </filters>
> <webResources>
> <resource>
> <directory>src/main/resources</directory>
> <targetPath>WEB-INF/classes</targetPath>
> <filtering>true</filtering>
> </resource>
> </webResources>
> {code}
> the list of filters is ignored. If I move the <filters> list to inside the <project> they work as expected. The documentation explicitly say that this is possible under the section "Filtering webResources".
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira