[GitHub] [cordova-android] raphinesse commented on a change in pull request #928: Update check_reqs.js - JDK 1.8 or greater

[GitBox <gi...@apache.org>]

raphinesse commented on a change in pull request #928:
URL: https://github.com/apache/cordova-android/pull/928#discussion_r441143116



##########
File path: bin/templates/cordova/lib/check_reqs.js
##########
@@ -393,11 +393,13 @@ module.exports.run = function () {
         console.log('ANDROID_SDK_ROOT=' + process.env['ANDROID_SDK_ROOT'] + ' (recommended setting)');
         console.log('ANDROID_HOME=' + process.env['ANDROID_HOME'] + ' (DEPRECATED)');
 
-        if (!String(values[0]).startsWith('1.8.')) {
+        if (values[0] === undefined) {

Review comment:
       Agreed, we should still throw an error for JDK < 8. We might be able to use semver. We already depend on it IIRC.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org