[GitHub] [netbeans] junichi11 commented on a diff in pull request #5695: PHP 8.1: Explicit octal integer literal notation #5026

["junichi11 (via GitHub)" <gi...@apache.org>]

junichi11 commented on code in PR #5695:
URL: https://github.com/apache/netbeans/pull/5695#discussion_r1145686415


##########
php/php.editor/tools/ASTPHP5Scanner.flex:
##########
@@ -943,6 +944,12 @@ NOWDOC_CHARS=({NEWLINE}*(([^a-zA-Z_\x7f-\xff\n\r][^\n\r]*)|({LABEL}[^a-zA-Z0-9_\
     pushState(ST_IN_SCRIPTING);
 }
 
+<ST_IN_SCRIPTING>{ONUM} {
+    // PHP 8.1: Explicit octal integer literal notation
+    // https://wiki.php.net/rfc/explicit_octal_notation
+    return createFullSymbol(ASTPHP5Symbols.T_LNUMBER);

Review Comment:
   It should not be correct. Actually, `T_LNUMBER` or `T_DNUMBER` is returned in PHP. (`ONUM` too) So need more checks. However, I don't think there are big effects on the existing features of NB currently.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists