You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by "EMsnap (via GitHub)" <gi...@apache.org> on 2023/03/08 08:32:50 UTC
[GitHub] [inlong] EMsnap opened a new pull request, #7552: [INLONG-7503][Sort] support multiple audit ids in source connectors
EMsnap opened a new pull request, #7552:
URL: https://github.com/apache/inlong/pull/7552
- Fixes #7503
### Motivation
support multiple audit ids in source connectors
We only support a constant audit id for source or sink in one group. However, one group can contain multiple streams which has multiple audit ids.
### Modifications
Support multiple audit id for pulsar source, and add option for audit ids for other source connectors
For connectors other than pulsar, we need extra test for adding audit ids.
### Verifying this change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] dockerzhang commented on a diff in pull request #7552: [INLONG-7503][Sort] Support multiple audit ids and introduce timestamp collector
Posted by "dockerzhang (via GitHub)" <gi...@apache.org>.
dockerzhang commented on code in PR #7552:
URL: https://github.com/apache/inlong/pull/7552#discussion_r1129231256
##########
inlong-sort/sort-connectors/base/src/main/java/org/apache/inlong/sort/base/Constants.java:
##########
@@ -149,6 +148,12 @@ public final class Constants {
.withDescription("Audit proxy host address for reporting audit metrics. \n"
+ "e.g. 127.0.0.1:10081,0.0.0.1:10081");
+ public static final ConfigOption<String> AUDIT_KEYS =
Review Comment:
How to use `AUDIT_KEYS`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] EMsnap merged pull request #7552: [INLONG-7503][Sort] Support multiple audit ids and introduce timestamp collector
Posted by "EMsnap (via GitHub)" <gi...@apache.org>.
EMsnap merged PR #7552:
URL: https://github.com/apache/inlong/pull/7552
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] healchow commented on a diff in pull request #7552: [INLONG-7503][Sort] support multiple audit ids in pulsar source connector and introduce timestamped collector
Posted by "healchow (via GitHub)" <gi...@apache.org>.
healchow commented on code in PR #7552:
URL: https://github.com/apache/inlong/pull/7552#discussion_r1129191212
##########
inlong-sort/sort-formats/format-base/src/main/java/org/apache/inlong/sort/formats/base/collectors/TimeStampedCollector.java:
##########
@@ -0,0 +1,30 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.inlong.sort.formats.base.collectors;
+
+import org.apache.flink.util.Collector;
+
+/**
+ * Collector that support timestamp collection.
+ * @param <T>
+ */
+public interface TimeStampedCollector<T> extends Collector<T> {
Review Comment:
`TimeStampedCollector` -> `TimestampCollector` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] EMsnap commented on a diff in pull request #7552: [INLONG-7503][Sort] Support multiple audit ids and introduce timestamp collector
Posted by "EMsnap (via GitHub)" <gi...@apache.org>.
EMsnap commented on code in PR #7552:
URL: https://github.com/apache/inlong/pull/7552#discussion_r1130303038
##########
inlong-sort/sort-connectors/base/src/main/java/org/apache/inlong/sort/base/Constants.java:
##########
@@ -149,6 +148,12 @@ public final class Constants {
.withDescription("Audit proxy host address for reporting audit metrics. \n"
+ "e.g. 127.0.0.1:10081,0.0.0.1:10081");
+ public static final ConfigOption<String> AUDIT_KEYS =
Review Comment:
It's a key from group props
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] healchow commented on a diff in pull request #7552: [INLONG-7503][Sort] support multiple audit ids in pulsar source connector and introduce timestamped collector
Posted by "healchow (via GitHub)" <gi...@apache.org>.
healchow commented on code in PR #7552:
URL: https://github.com/apache/inlong/pull/7552#discussion_r1129191212
##########
inlong-sort/sort-formats/format-base/src/main/java/org/apache/inlong/sort/formats/base/collectors/TimeStampedCollector.java:
##########
@@ -0,0 +1,30 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.inlong.sort.formats.base.collectors;
+
+import org.apache.flink.util.Collector;
+
+/**
+ * Collector that support timestamp collection.
+ * @param <T>
+ */
+public interface TimeStampedCollector<T> extends Collector<T> {
Review Comment:
`TimeStampedCollector` -> `TimestampedCollector` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org