You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "XComp (via GitHub)" <gi...@apache.org> on 2023/05/16 08:36:09 UTC

[GitHub] [flink] XComp opened a new pull request, #22591: [FLINK-31354][tests] Increased timeout for NettyClientServerSslTest to improve test stability

XComp opened a new pull request, #22591:
URL: https://github.com/apache/flink/pull/22591

   ## What is the purpose of the change
   
   We see the test occassionally fail due to slow CI machines (see further details in FLINK-31354). Increasing the timeouts should solve the issue.
   
   ## Brief change log
   
   * Increased the timeouts from 1s to 5s
   
   ## Verifying this change
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? not applicable


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [flink] XComp merged pull request #22591: [FLINK-31354][tests] Increased timeout for NettyClientServerSslTest to improve test stability

Posted by "XComp (via GitHub)" <gi...@apache.org>.
XComp merged PR #22591:
URL: https://github.com/apache/flink/pull/22591


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [flink] dmvk commented on pull request #22591: [FLINK-31354][tests] Increased timeout for NettyClientServerSslTest to improve test stability

Posted by "dmvk (via GitHub)" <gi...@apache.org>.
dmvk commented on PR #22591:
URL: https://github.com/apache/flink/pull/22591#issuecomment-1553052416

   > The test usually runs in milliseconds but occasionally runs into the 1000ms limit.
   
   Can we simply increase the timeouts to a really high number (~ 1h-ish)?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [flink] flinkbot commented on pull request #22591: [FLINK-31354][tests] Increased timeout for NettyClientServerSslTest to improve test stability

Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #22591:
URL: https://github.com/apache/flink/pull/22591#issuecomment-1549253676

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "ebb3338701efd7faa1b53eaa6955659e99e43391",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "ebb3338701efd7faa1b53eaa6955659e99e43391",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * ebb3338701efd7faa1b53eaa6955659e99e43391 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [flink] XComp commented on pull request #22591: [FLINK-31354][tests] Increased timeout for NettyClientServerSslTest to improve test stability

Posted by "XComp (via GitHub)" <gi...@apache.org>.
XComp commented on PR #22591:
URL: https://github.com/apache/flink/pull/22591#issuecomment-1549240399

   @zentol I guess, increasing the timeout should not cause any problems?! The test usually runs in milliseconds but occasionally runs into the 1000ms limit.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [flink] XComp commented on pull request #22591: [FLINK-31354][tests] Increased timeout for NettyClientServerSslTest to improve test stability

Posted by "XComp (via GitHub)" <gi...@apache.org>.
XComp commented on PR #22591:
URL: https://github.com/apache/flink/pull/22591#issuecomment-1556658548

   Yeah, we could do that. It doesn't do much of a difference to the test. The test sets up the Netty context and verifies that timeout config values are forwarded correctly. I changed the test slightly to serve different values rather than relying on the same value to improve the test case


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org