You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "AnandInguva (via GitHub)" <gi...@apache.org> on 2023/07/17 03:34:12 UTC
[GitHub] [beam] AnandInguva opened a new pull request, #27517: Add splitting string for string related data transforms
AnandInguva opened a new pull request, #27517:
URL: https://github.com/apache/beam/pull/27517
Fixes: https://github.com/apache/beam/issues/27505
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #27517: Add splitting string for string related data transforms
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #27517:
URL: https://github.com/apache/beam/pull/27517#issuecomment-1638562176
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @riteshghorse for label python.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] AnandInguva commented on pull request #27517: Add splitting string for string related data transforms
Posted by "AnandInguva (via GitHub)" <gi...@apache.org>.
AnandInguva commented on PR #27517:
URL: https://github.com/apache/beam/pull/27517#issuecomment-1638882666
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] commented on pull request #27517: Add splitting string for string related data transforms
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #27517:
URL: https://github.com/apache/beam/pull/27517#issuecomment-1637335510
## [Codecov](https://app.codecov.io/gh/apache/beam/pull/27517?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#27517](https://app.codecov.io/gh/apache/beam/pull/27517?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (e38dc5c) into [master](https://app.codecov.io/gh/apache/beam/commit/41e6628498c6ebdfc2932c61b68bcbde4da1a47e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (41e6628) will **not change** coverage.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #27517 +/- ##
=======================================
Coverage 71.16% 71.16%
=======================================
Files 861 861
Lines 104547 104547
=======================================
Hits 74401 74401
Misses 28597 28597
Partials 1549 1549
```
| [Impacted Files](https://app.codecov.io/gh/apache/beam/pull/27517?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [sdks/python/apache\_beam/ml/transforms/tft.py](https://app.codecov.io/gh/apache/beam/pull/27517?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vbWwvdHJhbnNmb3Jtcy90ZnQucHk=) | `6.99% <ø> (ø)` | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] AnandInguva merged pull request #27517: Add splitting string for string related data transforms
Posted by "AnandInguva (via GitHub)" <gi...@apache.org>.
AnandInguva merged PR #27517:
URL: https://github.com/apache/beam/pull/27517
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] AnandInguva commented on pull request #27517: Add splitting string for string related data transforms
Posted by "AnandInguva (via GitHub)" <gi...@apache.org>.
AnandInguva commented on PR #27517:
URL: https://github.com/apache/beam/pull/27517#issuecomment-1638559981
assign set of reviewers
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #27517: Add splitting string for string related data transforms
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #27517:
URL: https://github.com/apache/beam/pull/27517#issuecomment-1637364896
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment `assign set of reviewers`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] riteshghorse commented on a diff in pull request #27517: Add splitting string for string related data transforms
Posted by "riteshghorse (via GitHub)" <gi...@apache.org>.
riteshghorse commented on code in PR #27517:
URL: https://github.com/apache/beam/pull/27517#discussion_r1265721250
##########
sdks/python/apache_beam/ml/transforms/tft_test.py:
##########
@@ -353,7 +371,7 @@ def setUp(self) -> None:
def tearDown(self):
shutil.rmtree(self.artifact_location)
- def test_tfidf_batched_compute_vocab_size_during_runtime(self):
+ def test_tfidf__compute_vocab_size_during_runtime(self):
Review Comment:
```suggestion
def test_tfidf_compute_vocab_size_during_runtime(self):
```
##########
sdks/python/apache_beam/ml/transforms/tft_test.py:
##########
@@ -313,17 +289,17 @@ def test_compute_and_apply_vocabulary_unbatched_inputs(self):
assert_that(actual_data, equal_to(expected_data))
- def test_compute_and_apply_vocabulary_batched(self):
- batch_size = 100
- num_instances = batch_size + 1
+ def test_compute_and_apply_vocabulary_(self):
Review Comment:
```suggestion
def test_compute_and_apply_vocabulary(self):
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org