You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "paleolimbot (via GitHub)" <gi...@apache.org> on 2023/10/12 01:22:57 UTC
[PR] GH-38227: [R] Fix non-unicode character errors in nightly builds [arrow]
paleolimbot opened a new pull request, #38232:
URL: https://github.com/apache/arrow/pull/38232
### Rationale for this change
We have several nightly builds failing with errors building the manual as a result of unicode characters. The unicode characters aren't new, so I'm not sure why this happened now.
### What changes are included in this PR?
Install a distribution of latex that supports unicode characters (maybe)?
### Are these changes tested?
Yes
### Are there any user-facing changes?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38227: [R] Fix non-unicode character errors in nightly builds [arrow]
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #38232:
URL: https://github.com/apache/arrow/pull/38232#issuecomment-1764892257
After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit a2561e3499d8d20c26c118979703425b3e755155.
There were no benchmark performance regressions. 🎉
The [full Conbench report](https://github.com/apache/arrow/runs/17749262674) has more details. It also includes information about 2 possible false positives for unstable benchmarks that are known to sometimes produce them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38227: [R] Fix non-unicode character errors in nightly builds [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #38232:
URL: https://github.com/apache/arrow/pull/38232#issuecomment-1759562491
Revision: 9fa8e78d5877901bd30df2d63375ba8a6f146163
Submitted crossbow builds: [ursacomputing/crossbow @ actions-d70e56185b](https://github.com/ursacomputing/crossbow/branches/all?query=actions-d70e56185b)
|Task|Status|
|----|------|
|test-r-linux-as-cran|[](https://github.com/ursacomputing/crossbow/actions/runs/6495936798/job/17641854686)|
|test-r-rhub-debian-gcc-devel-lto-latest|[](https://github.com/ursacomputing/crossbow/runs/17641855434)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38227: [R] Fix non-unicode character errors in nightly builds [arrow]
Posted by "paleolimbot (via GitHub)" <gi...@apache.org>.
paleolimbot commented on PR #38232:
URL: https://github.com/apache/arrow/pull/38232#issuecomment-1759558486
@github-actions crossbow submit test-r-linux-as-cran test-r-rhub-debian-gcc-devel-lto-latest
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38227: [R] Fix non-unicode character errors in nightly builds [arrow]
Posted by "paleolimbot (via GitHub)" <gi...@apache.org>.
paleolimbot commented on PR #38232:
URL: https://github.com/apache/arrow/pull/38232#issuecomment-1758773427
@github-actions crossbow submit test-r-linux-as-cran test-r-rhub-debian-gcc-devel-lto-latest
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38227: [R] Fix non-unicode character errors in nightly builds [arrow]
Posted by "paleolimbot (via GitHub)" <gi...@apache.org>.
paleolimbot commented on PR #38232:
URL: https://github.com/apache/arrow/pull/38232#issuecomment-1759657861
@github-actions crossbow submit test-r-linux-as-cran test-r-rhub-debian-gcc-devel-lto-latest
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38227: [R] Fix non-unicode character errors in nightly builds [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #38232:
URL: https://github.com/apache/arrow/pull/38232#issuecomment-1759662281
Revision: 99515cd9b80261497693a58b0c4a2ab801632597
Submitted crossbow builds: [ursacomputing/crossbow @ actions-6942549ab7](https://github.com/ursacomputing/crossbow/branches/all?query=actions-6942549ab7)
|Task|Status|
|----|------|
|test-r-linux-as-cran|[](https://github.com/ursacomputing/crossbow/actions/runs/6496633797/job/17644007879)|
|test-r-rhub-debian-gcc-devel-lto-latest|[](https://github.com/ursacomputing/crossbow/runs/17644008752)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38227: [R] Fix non-unicode character errors in nightly builds [arrow]
Posted by "thisisnic (via GitHub)" <gi...@apache.org>.
thisisnic commented on code in PR #38232:
URL: https://github.com/apache/arrow/pull/38232#discussion_r1357449878
##########
r/R/csv.R:
##########
@@ -22,8 +22,8 @@
#' `readr::read_delim()`, and `col_select` was inspired by `vroom::vroom()`.
#'
#' `read_csv_arrow()` and `read_tsv_arrow()` are wrappers around
-#' `read_delim_arrow()` that specify a delimiter. `read_csv2_arrow()` uses `;` for
-#' the delimiter and `,` for the decimal point.
+#' `read_delim_arrow()` that specify a delimeter. `read_csv2_arrow()` uses `;` for
Review Comment:
I was corrected on this by someone else when working on this recently, but I believe that "delimiter" is the correct spelling here rather than "delimeter"?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38227: [R] Fix non-unicode character errors in nightly builds [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #38232:
URL: https://github.com/apache/arrow/pull/38232#issuecomment-1758775123
Revision: 7dd216810e33cb4f44c39f13609faa99d8e1c9a1
Submitted crossbow builds: [ursacomputing/crossbow @ actions-0f6dbd21de](https://github.com/ursacomputing/crossbow/branches/all?query=actions-0f6dbd21de)
|Task|Status|
|----|------|
|test-r-linux-as-cran|[](https://github.com/ursacomputing/crossbow/actions/runs/6490098517/job/17625392555)|
|test-r-rhub-debian-gcc-devel-lto-latest|[](https://github.com/ursacomputing/crossbow/runs/17625392911)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38227: [R] Fix non-unicode character errors in nightly builds [arrow]
Posted by "thisisnic (via GitHub)" <gi...@apache.org>.
thisisnic commented on code in PR #38232:
URL: https://github.com/apache/arrow/pull/38232#discussion_r1357450907
##########
r/R/csv.R:
##########
@@ -22,8 +22,8 @@
#' `readr::read_delim()`, and `col_select` was inspired by `vroom::vroom()`.
#'
#' `read_csv_arrow()` and `read_tsv_arrow()` are wrappers around
-#' `read_delim_arrow()` that specify a delimiter. `read_csv2_arrow()` uses `;` for
-#' the delimiter and `,` for the decimal point.
+#' `read_delim_arrow()` that specify a delimeter. `read_csv2_arrow()` uses `;` for
Review Comment:
Sorry, didn't realise this has merged, I'll open a PR!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38227: [R] Fix non-unicode character errors in nightly builds [arrow]
Posted by "paleolimbot (via GitHub)" <gi...@apache.org>.
paleolimbot commented on PR #38232:
URL: https://github.com/apache/arrow/pull/38232#issuecomment-1759659385
@thisisnic Can you give this a review? I think we may have introduced a non-printable character in a recent PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38227: [R] Fix non-unicode character errors in nightly builds [arrow]
Posted by "assignUser (via GitHub)" <gi...@apache.org>.
assignUser merged PR #38232:
URL: https://github.com/apache/arrow/pull/38232
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38227: [R] Fix non-unicode character errors in nightly builds [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #38232:
URL: https://github.com/apache/arrow/pull/38232#issuecomment-1758770648
:warning: GitHub issue #38227 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38227: [R] Fix non-unicode character errors in nightly builds [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #38232:
URL: https://github.com/apache/arrow/pull/38232#issuecomment-1759671735
Revision: f7df7a36d28b315412559f182979bf9cf9b21edd
Submitted crossbow builds: [ursacomputing/crossbow @ actions-33bf7ee5ff](https://github.com/ursacomputing/crossbow/branches/all?query=actions-33bf7ee5ff)
|Task|Status|
|----|------|
|test-r-linux-as-cran|[](https://github.com/ursacomputing/crossbow/actions/runs/6496690719/job/17644203288)|
|test-r-rhub-debian-gcc-devel-lto-latest|[](https://github.com/ursacomputing/crossbow/runs/17644204469)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38227: [R] Fix non-unicode character errors in nightly builds [arrow]
Posted by "paleolimbot (via GitHub)" <gi...@apache.org>.
paleolimbot commented on PR #38232:
URL: https://github.com/apache/arrow/pull/38232#issuecomment-1759667399
@github-actions crossbow submit test-r-linux-as-cran test-r-rhub-debian-gcc-devel-lto-latest
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org