You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pivot.apache.org by "xiefei (JIRA)" <ji...@apache.org> on 2011/03/09 10:56:59 UTC
[jira] Created: (PIVOT-713) GridPane.Row should not be final
GridPane.Row should not be final
--------------------------------
Key: PIVOT-713
URL: https://issues.apache.org/jira/browse/PIVOT-713
Project: Pivot
Issue Type: Bug
Components: wtk
Affects Versions: 2.0
Reporter: xiefei
Priority: Minor
I need to inherit from GridPane.Row but it's final. And I find that TablePane.Row is not final.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (PIVOT-713) Consider making some inner classes
non-final
Posted by "Sandro Martini (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIVOT-713?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sandro Martini updated PIVOT-713:
---------------------------------
Attachment: patch.patch
removed final from GridPane.Row, and add protected method there and even in TablePane.Row, as requested
> Consider making some inner classes non-final
> --------------------------------------------
>
> Key: PIVOT-713
> URL: https://issues.apache.org/jira/browse/PIVOT-713
> Project: Pivot
> Issue Type: Improvement
> Components: wtk
> Affects Versions: 2.0
> Reporter: xiefei
> Assignee: Sandro Martini
> Priority: Minor
> Fix For: 2.0.1
>
> Attachments: patch.patch
>
>
> I am implementing a groovy-builder-like DSL for pivot using scala. In the DSL, I need subclass of each component/container that retains original component/container behavior but is aware of the DSL context as well. All goes well except GridPane.Row.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (PIVOT-713) GridPane.Row should not be final
Posted by "Sandro Martini (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIVOT-713?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sandro Martini updated PIVOT-713:
---------------------------------
Fix Version/s: 2.0.1
Assignee: Sandro Martini
Issue Type: Improvement (was: Bug)
Mark as improvement, because in standard cases this works good, but currently it's not overridable.
> GridPane.Row should not be final
> --------------------------------
>
> Key: PIVOT-713
> URL: https://issues.apache.org/jira/browse/PIVOT-713
> Project: Pivot
> Issue Type: Improvement
> Components: wtk
> Affects Versions: 2.0
> Reporter: xiefei
> Assignee: Sandro Martini
> Priority: Minor
> Fix For: 2.0.1
>
>
> I need to inherit from GridPane.Row but it's final. And I find that TablePane.Row is not final.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (PIVOT-713) GridPane.Row should not be final
Posted by "Chris Bartlett (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIVOT-713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13004503#comment-13004503 ]
Chris Bartlett commented on PIVOT-713:
--------------------------------------
Before undertaking this change, it might be worth performing a quick review of similar public final classes to see if there are other inconsistencies.
If GridPane.Row will be made non-final, should it's private 'cells' field also be changed to protected or a protected getter added? (And then also for TablePane.Row to be consistent?)
> GridPane.Row should not be final
> --------------------------------
>
> Key: PIVOT-713
> URL: https://issues.apache.org/jira/browse/PIVOT-713
> Project: Pivot
> Issue Type: Improvement
> Components: wtk
> Affects Versions: 2.0
> Reporter: xiefei
> Assignee: Sandro Martini
> Priority: Minor
> Fix For: 2.0.1
>
>
> I need to inherit from GridPane.Row but it's final. And I find that TablePane.Row is not final.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (PIVOT-713) Consider making some inner classes
non-final
Posted by "Greg Brown (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIVOT-713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13007004#comment-13007004 ]
Greg Brown commented on PIVOT-713:
----------------------------------
You should search for public static final classes only - private or non-static inner classes should probably remain as-is.
> Consider making some inner classes non-final
> --------------------------------------------
>
> Key: PIVOT-713
> URL: https://issues.apache.org/jira/browse/PIVOT-713
> Project: Pivot
> Issue Type: Improvement
> Components: wtk
> Affects Versions: 2.0
> Reporter: xiefei
> Assignee: Sandro Martini
> Priority: Minor
> Fix For: 2.0.1
>
> Attachments: patch.patch, pivot_final_class_grep.txt
>
>
> I am implementing a groovy-builder-like DSL for pivot using scala. In the DSL, I need subclass of each component/container that retains original component/container behavior but is aware of the DSL context as well. All goes well except GridPane.Row.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (PIVOT-713) Consider making some inner classes
non-final
Posted by "Greg Brown (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIVOT-713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13008445#comment-13008445 ]
Greg Brown commented on PIVOT-713:
----------------------------------
No, cells should not have a protected accessor. GridPane.Row implements Sequence<Component> and wraps the cell list, so its contents are already accessible. Further, providing a protected accessor would allow subclasses to circumvent the event processing performed by the base class, which would be bad.
The use case for making these classes non-final is simply to support builders - it shouldn't be viewed as an excuse to break encapsulation.
> Consider making some inner classes non-final
> --------------------------------------------
>
> Key: PIVOT-713
> URL: https://issues.apache.org/jira/browse/PIVOT-713
> Project: Pivot
> Issue Type: Improvement
> Components: wtk
> Affects Versions: 2.0
> Reporter: xiefei
> Assignee: Sandro Martini
> Priority: Minor
> Fix For: 2.0.1
>
> Attachments: patch.patch, patch_remove_final_from_all_public_static_final_class.patch, pivot_final_class_grep.txt, pivot_public_static_final_class_grep.txt
>
>
> I am implementing a groovy-builder-like DSL for pivot using scala. In the DSL, I need subclass of each component/container that retains original component/container behavior but is aware of the DSL context as well. All goes well except GridPane.Row.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (PIVOT-713) Consider making some inner classes
non-final
Posted by "Greg Brown (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIVOT-713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13008436#comment-13008436 ]
Greg Brown commented on PIVOT-713:
----------------------------------
No, the first patch is wrong too. The only classes that should be made non-final are GridPane.Row and TableView.Column.
> Consider making some inner classes non-final
> --------------------------------------------
>
> Key: PIVOT-713
> URL: https://issues.apache.org/jira/browse/PIVOT-713
> Project: Pivot
> Issue Type: Improvement
> Components: wtk
> Affects Versions: 2.0
> Reporter: xiefei
> Assignee: Sandro Martini
> Priority: Minor
> Fix For: 2.0.1
>
> Attachments: patch.patch, patch_remove_final_from_all_public_static_final_class.patch, pivot_final_class_grep.txt, pivot_public_static_final_class_grep.txt
>
>
> I am implementing a groovy-builder-like DSL for pivot using scala. In the DSL, I need subclass of each component/container that retains original component/container behavior but is aware of the DSL context as well. All goes well except GridPane.Row.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (PIVOT-713) Consider making some inner classes
non-final
Posted by "Greg Brown (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIVOT-713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13006911#comment-13006911 ]
Greg Brown commented on PIVOT-713:
----------------------------------
> If there are other issues I'm not against removing the final qualifier, but probably we should see what real cases are requiring it.
The use case is the builder pattern. A similar issue came up a couple months back when a Java-based builder pattern was suggested. Unless all of these classes are made non-final, such patterns cannot be universally employed.
I suggest that you generate a list of static final classes and attach it to this issue for review.
> Consider making some inner classes non-final
> --------------------------------------------
>
> Key: PIVOT-713
> URL: https://issues.apache.org/jira/browse/PIVOT-713
> Project: Pivot
> Issue Type: Improvement
> Components: wtk
> Affects Versions: 2.0
> Reporter: xiefei
> Assignee: Sandro Martini
> Priority: Minor
> Fix For: 2.0.1
>
> Attachments: patch.patch
>
>
> I am implementing a groovy-builder-like DSL for pivot using scala. In the DSL, I need subclass of each component/container that retains original component/container behavior but is aware of the DSL context as well. All goes well except GridPane.Row.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (PIVOT-713) Consider making some inner classes
non-final
Posted by "Sandro Martini (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIVOT-713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13008451#comment-13008451 ]
Sandro Martini commented on PIVOT-713:
--------------------------------------
Ok, now all is clear (I hope :-) ).
Thank you very much
> Consider making some inner classes non-final
> --------------------------------------------
>
> Key: PIVOT-713
> URL: https://issues.apache.org/jira/browse/PIVOT-713
> Project: Pivot
> Issue Type: Improvement
> Components: wtk
> Affects Versions: 2.0
> Reporter: xiefei
> Assignee: Sandro Martini
> Priority: Minor
> Fix For: 2.0.1
>
> Attachments: patch.patch, patch_remove_final_from_all_public_static_final_class.patch, pivot_final_class_grep.txt, pivot_public_static_final_class_grep.txt
>
>
> I am implementing a groovy-builder-like DSL for pivot using scala. In the DSL, I need subclass of each component/container that retains original component/container behavior but is aware of the DSL context as well. All goes well except GridPane.Row.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (PIVOT-713) Consider making some inner classes
non-final
Posted by "Greg Brown (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIVOT-713?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Greg Brown updated PIVOT-713:
-----------------------------
Description: I am implementing a groovy-builder-like DSL for pivot using scala. In the DSL, I need subclass of each component/container that retains original component/container behavior but is aware of the DSL context as well. All goes well except GridPane.Row. (was: I need to inherit from GridPane.Row but it's final. And I find that TablePane.Row is not final.)
FYI, I copied your comment into the description field so that it is easier to understand the motivation behind this issue.
> Consider making some inner classes non-final
> --------------------------------------------
>
> Key: PIVOT-713
> URL: https://issues.apache.org/jira/browse/PIVOT-713
> Project: Pivot
> Issue Type: Improvement
> Components: wtk
> Affects Versions: 2.0
> Reporter: xiefei
> Assignee: Sandro Martini
> Priority: Minor
> Fix For: 2.0.1
>
>
> I am implementing a groovy-builder-like DSL for pivot using scala. In the DSL, I need subclass of each component/container that retains original component/container behavior but is aware of the DSL context as well. All goes well except GridPane.Row.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Resolved: (PIVOT-713) Consider making some inner classes
non-final
Posted by "Sandro Martini (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIVOT-713?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sandro Martini resolved PIVOT-713.
----------------------------------
Resolution: Fixed
resolved, as discussed with Greg and others
> Consider making some inner classes non-final
> --------------------------------------------
>
> Key: PIVOT-713
> URL: https://issues.apache.org/jira/browse/PIVOT-713
> Project: Pivot
> Issue Type: Improvement
> Components: wtk
> Affects Versions: 2.0
> Reporter: xiefei
> Assignee: Sandro Martini
> Priority: Minor
> Fix For: 2.0.1
>
> Attachments: patch.patch, patch_remove_final_from_all_public_static_final_class.patch, pivot_final_class_grep.txt, pivot_public_static_final_class_grep.txt
>
>
> I am implementing a groovy-builder-like DSL for pivot using scala. In the DSL, I need subclass of each component/container that retains original component/container behavior but is aware of the DSL context as well. All goes well except GridPane.Row.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (PIVOT-713) Consider making some inner classes
non-final
Posted by "Sandro Martini (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIVOT-713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13006908#comment-13006908 ]
Sandro Martini commented on PIVOT-713:
--------------------------------------
No, at the moment I've only fixed the required class and add method, as requested here.
If there are other issues I'm not against removing the final qualifier, but probably we should see what real cases are requiring it. But I think it's safe to commit this small patch at the moment.
If you think it's useful, I can try to search all "public static final class" under the skin and remove the final ... what do you think ?
> Consider making some inner classes non-final
> --------------------------------------------
>
> Key: PIVOT-713
> URL: https://issues.apache.org/jira/browse/PIVOT-713
> Project: Pivot
> Issue Type: Improvement
> Components: wtk
> Affects Versions: 2.0
> Reporter: xiefei
> Assignee: Sandro Martini
> Priority: Minor
> Fix For: 2.0.1
>
> Attachments: patch.patch
>
>
> I am implementing a groovy-builder-like DSL for pivot using scala. In the DSL, I need subclass of each component/container that retains original component/container behavior but is aware of the DSL context as well. All goes well except GridPane.Row.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (PIVOT-713) Consider making some inner classes
non-final
Posted by "Sandro Martini (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIVOT-713?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sandro Martini updated PIVOT-713:
---------------------------------
Attachment: patch_remove_final_from_all_public_static_final_class.patch
Patch to remove final from all public static final class in Pivot sources.
Tell me if it's Ok to apply.
> Consider making some inner classes non-final
> --------------------------------------------
>
> Key: PIVOT-713
> URL: https://issues.apache.org/jira/browse/PIVOT-713
> Project: Pivot
> Issue Type: Improvement
> Components: wtk
> Affects Versions: 2.0
> Reporter: xiefei
> Assignee: Sandro Martini
> Priority: Minor
> Fix For: 2.0.1
>
> Attachments: patch.patch, patch_remove_final_from_all_public_static_final_class.patch, pivot_final_class_grep.txt, pivot_public_static_final_class_grep.txt
>
>
> I am implementing a groovy-builder-like DSL for pivot using scala. In the DSL, I need subclass of each component/container that retains original component/container behavior but is aware of the DSL context as well. All goes well except GridPane.Row.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (PIVOT-713) GridPane.Row should not be final
Posted by "Greg Brown (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIVOT-713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13004508#comment-13004508 ]
Greg Brown commented on PIVOT-713:
----------------------------------
What is the use case for extending this class? I'm not suggesting there isn't one - I'd just like to understand what it is.
> GridPane.Row should not be final
> --------------------------------
>
> Key: PIVOT-713
> URL: https://issues.apache.org/jira/browse/PIVOT-713
> Project: Pivot
> Issue Type: Improvement
> Components: wtk
> Affects Versions: 2.0
> Reporter: xiefei
> Assignee: Sandro Martini
> Priority: Minor
> Fix For: 2.0.1
>
>
> I need to inherit from GridPane.Row but it's final. And I find that TablePane.Row is not final.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (PIVOT-713) Consider making some inner classes
non-final
Posted by "Greg Brown (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIVOT-713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13007895#comment-13007895 ]
Greg Brown commented on PIVOT-713:
----------------------------------
Actually, now that I see the list, I think the only ones that should be non-final are GridPane.Row and TableView.Column. The others are not as likely to be subclassed.
> Consider making some inner classes non-final
> --------------------------------------------
>
> Key: PIVOT-713
> URL: https://issues.apache.org/jira/browse/PIVOT-713
> Project: Pivot
> Issue Type: Improvement
> Components: wtk
> Affects Versions: 2.0
> Reporter: xiefei
> Assignee: Sandro Martini
> Priority: Minor
> Fix For: 2.0.1
>
> Attachments: patch.patch, patch_remove_final_from_all_public_static_final_class.patch, pivot_final_class_grep.txt, pivot_public_static_final_class_grep.txt
>
>
> I am implementing a groovy-builder-like DSL for pivot using scala. In the DSL, I need subclass of each component/container that retains original component/container behavior but is aware of the DSL context as well. All goes well except GridPane.Row.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (PIVOT-713) Consider making some inner classes
non-final
Posted by "Greg Brown (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIVOT-713?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Greg Brown updated PIVOT-713:
-----------------------------
Summary: Consider making some inner classes non-final (was: GridPane.Row should not be final)
Renaming issue to more accurately capture the requirement.
> Consider making some inner classes non-final
> --------------------------------------------
>
> Key: PIVOT-713
> URL: https://issues.apache.org/jira/browse/PIVOT-713
> Project: Pivot
> Issue Type: Improvement
> Components: wtk
> Affects Versions: 2.0
> Reporter: xiefei
> Assignee: Sandro Martini
> Priority: Minor
> Fix For: 2.0.1
>
>
> I need to inherit from GridPane.Row but it's final. And I find that TablePane.Row is not final.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (PIVOT-713) Consider making some inner classes
non-final
Posted by "Greg Brown (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIVOT-713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13006889#comment-13006889 ]
Greg Brown commented on PIVOT-713:
----------------------------------
There may be a few others as well. Did you search for "public static final class"?
> Consider making some inner classes non-final
> --------------------------------------------
>
> Key: PIVOT-713
> URL: https://issues.apache.org/jira/browse/PIVOT-713
> Project: Pivot
> Issue Type: Improvement
> Components: wtk
> Affects Versions: 2.0
> Reporter: xiefei
> Assignee: Sandro Martini
> Priority: Minor
> Fix For: 2.0.1
>
> Attachments: patch.patch
>
>
> I am implementing a groovy-builder-like DSL for pivot using scala. In the DSL, I need subclass of each component/container that retains original component/container behavior but is aware of the DSL context as well. All goes well except GridPane.Row.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (PIVOT-713) GridPane.Row should not be final
Posted by "xiefei (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIVOT-713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13004924#comment-13004924 ]
xiefei commented on PIVOT-713:
------------------------------
I am implementing a groovy-builder-like DSL for pivot using scala. In the DSL, I need subclass of each component/container that retains original component/container behavior but is aware of the DSL context as well. All goes well except GridPane.Row.
> GridPane.Row should not be final
> --------------------------------
>
> Key: PIVOT-713
> URL: https://issues.apache.org/jira/browse/PIVOT-713
> Project: Pivot
> Issue Type: Improvement
> Components: wtk
> Affects Versions: 2.0
> Reporter: xiefei
> Assignee: Sandro Martini
> Priority: Minor
> Fix For: 2.0.1
>
>
> I need to inherit from GridPane.Row but it's final. And I find that TablePane.Row is not final.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (PIVOT-713) Consider making some inner classes
non-final
Posted by "Sandro Martini (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIVOT-713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13008443#comment-13008443 ]
Sandro Martini commented on PIVOT-713:
--------------------------------------
Ok, I'll change only those definitions.
But what do you think on this comment by Chris ?
>If GridPane.Row will be made non-final, should it's private 'cells' field also be changed to protected or a protected getter added? (And then also for TablePane.Row to be consistent?)
So my previous addition even of a protected getCells() method in GridPane and TablePane.
Tell me if this is needed.
And last:
wtk\src\org\apache\pivot\wtk\GridPane.java
00260: public static class Filler extends Component {
wtk\src\org\apache\pivot\wtk\TablePane.java
00622: public static final class Filler extends Component {
I think it would be better to put GridPane.Filler final, ok ? Tell me.
Bye,
Sandro
> Consider making some inner classes non-final
> --------------------------------------------
>
> Key: PIVOT-713
> URL: https://issues.apache.org/jira/browse/PIVOT-713
> Project: Pivot
> Issue Type: Improvement
> Components: wtk
> Affects Versions: 2.0
> Reporter: xiefei
> Assignee: Sandro Martini
> Priority: Minor
> Fix For: 2.0.1
>
> Attachments: patch.patch, patch_remove_final_from_all_public_static_final_class.patch, pivot_final_class_grep.txt, pivot_public_static_final_class_grep.txt
>
>
> I am implementing a groovy-builder-like DSL for pivot using scala. In the DSL, I need subclass of each component/container that retains original component/container behavior but is aware of the DSL context as well. All goes well except GridPane.Row.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (PIVOT-713) Consider making some inner classes
non-final
Posted by "Sandro Martini (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIVOT-713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13008431#comment-13008431 ]
Sandro Martini commented on PIVOT-713:
--------------------------------------
Ok, so in next days I'll revert and apply only the first patch (patch.patch, here in attach).
Later if some other change will be required, be free to reopen the ticket and add some info.
Bye,
Sandro
> Consider making some inner classes non-final
> --------------------------------------------
>
> Key: PIVOT-713
> URL: https://issues.apache.org/jira/browse/PIVOT-713
> Project: Pivot
> Issue Type: Improvement
> Components: wtk
> Affects Versions: 2.0
> Reporter: xiefei
> Assignee: Sandro Martini
> Priority: Minor
> Fix For: 2.0.1
>
> Attachments: patch.patch, patch_remove_final_from_all_public_static_final_class.patch, pivot_final_class_grep.txt, pivot_public_static_final_class_grep.txt
>
>
> I am implementing a groovy-builder-like DSL for pivot using scala. In the DSL, I need subclass of each component/container that retains original component/container behavior but is aware of the DSL context as well. All goes well except GridPane.Row.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (PIVOT-713) Consider making some inner classes
non-final
Posted by "Sandro Martini (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIVOT-713?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sandro Martini updated PIVOT-713:
---------------------------------
Attachment: pivot_final_class_grep.txt
this is the list of Pivot sources (I think updated to last week) containing "final class" inside
> Consider making some inner classes non-final
> --------------------------------------------
>
> Key: PIVOT-713
> URL: https://issues.apache.org/jira/browse/PIVOT-713
> Project: Pivot
> Issue Type: Improvement
> Components: wtk
> Affects Versions: 2.0
> Reporter: xiefei
> Assignee: Sandro Martini
> Priority: Minor
> Fix For: 2.0.1
>
> Attachments: patch.patch, pivot_final_class_grep.txt
>
>
> I am implementing a groovy-builder-like DSL for pivot using scala. In the DSL, I need subclass of each component/container that retains original component/container behavior but is aware of the DSL context as well. All goes well except GridPane.Row.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (PIVOT-713) Consider making some inner classes
non-final
Posted by "Sandro Martini (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIVOT-713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13007001#comment-13007001 ]
Sandro Martini commented on PIVOT-713:
--------------------------------------
just put in attach a txt containing the output of a grep "final class" on all Pivot sources.
In my opinion could be good to remove final from all wtk-terra and maybe even wtk classes, but for core and other classes I don't know, we have to look better ... Greg and Chris what do you think ?
xiefei, you think it would be enough for your Scala code to work ?
Bye,
Sandro
> Consider making some inner classes non-final
> --------------------------------------------
>
> Key: PIVOT-713
> URL: https://issues.apache.org/jira/browse/PIVOT-713
> Project: Pivot
> Issue Type: Improvement
> Components: wtk
> Affects Versions: 2.0
> Reporter: xiefei
> Assignee: Sandro Martini
> Priority: Minor
> Fix For: 2.0.1
>
> Attachments: patch.patch, pivot_final_class_grep.txt
>
>
> I am implementing a groovy-builder-like DSL for pivot using scala. In the DSL, I need subclass of each component/container that retains original component/container behavior but is aware of the DSL context as well. All goes well except GridPane.Row.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (PIVOT-713) Consider making some inner classes
non-final
Posted by "Sandro Martini (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIVOT-713?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sandro Martini updated PIVOT-713:
---------------------------------
Attachment: pivot_public_static_final_class_grep.txt
list of Pivot sources containing "public static final class".
Note that I have to verify what FindBugs say after removing the final keyword (on performances etc) in some of them, just for test.
> Consider making some inner classes non-final
> --------------------------------------------
>
> Key: PIVOT-713
> URL: https://issues.apache.org/jira/browse/PIVOT-713
> Project: Pivot
> Issue Type: Improvement
> Components: wtk
> Affects Versions: 2.0
> Reporter: xiefei
> Assignee: Sandro Martini
> Priority: Minor
> Fix For: 2.0.1
>
> Attachments: patch.patch, pivot_final_class_grep.txt, pivot_public_static_final_class_grep.txt
>
>
> I am implementing a groovy-builder-like DSL for pivot using scala. In the DSL, I need subclass of each component/container that retains original component/container behavior but is aware of the DSL context as well. All goes well except GridPane.Row.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (PIVOT-713) Consider making some inner classes
non-final
Posted by "Sandro Martini (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIVOT-713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13006709#comment-13006709 ]
Sandro Martini commented on PIVOT-713:
--------------------------------------
Hi all,
with the patch here in attach I think all the changes required are done, tell me if they are Ok (and maybe if something other here or in other related classes is missing), so please try the fix. If there aren't objections, next week I'll commit the patch.
Bye,
Sandro
> Consider making some inner classes non-final
> --------------------------------------------
>
> Key: PIVOT-713
> URL: https://issues.apache.org/jira/browse/PIVOT-713
> Project: Pivot
> Issue Type: Improvement
> Components: wtk
> Affects Versions: 2.0
> Reporter: xiefei
> Assignee: Sandro Martini
> Priority: Minor
> Fix For: 2.0.1
>
> Attachments: patch.patch
>
>
> I am implementing a groovy-builder-like DSL for pivot using scala. In the DSL, I need subclass of each component/container that retains original component/container behavior but is aware of the DSL context as well. All goes well except GridPane.Row.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira