You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Anonymous Coward (Code Review)" <ge...@cloudera.org> on 2019/11/12 07:31:02 UTC
[kudu-CR] [cfile] No longer need to `relocate()` in `ReadBlock()`
lingbinlb@gmail.com has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14693
Change subject: [cfile] No longer need to `relocate()` in `ReadBlock()`
......................................................................
[cfile] No longer need to `relocate()` in `ReadBlock()`
In the current implementation, when reading data from
`ReadableBlock`, the `Slice` object will no longer be
modified, but just fill it with data. That is,
slice->data() will always match pre-allocated buffer.
Change-Id: I1619d05d42c9ec20e029097aaaf37b3ac93b9a69
---
M src/kudu/cfile/cfile_reader.cc
1 file changed, 0 insertions(+), 6 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/93/14693/1
--
To view, visit http://gerrit.cloudera.org:8080/14693
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1619d05d42c9ec20e029097aaaf37b3ac93b9a69
Gerrit-Change-Number: 14693
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <li...@gmail.com>
[kudu-CR] [cfile] No longer need to `relocate()` in `ReadBlock()`
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14693 )
Change subject: [cfile] No longer need to `relocate()` in `ReadBlock()`
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/14693
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1619d05d42c9ec20e029097aaaf37b3ac93b9a69
Gerrit-Change-Number: 14693
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <li...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 12 Nov 2019 07:51:41 +0000
Gerrit-HasComments: No
[kudu-CR] [cfile] No longer need to `relocate()` in `ReadBlock()`
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14693 )
Change subject: [cfile] No longer need to `relocate()` in `ReadBlock()`
......................................................................
[cfile] No longer need to `relocate()` in `ReadBlock()`
In the current implementation, when reading data from
`ReadableBlock`, the `Slice` object will no longer be
modified, but just fill it with data. That is,
slice->data() will always match pre-allocated buffer.
Change-Id: I1619d05d42c9ec20e029097aaaf37b3ac93b9a69
Reviewed-on: http://gerrit.cloudera.org:8080/14693
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Kudu Jenkins
---
M src/kudu/cfile/cfile_reader.cc
1 file changed, 0 insertions(+), 6 deletions(-)
Approvals:
Adar Dembo: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/14693
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I1619d05d42c9ec20e029097aaaf37b3ac93b9a69
Gerrit-Change-Number: 14693
Gerrit-PatchSet: 2
Gerrit-Owner: Anonymous Coward <li...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)