You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/06/05 07:33:55 UTC
[GitHub] [flink] zhijiangW commented on a change in pull request #12489: [FLINK-18136] Don't start channel state writing for savepoints (RPC)
zhijiangW commented on a change in pull request #12489:
URL: https://github.com/apache/flink/pull/12489#discussion_r435740703
##########
File path: flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/tasks/SubtaskCheckpointCoordinatorTest.java
##########
@@ -373,4 +405,35 @@ public void processWatermark(Watermark mark) throws Exception {
public void processLatencyMarker(LatencyMarker latencyMarker) {
}
}
+
+ private static SubtaskCheckpointCoordinator coordinator(boolean unalignedCheckpointEnabled, ChannelStateWriter channelStateWriter) throws IOException {
+ return new SubtaskCheckpointCoordinatorImpl(
+ checkpointStorageWorkerView(100),
Review comment:
nit: can use `new TestCheckpointStorageWorkerView(100)` for simple.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org