[GitHub] [incubator-eventmesh] SteveYurongSu commented on pull request #439: [ISSUE #438] Enable Github Actions for Checkstyle

[GitBox <gi...@apache.org>]

SteveYurongSu commented on pull request #439:
URL: https://github.com/apache/incubator-eventmesh/pull/439#issuecomment-880518842


   @ruanwenjun Thanks for your comments!
   
   > We can also use the checkstyle plugin in IDEA to help us check our code style.
   
   Sure! This can make our codebase healthy and clean!
   
   > Does the checkstyle file need to be consistent with the codestyle file?
   
   I only added the following checks in the Checkstyle configuration file:
   
   * invoking System.out.println in source code
   * @author copyright
   * Chinese characters
   * PackageName must match "^(org)\.apache(\.[a-zA-Z][a-zA-Z0-9]*)+$"
   
   >  It seems that we don't have a clear code specification currently.
   
   When we have a clear code style, we can add more constraints. 
   Personally, I prefer the Google coding style. 😊


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org