You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tubemq.apache.org by GitBox <gi...@apache.org> on 2020/01/13 06:43:58 UTC
[GitHub] [incubator-tubemq] Technoboy- opened a new pull request #10:
[TUBEMQ-19] correct parameter spelling
Technoboy- opened a new pull request #10: [TUBEMQ-19] correct parameter spelling
URL: https://github.com/apache/incubator-tubemq/pull/10
https://issues.apache.org/jira/browse/TUBEMQ-19
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tubemq] TisonKun commented on issue #10: [TUBEMQ-19]
correct parameter spelling
Posted by GitBox <gi...@apache.org>.
TisonKun commented on issue #10: [TUBEMQ-19] correct parameter spelling
URL: https://github.com/apache/incubator-tubemq/pull/10#issuecomment-573529341
Thanks for your contribution @Technoboy- . As a suggestion you can use a detailed title instead of a general one. A detailed title helps on reading commit log later.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tubemq] TisonKun merged pull request #10: [TUBEMQ-19]
JVMClusterUtil#startup : regionservers -> regionServers & RowLock#getLock :
lockid -> lockId
Posted by GitBox <gi...@apache.org>.
TisonKun merged pull request #10: [TUBEMQ-19] JVMClusterUtil#startup : regionservers -> regionServers & RowLock#getLock : lockid -> lockId
URL: https://github.com/apache/incubator-tubemq/pull/10
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tubemq] Technoboy- commented on issue #10: [TUBEMQ-19]
JVMClusterUtil#startup : regionservers -> regionServers & RowLock#getLock :
lockid -> lockId
Posted by GitBox <gi...@apache.org>.
Technoboy- commented on issue #10: [TUBEMQ-19] JVMClusterUtil#startup : regionservers -> regionServers & RowLock#getLock : lockid -> lockId
URL: https://github.com/apache/incubator-tubemq/pull/10#issuecomment-573973433
> Thanks for your contribution @Technoboy- . As a suggestion you can use a detailed title instead of a general one. A detailed title helps on reading commit log later.
Ok, I have updated the title
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tubemq] TisonKun commented on issue #10: [TUBEMQ-19]
Correct parameter names to fit in camel case
Posted by GitBox <gi...@apache.org>.
TisonKun commented on issue #10: [TUBEMQ-19] Correct parameter names to fit in camel case
URL: https://github.com/apache/incubator-tubemq/pull/10#issuecomment-573974430
Thanks for your contribution! Merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services