You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2023/04/11 16:54:00 UTC

[jira] [Commented] (SOLR-16458) Cosmetic improvements and migration to JAX-RS ("node" APIs)

    [ https://issues.apache.org/jira/browse/SOLR-16458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17711058#comment-17711058 ] 

ASF subversion and git services commented on SOLR-16458:
--------------------------------------------------------

Commit c937bc2e5f40ce93102b65e71360f5b9a6907270 in solr's branch refs/heads/main from Calvince Otieno
[ https://gitbox.apache.org/repos/asf?p=solr.git;h=c937bc2e5f4 ]

SOLR-16458: Migrate v2 logging APIs to JAX-RS (#1160)

This commit splits up the various functional APIs in LoggingHandler and
gives them separate JAX-RS endpoints.

v2 APIs are now available for:
  - list logger levels (GET /api/node/logging/levels)
  - bulk update logger levels (PUT /api/node/logging/levels)
  - fetch log messages (GET /api/node/logging/messages)
  - tweak log-listener level (PUT /api/node/logging/messages/threshold)

Co-authored-by: Calvince Otieno <si...@yahoo.com>
Co-authored-by: Jason Gerlowski <ge...@apache.org>

> Cosmetic improvements and migration to JAX-RS ("node" APIs)
> -----------------------------------------------------------
>
>                 Key: SOLR-16458
>                 URL: https://issues.apache.org/jira/browse/SOLR-16458
>             Project: Solr
>          Issue Type: Sub-task
>          Components: v2 API
>    Affects Versions: 9.1, main (10.0)
>            Reporter: Jason Gerlowski
>            Priority: Major
>              Labels: newdev
>          Time Spent: 50m
>  Remaining Estimate: 0h
>
> As mentioned on SOLR-15781, the v2 API currently has an experimental designation, and the community has expressed an interest in using this period to update our v2 endpoints to be more REST-ful and consistent.  The current plan is to follow the specific changes laid out in [this spreadsheet|https://docs.google.com/spreadsheets/d/1HAoBBFPpSiT8mJmgNZKkZAPwfCfPvlc08m5jz3fQBpA/edit?usp=sharing], though of course nothing there is set in stone and there are still warts to be worked out.
> While we're touching the code for these endpoints, we should also convert them to JAX-RS framework definitions.  (This was initially tracked as a separate effort - see SOLR-16370 - but the edit that were required ended up overlapping so significantly with the "cosmetic" improvements here that in practice it almost always makes sense to do the two together.)
> This ticket plans to tackle making the changes required for Solr's "node" APIs: those commands or actions that (primarily) affect the receiving node only such as log-level changes, setting and removing node roles, etc.  These are described in detail in the spreadsheet linked above, but summarized in the table below for convenience and ease of tracking.
> *Cosmetic Changes and JAX-RS Conversion*
> ||API Name||Original Form||Desired Form||Status||Volunteer||
> |List Log Levels|GET /api/node/logging|GET /api/node/logging/levels|Open|N/A|
> |Update Log Level|GET /api/node/logging?set=className:WARN|PUT /api/node/logging/levels \{"className": "WARN"\}|Open|N/A|
> |Retrieve Log Messages|GET /api/node/logging?since=123456789|GET /api/node/logging/messages?since=123456789|Open|N/A|
> |Add Role to Node|POST /api/cluster \{"add-role": \{...\}\}|PUT /api/nodes/nodeName/roles/roleName|Open|N/A|
> |Remove Role from Node|POST /api/cluster \{"remove-role": \{...\}\}|DELETE /api/nodes/nodeName/roles/roleName|Open|N/A|
> *JAX-RS Conversion Only*
> ||API Name||Endpoint||Status||Volunteer||
> |List Threads on Node|GET /api/node/threads|Open|N/A|



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org