You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@distributedlog.apache.org by sijie <gi...@git.apache.org> on 2017/05/30 08:43:05 UTC
[GitHub] incubator-distributedlog pull request #131: DL-205: Remove StatusCode depend...
GitHub user sijie opened a pull request:
https://github.com/apache/incubator-distributedlog/pull/131
DL-205: Remove StatusCode dependency on DLException
- Remove StatusCode from exceptions. Use integer as exception codes.
- Also re-organize the modules:
- [ ] distributedlog-protocol (for core structures) and distributedlog-core (for core library).
- [ ] proxy: distributedlog-proxy-protocol (new module for thrift generated protocol), distributedlog-proxy-client (proxy client) and distributedlog-proxy-server (proxy server)
- [ ] benchmark & tutorials.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sijie/incubator-distributedlog new_layout
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-distributedlog/pull/131.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #131
----
commit 54c2de047e1656e34ead7fb54070441afd9c140d
Author: Sijie Guo <si...@apache.org>
Date: 2017-05-26T22:05:43Z
Re-organize the distributedlog modules
- move proxy related class from protocol to proxy-protocol, changed client and service to proxy-client and proxy-service
commit 67e76150b103422f16883857a1c1345cf044fb45
Author: Sijie Guo <si...@apache.org>
Date: 2017-05-27T07:04:40Z
Use integration for exception code rather than thrift generated StatusCode
commit 03b2abd7bb97d4ca996e51329be3fcc485299416
Author: Sijie Guo <si...@apache.org>
Date: 2017-05-30T08:39:19Z
Fix the testcase related to status code change in exceptions
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-distributedlog issue #131: DL-205: Remove StatusCode dependency on...
Posted by sijie <gi...@git.apache.org>.
Github user sijie commented on the issue:
https://github.com/apache/incubator-distributedlog/pull/131
@leighst do you mind reviewing this as well? in this change, I try to separate the protocols used for core from the protocols used by proxy, also rename the modules to make them clear.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-distributedlog issue #131: DL-205: Remove StatusCode dependency on...
Posted by sijie <gi...@git.apache.org>.
Github user sijie commented on the issue:
https://github.com/apache/incubator-distributedlog/pull/131
/cc @leighst @zhaijack @mgodave for reviews
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-distributedlog pull request #131: DL-205: Remove StatusCode depend...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-distributedlog/pull/131
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-distributedlog issue #131: DL-205: Remove StatusCode dependency on...
Posted by leighst <gi...@git.apache.org>.
Github user leighst commented on the issue:
https://github.com/apache/incubator-distributedlog/pull/131
looks good. i guess the choice here is to make it like bk, to some extent.
personally i think having a pojo StatusCode object would be better than passing around ints which can be easily misinterpreted. but i dont have a strong opinion.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---