[jira] Commented: (QPID-930) ruby channel_close test issues

["Rafael H. Schloming (JIRA)" <qp...@incubator.apache.org>]

    [ https://issues.apache.org/jira/browse/QPID-930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12608397#action_12608397 ] 

Rafael H. Schloming commented on QPID-930:
------------------------------------------

I think it's fair to say that we should use logging instead of writing directly to the console. We could keep this JIRA open till we do the next round of ruby work, or file a new one specifically for replacing console output with logging.

> ruby channel_close test issues
> ------------------------------
>
>                 Key: QPID-930
>                 URL: https://issues.apache.org/jira/browse/QPID-930
>             Project: Qpid
>          Issue Type: Bug
>          Components: Ruby Client
>    Affects Versions: M1, M2, M2.1, M3
>            Reporter: Gordon Sim
>            Assignee: Rafael H. Schloming
>            Priority: Minor
>
> There are a couple of issues when running the channel_close test for the ruby client against either java or c++ brokers. (I believe this tests that attempts to close an unopened channel are handled correctly).
> Against the java broker thonly issue is that extra text gets printed out that calls into question the success of the test (though it s not reported as an error or failure, so it may just be extra verbose logging):
> test_channel_close(Channel): CONNECTION CLOSED: 504, Trying to close unknown channel [error code 504: channel error], 20, 40
> writer Qpid::Closed
> .worker Qpid::Closed
> Against the c++ broker the test doesn't complete. The broker does send the expected connection close. However it doesn't wait for a close-ok which may be the issue (in which case this is also a broker bug, but the client should be able to continue and log a warning or something).
> test_channel_close(Channel): Codec::EOF
>   ./qpid/codec.rb:239:in `read'
>   ./qpid/codec.rb:247:in `unpack'
>   ./qpid/codec.rb:186:in `octet'
>   ./qpid/connection.rb:59:in `read'
>   ./qpid/peer.rb:90:in `reader'
>   ./qpid/peer.rb:74:in `spawn'
>   ./qpid/peer.rb:72:in `spawn'
>   ./qpid/peer.rb:55:in `start'
>   ./qpid/client.rb:83:in `start'
>   ./qpid/test.rb:32:in `connect'
>   ./tests/channel.rb:38:in `test_channel_close'
>   /usr/lib/ruby/1.8/test/unit/testcase.rb:70:in `run'
>   /usr/lib/ruby/1.8/test/unit/testsuite.rb:32:in `run'
>   /usr/lib/ruby/1.8/test/unit/testsuite.rb:31:in `run'
>   /usr/lib/ruby/1.8/test/unit/testsuite.rb:32:in `run'
>   /usr/lib/ruby/1.8/test/unit/testsuite.rb:31:in `run'
>   /usr/lib/ruby/1.8/test/unit/ui/testrunnermediator.rb:44:in `run_suite'
>   /usr/lib/ruby/1.8/test/unit/ui/console/testrunner.rb:65:in `start_mediator'
>   /usr/lib/ruby/1.8/test/unit/ui/console/testrunner.rb:39:in `start'
>   /usr/lib/ruby/1.8/test/unit/ui/testrunnerutilities.rb:27:in `run'
>   /usr/lib/ruby/1.8/test/unit/autorunner.rb:200:in `run'
>   /usr/lib/ruby/1.8/test/unit/autorunner.rb:13:in `run'
>   /usr/lib/ruby/1.8/test/unit.rb:285
>   ./run-tests:4

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.