You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/10/18 00:34:28 UTC

[GitHub] [spark] HyukjinKwon commented on a diff in pull request #38279: [SPARK-40816][CONNECT][PYTHON] Rename LogicalPlan.collect to LogicalPlan.to_proto

HyukjinKwon commented on code in PR #38279:
URL: https://github.com/apache/spark/pull/38279#discussion_r997615233


##########
python/pyspark/sql/connect/plan.py:
##########
@@ -80,9 +80,19 @@ def _verify(self, session: "RemoteSparkSession") -> bool:
 
         return test_plan == plan
 
-    def collect(

Review Comment:
   Let's problably fix the error here together.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org