[GitHub] johnyangk commented on a change in pull request #151: [NEMO-267] Consider watermark holds in GroupByKeyAndWindowDoFnTransform

[GitBox <gi...@apache.org>]

johnyangk commented on a change in pull request #151: [NEMO-267] Consider watermark holds in GroupByKeyAndWindowDoFnTransform
URL: https://github.com/apache/incubator-nemo/pull/151#discussion_r231353975
 
 

 ##########
 File path: compiler/test/src/test/java/org/apache/nemo/compiler/frontend/beam/transform/GroupByKeyAndWindowDoFnTransformTest.java
 ##########
 @@ -57,13 +56,19 @@ private void checkOutput(final KV<String, List<String>> expected, final KV<Strin
     final List<String> expectedValue = new ArrayList<>(expected.getValue());
     result.getValue().iterator().forEachRemaining(resultValue::add);
     Collections.sort(resultValue);
+    Collections.sort(expectedValue);
 
     assertEquals(expectedValue, resultValue);
   }
 
 
-  // [---- window1 --------]         [--------------- window2 ---------------]
-  // ts1 -- ts2 -- ts3 -- watermark -- ts4 -- watermark2 -- ts5 --ts6 --ts7 -- watermark7
 
 Review comment:
   Can we keep the existing test (fixed window), and introduce the new test (sliding window) as a separate one?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services