You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2021/03/31 04:34:44 UTC

[GitHub] [iotdb] icloudsong commented on a change in pull request #2935: [IOTDB-1259] upgrade libthrift from 0.12.0/0.13.0 to 0.14.1 and updated related c…

icloudsong commented on a change in pull request #2935:
URL: https://github.com/apache/iotdb/pull/2935#discussion_r604586977



##########
File path: cluster/src/main/java/org/apache/iotdb/cluster/client/sync/SyncDataClient.java
##########
@@ -56,9 +55,9 @@ public SyncDataClient(TProtocolFactory protocolFactory, Node node, SyncClientPoo
         protocolFactory.getProtocol(
             RpcTransportFactory.INSTANCE.getTransport(
                 new TSocket(
-                    node.getInternalIp(),
-                    node.getDataPort(),
-                    RaftServer.getConnectionTimeoutInMS()))));
+                    node.getInternalIp(), node.getDataPort() // ,
+                    //                    RaftServer.getConnectionTimeoutInMS()

Review comment:
       > if this parameter does not use, could remove... Try not to comment
   
   yes, It‘s just a temp step in order to run quickly, need to be improved next according to the detail spec.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org