You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/10/12 04:18:57 UTC
[GitHub] [doris] englefly opened a new pull request, #13311: add string min/maxValue
englefly opened a new pull request, #13311:
URL: https://github.com/apache/doris/pull/13311
# Proposed changes
enable varchar/char type set min/max value
table first 8 chars as long, and convert to double
@Kikyou1997 @jackwener please review
Issue Number: close #xxx
## Problem summary
Describe your changes.
## Checklist(Required)
1. Does it affect the original behavior:
- [ ] Yes
- [ ] No
- [ ] I don't know
2. Has unit tests been added:
- [ ] Yes
- [ ] No
- [ ] No Need
3. Has document been added or modified:
- [ ] Yes
- [ ] No
- [ ] No Need
4. Does it need to update dependencies:
- [ ] Yes
- [ ] No
5. Are there any changes that cannot be rolled back:
- [ ] Yes (If Yes, please explain WHY)
- [ ] No
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #13311: [feature](nereids) add stats min/maxValue support for Date/CHAR/VARCHAR
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13311:
URL: https://github.com/apache/doris/pull/13311#issuecomment-1277057645
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Kikyou1997 commented on a diff in pull request #13311: [feature](nereids) add stats min/maxValue support for Date/CHAR/VARCHAR
Posted by GitBox <gi...@apache.org>.
Kikyou1997 commented on code in PR #13311:
URL: https://github.com/apache/doris/pull/13311#discussion_r993070844
##########
fe/fe-core/src/main/java/org/apache/doris/statistics/ColumnStat.java:
##########
@@ -285,6 +285,17 @@ private double convertToDouble(Type type, String columnValue) throws AnalysisExc
}
+ private double convertStringToDouble(String s) {
Review Comment:
I suggest that override `getLongValue` in StringLiteral, and move those logic to the overided method
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #13311: [feature](nereids) add stats min/maxValue support for Date/CHAR/VARCHAR
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13311:
URL: https://github.com/apache/doris/pull/13311#issuecomment-1275819813
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] englefly commented on a diff in pull request #13311: [feature](nereids) add stats min/maxValue support for Date/CHAR/VARCHAR
Posted by GitBox <gi...@apache.org>.
englefly commented on code in PR #13311:
URL: https://github.com/apache/doris/pull/13311#discussion_r993074892
##########
fe/fe-core/src/main/java/org/apache/doris/statistics/ColumnStat.java:
##########
@@ -285,6 +285,17 @@ private double convertToDouble(Type type, String columnValue) throws AnalysisExc
}
+ private double convertStringToDouble(String s) {
Review Comment:
Good idea. But this should be done in readableValue().
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] englefly commented on a diff in pull request #13311: [feature](nereids) add stats min/maxValue support for Date/CHAR/VARCHAR
Posted by GitBox <gi...@apache.org>.
englefly commented on code in PR #13311:
URL: https://github.com/apache/doris/pull/13311#discussion_r993074892
##########
fe/fe-core/src/main/java/org/apache/doris/statistics/ColumnStat.java:
##########
@@ -285,6 +285,17 @@ private double convertToDouble(Type type, String columnValue) throws AnalysisExc
}
+ private double convertStringToDouble(String s) {
Review Comment:
good idea
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morrySnow merged pull request #13311: [feature](nereids) add stats min/maxValue support for Date/CHAR/VARCHAR
Posted by GitBox <gi...@apache.org>.
morrySnow merged PR #13311:
URL: https://github.com/apache/doris/pull/13311
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org