You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tapestry.apache.org by "Brian K. Wallace" <br...@transmorphix.com> on 2006/03/08 08:03:04 UTC
Jira-193 patches submitted
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Patches submitted against the 3.0 branch and trunk.
The patch against the branch resolves the issue entirely - allowing
(fringe case) a non-extensioned asset with localization as well as
providing proper exception reporting if/when locating the resource
fails. No tests were written as, quite honestly, I couldn't find out where.
The patch against trunk simply adds a check in the lastIndexOf as it is
assumed to be > -1 although the results of the check are used differently.
1 down...........
Brian
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.5 (MingW32)
iD8DBQFEDoFVaCoPKRow/gARAjSvAKDt6Fg8ZZMSFv9z55r0gkrutbQW/ACcDyOp
Ox2NJ2JjNdd5FGaJ6xHAO2o=
=l76b
-----END PGP SIGNATURE-----
---------------------------------------------------------------------
To unsubscribe, e-mail: tapestry-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tapestry-dev-help@jakarta.apache.org
Re: Jira-193 patches submitted - Wrong patch applied to trunk? Ignore
Posted by "Brian K. Wallace" <br...@transmorphix.com>.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
My SVN area, not the file. Please ignore.
Brian
Brian K. Wallace wrote:
> I attached two patches to this issue - one for the 3.X branch and one
> for trunk. After updating my trunk code it looks like the 3.X branch
> patch was applied to trunk. [AssetService now has compilation problems]
>
> Patch for trunk still valid.
>
> Brian
>
> Brian K. Wallace wrote:
>>> Patches submitted against the 3.0 branch and trunk.
>>>
>>> The patch against the branch resolves the issue entirely - allowing
>>> (fringe case) a non-extensioned asset with localization as well as
>>> providing proper exception reporting if/when locating the resource
>>> fails. No tests were written as, quite honestly, I couldn't find out where.
>>>
>>> The patch against trunk simply adds a check in the lastIndexOf as it is
>>> assumed to be > -1 although the results of the check are used differently.
>>>
>>> 1 down...........
>>>
>>> Brian
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: tapestry-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: tapestry-dev-help@jakarta.apache.org
>
>
>
>
- ---------------------------------------------------------------------
To unsubscribe, e-mail: tapestry-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tapestry-dev-help@jakarta.apache.org
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.5 (MingW32)
iD8DBQFEFkFZaCoPKRow/gARAiqmAJ9QMtF4rS47zn4+aUYC3qIKgj8PWgCfQtIQ
8eoIrNnCxHnPRSsyIorLo70=
=nMU7
-----END PGP SIGNATURE-----
---------------------------------------------------------------------
To unsubscribe, e-mail: tapestry-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tapestry-dev-help@jakarta.apache.org
Re: Jira-193 patches submitted - Wrong patch applied to trunk?
Posted by "Brian K. Wallace" <br...@transmorphix.com>.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
I attached two patches to this issue - one for the 3.X branch and one
for trunk. After updating my trunk code it looks like the 3.X branch
patch was applied to trunk. [AssetService now has compilation problems]
Patch for trunk still valid.
Brian
Brian K. Wallace wrote:
> Patches submitted against the 3.0 branch and trunk.
>
> The patch against the branch resolves the issue entirely - allowing
> (fringe case) a non-extensioned asset with localization as well as
> providing proper exception reporting if/when locating the resource
> fails. No tests were written as, quite honestly, I couldn't find out where.
>
> The patch against trunk simply adds a check in the lastIndexOf as it is
> assumed to be > -1 although the results of the check are used differently.
>
> 1 down...........
>
> Brian
- ---------------------------------------------------------------------
To unsubscribe, e-mail: tapestry-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tapestry-dev-help@jakarta.apache.org
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.5 (MingW32)
iD8DBQFEFkCQaCoPKRow/gARAqSRAKDhfVO5IsJwqzBgvhPJFhhljSKvbgCgrsbP
KcOC9LltRm9jLUY9Lfv5/i8=
=eSae
-----END PGP SIGNATURE-----
---------------------------------------------------------------------
To unsubscribe, e-mail: tapestry-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tapestry-dev-help@jakarta.apache.org