You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Michael Ho (Code Review)" <ge...@cloudera.org> on 2017/08/31 19:50:53 UTC
[Impala-ASF-CR] CDH-58701: Check for existence of sync file range()
Michael Ho has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7923
Change subject: CDH-58701: Check for existence of sync_file_range()
......................................................................
CDH-58701: Check for existence of sync_file_range()
On some legacy platforms, the system call sync_file_range()
is not defined. Some Kudu code calls it unconditionally
on Linux platforms. Let's check for its existence and use
the workaround already defined for non-Linux platforms.
Testing done: ran packaging build on Centos55. Failed consistently before.
Change-Id: I9e398085ebd00c23fd1f29f9253d9c257e0c5442
---
M be/CMakeLists.txt
M be/src/common/config.h.in
M be/src/kudu/util/env_posix.cc
3 files changed, 4 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/23/7923/1
--
To view, visit http://gerrit.cloudera.org:8080/7923
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9e398085ebd00c23fd1f29f9253d9c257e0c5442
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Michael Ho <kw...@cloudera.com>
[Impala-ASF-CR] IMPALA-5873: Check for existence of sync file range()
Posted by "Michael Ho (Code Review)" <ge...@cloudera.org>.
Hello Henry Robinson,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7923
to look at the new patch set (#2).
Change subject: IMPALA-5873: Check for existence of sync_file_range()
......................................................................
IMPALA-5873: Check for existence of sync_file_range()
On some legacy platforms, the system call sync_file_range()
is not defined. Some Kudu code calls it unconditionally
on Linux platforms. Let's check for its existence and use
the workaround already defined for non-Linux platforms.
Testing done: ran packaging build on Centos55. Failed consistently before.
Change-Id: I9e398085ebd00c23fd1f29f9253d9c257e0c5442
---
M be/CMakeLists.txt
M be/src/common/config.h.in
M be/src/kudu/util/env_posix.cc
3 files changed, 4 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/23/7923/2
--
To view, visit http://gerrit.cloudera.org:8080/7923
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9e398085ebd00c23fd1f29f9253d9c257e0c5442
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
[Impala-ASF-CR] IMPALA-5873: Check for existence of sync file range()
Posted by "Michael Ho (Code Review)" <ge...@cloudera.org>.
Michael Ho has posted comments on this change.
Change subject: IMPALA-5873: Check for existence of sync_file_range()
......................................................................
Patch Set 2: Code-Review+2
Carry +2. Updated the commit message with the upstream JIRA.
--
To view, visit http://gerrit.cloudera.org:8080/7923
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9e398085ebd00c23fd1f29f9253d9c257e0c5442
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5873: Check for existence of sync file range()
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged.
Change subject: IMPALA-5873: Check for existence of sync_file_range()
......................................................................
IMPALA-5873: Check for existence of sync_file_range()
On some legacy platforms, the system call sync_file_range()
is not defined. Some Kudu code calls it unconditionally
on Linux platforms. Let's check for its existence and use
the workaround already defined for non-Linux platforms.
Testing done: ran packaging build on Centos55. Failed consistently before.
Change-Id: I9e398085ebd00c23fd1f29f9253d9c257e0c5442
Reviewed-on: http://gerrit.cloudera.org:8080/7923
Reviewed-by: Michael Ho <kw...@cloudera.com>
Tested-by: Impala Public Jenkins
---
M be/CMakeLists.txt
M be/src/common/config.h.in
M be/src/kudu/util/env_posix.cc
3 files changed, 4 insertions(+), 2 deletions(-)
Approvals:
Impala Public Jenkins: Verified
Michael Ho: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/7923
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9e398085ebd00c23fd1f29f9253d9c257e0c5442
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
[Impala-ASF-CR] CDH-58701: Check for existence of sync file range()
Posted by "Michael Ho (Code Review)" <ge...@cloudera.org>.
Michael Ho has posted comments on this change.
Change subject: CDH-58701: Check for existence of sync_file_range()
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7923/1//COMMIT_MSG
Commit Message:
PS1, Line 7: CDH-58701
Will file an upstream JIRA too. Not sure what I was thinking.
--
To view, visit http://gerrit.cloudera.org:8080/7923
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9e398085ebd00c23fd1f29f9253d9c257e0c5442
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5873: Check for existence of sync file range()
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5873: Check for existence of sync_file_range()
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1186/
--
To view, visit http://gerrit.cloudera.org:8080/7923
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9e398085ebd00c23fd1f29f9253d9c257e0c5442
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5873: Check for existence of sync file range()
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5873: Check for existence of sync_file_range()
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/7923
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9e398085ebd00c23fd1f29f9253d9c257e0c5442
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5873: Check for existence of sync file range()
Posted by "Michael Ho (Code Review)" <ge...@cloudera.org>.
Michael Ho has posted comments on this change.
Change subject: IMPALA-5873: Check for existence of sync_file_range()
......................................................................
Patch Set 2:
Yes, I did Henry. I cannot post the link of the job here though.
--
To view, visit http://gerrit.cloudera.org:8080/7923
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9e398085ebd00c23fd1f29f9253d9c257e0c5442
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] CDH-58701: Check for existence of sync file range()
Posted by "Henry Robinson (Code Review)" <ge...@cloudera.org>.
Henry Robinson has posted comments on this change.
Change subject: CDH-58701: Check for existence of sync_file_range()
......................................................................
Patch Set 1: Code-Review+2
did you manage to build this on Centos or rhel 5.5?
--
To view, visit http://gerrit.cloudera.org:8080/7923
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9e398085ebd00c23fd1f29f9253d9c257e0c5442
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-HasComments: No