You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by "peng.jianhua (JIRA)" <ji...@apache.org> on 2017/10/30 03:32:00 UTC
[jira] [Updated] (RANGER-1863) Optimize the code and keep the code
style consistent, remove the invalid code in the RemoteUnixLoginModule
class
[ https://issues.apache.org/jira/browse/RANGER-1863?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
peng.jianhua updated RANGER-1863:
---------------------------------
Summary: Optimize the code and keep the code style consistent, remove the invalid code in the RemoteUnixLoginModule class (was: Optimize the code and keep the code style consistent, remove the invalid code in the LoginModule class)
> Optimize the code and keep the code style consistent, remove the invalid code in the RemoteUnixLoginModule class
> ----------------------------------------------------------------------------------------------------------------
>
> Key: RANGER-1863
> URL: https://issues.apache.org/jira/browse/RANGER-1863
> Project: Ranger
> Issue Type: Bug
> Components: usersync
> Affects Versions: master
> Reporter: peng.jianhua
> Assignee: peng.jianhua
> Priority: Minor
> Fix For: master
>
>
> Optimize the code and keep the code style consistent, remove the invalid code in the LoginModule class
> 1.Change from "serverCertValidation = (! (certValidationFlag != null && ("false".equalsIgnoreCase(certValidationFlag.trim().toLowerCase()))));"
> to "serverCertValidation = (! (certValidationFlag != null && ("false".equalsIgnoreCase(certValidationFlag.trim().))));"
> 2.Change from "System.err.println("Skipping RemoteLogin - [" + JAAS_ENABLED_PARAM + "] => [" + val + "]");"
> to "log("Skipping RemoteLogin - [" + JAAS_ENABLED_PARAM + "] => [" + val + "]");"
> 3.remove invalid code /*
> Properties config = null;
> String val = (String) options.get(REMOTE_UNIX_AUTHENICATION_CONFIG_FILE_PARAM);
> log("Remote Unix Auth Configuration file [" + val + "]");
> if (val != null) {
> XMLUtils.loadConfig(val, config);
> }
>
> if (config == null) {
> logError("Remote Unix Auth Configuration is being loaded from XML configuration - not Properties");
> config = new Properties();
> config.putAll(options);
> }
>
> */
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)