[GitHub] [ozone] ashishkumar50 commented on a diff in pull request #4901: HDDS-8447. Datanodes should not process container deletes for failed volumes.

["ashishkumar50 (via GitHub)" <gi...@apache.org>]

ashishkumar50 commented on code in PR #4901:
URL: https://github.com/apache/ozone/pull/4901#discussion_r1230460941


##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/keyvalue/KeyValueHandler.java:
##########
@@ -1382,6 +1391,8 @@ private void deleteInternal(Container container, boolean force)
         if (!success) {
           LOG.error("Failed to move container under " +
               hddsVolume.getDeleteServiceDirPath());
+          // Trigger a volume scan as rename failed
+          StorageVolumeUtil.onFailure(container.getContainerData().getVolume());

Review Comment:
   Before this we also check `container.isEmpty()` and `logBlocksIfNonZero(container)` to make sure container is really empty or not, which will throw `IOException` as well if there is problem in volume as we are accessing disk and rocksdb here. So we need to do trigger volume scan at that place too. 
   Also https://github.com/apache/ozone/pull/4655 which will refactor this method and will probably merge in a day, I think we should handle this change on top of that.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org