You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2021/06/25 03:51:41 UTC

[GitHub] [hudi] nsivabalan commented on a change in pull request #2963: [HUDI-1904] Introduce SchemaProviderInterface to make SchemaProvider unified

nsivabalan commented on a change in pull request #2963:
URL: https://github.com/apache/hudi/pull/2963#discussion_r658454888



##########
File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/schema/SchemaProviderInterface.java
##########
@@ -25,12 +25,13 @@
 /**
  * Class to provide schema for reading data and also writing into a Hoodie table.
  */
-public abstract class SchemaProvider implements Serializable {
+public interface SchemaProviderInterface extends Serializable {
 
-  public abstract Schema getSourceSchema();
+  Schema getSourceSchema();

Review comment:
       shouldn't we add 
   @PublicAPIMethod(maturity = ApiMaturityLevel.STABLE)
   also for tagetSchema method as well.
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org