You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2026/02/05 00:35:38 UTC
[kudu-CR] [codegen] fix build on macOS
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/23943
Change subject: [codegen] fix build on macOS
......................................................................
[codegen] fix build on macOS
This addresses linker error on macOS:
void google::MakeCheckOpValueString<std::nullptr_t>(...), referenced from:
... google::MakeCheckOpString<std::nullptr_t, void*>(...) in jit_frame_manager.cc.o
ld: symbol(s) not found for architecture x86_64
This is a follow-up to 0efbebd487e7d0c7f21ab0d5a91e0fa70046af83.
Change-Id: I00743d0a452ab5e33c3441cac4e06ff1bf58b7a6
---
M src/kudu/codegen/jit_frame_manager.cc
1 file changed, 3 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/43/23943/1
--
To view, visit http://gerrit.cloudera.org:8080/23943
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I00743d0a452ab5e33c3441cac4e06ff1bf58b7a6
Gerrit-Change-Number: 23943
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
[kudu-CR] [codegen] fix build on macOS
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23943 )
Change subject: [codegen] fix build on macOS
......................................................................
Patch Set 1:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/2249/
--
To view, visit http://gerrit.cloudera.org:8080/23943
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I00743d0a452ab5e33c3441cac4e06ff1bf58b7a6
Gerrit-Change-Number: 23943
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 05 Feb 2026 00:35:45 +0000
Gerrit-HasComments: No
[kudu-CR] [codegen] fix build on macOS
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23943 )
Change subject: [codegen] fix build on macOS
......................................................................
Patch Set 1: Verified-1
Build Failed
http://jenkins.kudu.apache.org/job/pre_commit/2249/ : FAILURE
--
To view, visit http://gerrit.cloudera.org:8080/23943
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I00743d0a452ab5e33c3441cac4e06ff1bf58b7a6
Gerrit-Change-Number: 23943
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>
Gerrit-Comment-Date: Thu, 05 Feb 2026 01:21:53 +0000
Gerrit-HasComments: No
[kudu-CR] [codegen] fix build on macOS
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.
Change subject: [codegen] fix build on macOS
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/23943
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I00743d0a452ab5e33c3441cac4e06ff1bf58b7a6
Gerrit-Change-Number: 23943
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>
[kudu-CR] [codegen] fix build on macOS
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/23943 )
Change subject: [codegen] fix build on macOS
......................................................................
Patch Set 1: Code-Review+1
Looks good but I want to test this patch in my machine before I give +2
--
To view, visit http://gerrit.cloudera.org:8080/23943
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I00743d0a452ab5e33c3441cac4e06ff1bf58b7a6
Gerrit-Change-Number: 23943
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>
Gerrit-Comment-Date: Thu, 05 Feb 2026 07:02:11 +0000
Gerrit-HasComments: No
[kudu-CR] [codegen] fix build on macOS
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/23943 )
Change subject: [codegen] fix build on macOS
......................................................................
[codegen] fix build on macOS
This addresses linker error on macOS:
void google::MakeCheckOpValueString<std::nullptr_t>(...), referenced from:
... google::MakeCheckOpString<std::nullptr_t, void*>(...) in jit_frame_manager.cc.o
ld: symbol(s) not found for architecture x86_64
This is a follow-up to 0efbebd487e7d0c7f21ab0d5a91e0fa70046af83.
Change-Id: I00743d0a452ab5e33c3441cac4e06ff1bf58b7a6
Reviewed-on: http://gerrit.cloudera.org:8080/23943
Tested-by: Alexey Serbin <al...@apache.org>
Reviewed-by: Abhishek Chennaka <ac...@cloudera.com>
Reviewed-by: Marton Greber <gr...@gmail.com>
Reviewed-by: Zoltan Martonka <zm...@cloudera.com>
Reviewed-by: Zoltan Chovan <zc...@cloudera.com>
---
M src/kudu/codegen/jit_frame_manager.cc
1 file changed, 3 insertions(+), 4 deletions(-)
Approvals:
Alexey Serbin: Verified
Abhishek Chennaka: Looks good to me, but someone else must approve
Marton Greber: Looks good to me, but someone else must approve
Zoltan Martonka: Looks good to me, but someone else must approve
Zoltan Chovan: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/23943
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I00743d0a452ab5e33c3441cac4e06ff1bf58b7a6
Gerrit-Change-Number: 23943
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>
[kudu-CR] [codegen] fix build on macOS
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/23943 )
Change subject: [codegen] fix build on macOS
......................................................................
Patch Set 1: Verified+1
unrelated test failures
--
To view, visit http://gerrit.cloudera.org:8080/23943
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I00743d0a452ab5e33c3441cac4e06ff1bf58b7a6
Gerrit-Change-Number: 23943
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>
Gerrit-Comment-Date: Thu, 05 Feb 2026 05:36:04 +0000
Gerrit-HasComments: No
[kudu-CR] [codegen] fix build on macOS
Posted by "Marton Greber (Code Review)" <ge...@cloudera.org>.
Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/23943 )
Change subject: [codegen] fix build on macOS
......................................................................
Patch Set 1: Code-Review+1
Looks good to me.
I dont have a working macos setup. Once Abhishek can verify it on his setup I'm fine submitting this. (or let me know and I can take some time to setup my macos)
Thanks!
--
To view, visit http://gerrit.cloudera.org:8080/23943
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I00743d0a452ab5e33c3441cac4e06ff1bf58b7a6
Gerrit-Change-Number: 23943
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>
Gerrit-Comment-Date: Thu, 05 Feb 2026 11:00:46 +0000
Gerrit-HasComments: No
[kudu-CR] [codegen] fix build on macOS
Posted by "Zoltan Martonka (Code Review)" <ge...@cloudera.org>.
Zoltan Martonka has posted comments on this change. ( http://gerrit.cloudera.org:8080/23943 )
Change subject: [codegen] fix build on macOS
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/23943
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I00743d0a452ab5e33c3441cac4e06ff1bf58b7a6
Gerrit-Change-Number: 23943
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>
Gerrit-Comment-Date: Thu, 05 Feb 2026 11:08:40 +0000
Gerrit-HasComments: No
[kudu-CR] [codegen] fix build on macOS
Posted by "Zoltan Chovan (Code Review)" <ge...@cloudera.org>.
Zoltan Chovan has posted comments on this change. ( http://gerrit.cloudera.org:8080/23943 )
Change subject: [codegen] fix build on macOS
......................................................................
Patch Set 1: Code-Review+2
I double checked the issue on macOS (15.7.3) and the patch fixed the problem.
--
To view, visit http://gerrit.cloudera.org:8080/23943
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I00743d0a452ab5e33c3441cac4e06ff1bf58b7a6
Gerrit-Change-Number: 23943
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>
Gerrit-Comment-Date: Mon, 09 Feb 2026 13:14:51 +0000
Gerrit-HasComments: No