You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Zsombor Gegesy <gz...@gmail.com> on 2017/02/21 15:49:12 UTC
Review Request 56890: [RANGER-1377] eliminate unnecessary toString
methods, and use String.valueOf properly
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56890/
-----------------------------------------------------------
Review request for ranger.
Bugs: RANGER-1377
https://issues.apache.org/jira/browse/RANGER-1377
Repository: ranger
Description
-------
Calling toString on a String is meaningless, or when it's already added to a string.
Concatenating strings inside a String.append is wasteful, as "" + obj instead of String.valueOf(obj)
Diffs
-----
security-admin/src/main/java/org/apache/ranger/biz/RangerBizUtil.java 5521ae8
security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java 15f205a
security-admin/src/main/java/org/apache/ranger/biz/ServiceMgr.java f512049
security-admin/src/main/java/org/apache/ranger/common/DateUtil.java 7babd80
security-admin/src/main/java/org/apache/ranger/common/PropertiesUtil.java 22d4b89
security-admin/src/main/java/org/apache/ranger/common/RangerSearchUtil.java 4fb52a4
security-admin/src/main/java/org/apache/ranger/common/SearchGroup.java 77119b1
security-admin/src/main/java/org/apache/ranger/common/SearchUtil.java f4fcfb2
security-admin/src/main/java/org/apache/ranger/common/StringUtil.java da7231e
security-admin/src/main/java/org/apache/ranger/db/XXResourceDao.java 9fa77f2
security-admin/src/main/java/org/apache/ranger/entity/XXServiceResource.java 961627a
security-admin/src/main/java/org/apache/ranger/entity/XXServiceResourceElement.java 16dca97
security-admin/src/main/java/org/apache/ranger/entity/XXServiceResourceElementValue.java 82ce8a0
security-admin/src/main/java/org/apache/ranger/entity/XXTag.java 9155385
security-admin/src/main/java/org/apache/ranger/entity/XXTagAttribute.java 1c88288
security-admin/src/main/java/org/apache/ranger/entity/XXTagAttributeDef.java 5c6ff58
security-admin/src/main/java/org/apache/ranger/entity/XXTagDef.java 818908b
security-admin/src/main/java/org/apache/ranger/entity/XXTagResourceMap.java 4b8b3ec
security-admin/src/main/java/org/apache/ranger/patch/PatchTagModulePermission_J10005.java 6f9350d
security-admin/src/main/java/org/apache/ranger/patch/cliutil/DbToSolrMigrationUtil.java 1ddd367
security-admin/src/main/java/org/apache/ranger/rest/PublicAPIs.java d3c22d7
security-admin/src/main/java/org/apache/ranger/security/handler/RangerAuthenticationProvider.java 3fdd5c2
security-admin/src/main/java/org/apache/ranger/security/web/filter/RangerKRBAuthenticationFilter.java c8d22aa
security-admin/src/main/java/org/apache/ranger/security/web/filter/RangerSSOAuthenticationFilter.java 7d8fdb2
security-admin/src/main/java/org/apache/ranger/security/web/filter/RangerUsernamePasswordAuthenticationFilter.java 62e23c0
security-admin/src/main/java/org/apache/ranger/service/AbstractBaseResourceService.java 9a4aa3b
security-admin/src/main/java/org/apache/ranger/service/RangerBaseModelService.java 482f10c
security-admin/src/main/java/org/apache/ranger/service/RangerPolicyService.java 8d9776a
security-admin/src/main/java/org/apache/ranger/service/RangerServiceService.java 004524b
security-admin/src/main/java/org/apache/ranger/service/XAssetService.java 81c720d
security-admin/src/main/java/org/apache/ranger/service/XAuditMapService.java 1dfe19f
security-admin/src/main/java/org/apache/ranger/service/XGroupService.java c478dbc
security-admin/src/main/java/org/apache/ranger/service/XGroupUserService.java 0d735da
security-admin/src/main/java/org/apache/ranger/service/XPermMapService.java bc335cc
security-admin/src/main/java/org/apache/ranger/service/XPolicyService.java f3f7c80
security-admin/src/main/java/org/apache/ranger/service/XPortalUserService.java bb12e3e
security-admin/src/main/java/org/apache/ranger/service/XResourceService.java 817fdda
security-admin/src/main/java/org/apache/ranger/service/XUserService.java 0f8156a
security-admin/src/main/java/org/apache/ranger/solr/SolrAccessAuditsService.java 917c760
security-admin/src/main/java/org/apache/ranger/solr/SolrUtil.java a851c3e
security-admin/src/main/java/org/apache/ranger/view/VXKmsKey.java d7a0b4d
security-admin/src/main/java/org/apache/ranger/view/VXMetricPolicyCount.java bb18775
security-admin/src/test/java/org/apache/ranger/audit/TestAuditQueue.java dee3156
Diff: https://reviews.apache.org/r/56890/diff/
Testing
-------
Thanks,
Zsombor Gegesy
Re: Review Request 56890: [RANGER-1377] eliminate unnecessary toString
methods, and use String.valueOf properly
Posted by Zsombor Gegesy <gz...@gmail.com>.
> On Feb. 22, 2017, 1:23 a.m., Madhan Neethiraj wrote:
> > I would suggest to not update a large number of sources for style compliance or minor improvements. Instead, I would recommend such updates be done when source files are changed to address a bug or enhancement. This would help minimize the chances of a new bug getting introduced in massive updates.
It's much simpler to validate, when the changeset is simple, address one issue only, and doesn't change the logic, as opposed to inter-mixing with other, algorithmic changes. What kind of bug could these changes introduce ? They are either working equivalently as the old code, or reducing the possibility for NPE.
- Zsombor
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56890/#review166286
-----------------------------------------------------------
On Feb. 21, 2017, 3:49 p.m., Zsombor Gegesy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56890/
> -----------------------------------------------------------
>
> (Updated Feb. 21, 2017, 3:49 p.m.)
>
>
> Review request for ranger.
>
>
> Bugs: RANGER-1377
> https://issues.apache.org/jira/browse/RANGER-1377
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Calling toString on a String is meaningless, or when it's already added to a string.
> Concatenating strings inside a String.append is wasteful, as "" + obj instead of String.valueOf(obj)
>
>
> Diffs
> -----
>
> security-admin/src/main/java/org/apache/ranger/biz/RangerBizUtil.java 5521ae8
> security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java 15f205a
> security-admin/src/main/java/org/apache/ranger/biz/ServiceMgr.java f512049
> security-admin/src/main/java/org/apache/ranger/common/DateUtil.java 7babd80
> security-admin/src/main/java/org/apache/ranger/common/PropertiesUtil.java 22d4b89
> security-admin/src/main/java/org/apache/ranger/common/RangerSearchUtil.java 4fb52a4
> security-admin/src/main/java/org/apache/ranger/common/SearchGroup.java 77119b1
> security-admin/src/main/java/org/apache/ranger/common/SearchUtil.java f4fcfb2
> security-admin/src/main/java/org/apache/ranger/common/StringUtil.java da7231e
> security-admin/src/main/java/org/apache/ranger/db/XXResourceDao.java 9fa77f2
> security-admin/src/main/java/org/apache/ranger/entity/XXServiceResource.java 961627a
> security-admin/src/main/java/org/apache/ranger/entity/XXServiceResourceElement.java 16dca97
> security-admin/src/main/java/org/apache/ranger/entity/XXServiceResourceElementValue.java 82ce8a0
> security-admin/src/main/java/org/apache/ranger/entity/XXTag.java 9155385
> security-admin/src/main/java/org/apache/ranger/entity/XXTagAttribute.java 1c88288
> security-admin/src/main/java/org/apache/ranger/entity/XXTagAttributeDef.java 5c6ff58
> security-admin/src/main/java/org/apache/ranger/entity/XXTagDef.java 818908b
> security-admin/src/main/java/org/apache/ranger/entity/XXTagResourceMap.java 4b8b3ec
> security-admin/src/main/java/org/apache/ranger/patch/PatchTagModulePermission_J10005.java 6f9350d
> security-admin/src/main/java/org/apache/ranger/patch/cliutil/DbToSolrMigrationUtil.java 1ddd367
> security-admin/src/main/java/org/apache/ranger/rest/PublicAPIs.java d3c22d7
> security-admin/src/main/java/org/apache/ranger/security/handler/RangerAuthenticationProvider.java 3fdd5c2
> security-admin/src/main/java/org/apache/ranger/security/web/filter/RangerKRBAuthenticationFilter.java c8d22aa
> security-admin/src/main/java/org/apache/ranger/security/web/filter/RangerSSOAuthenticationFilter.java 7d8fdb2
> security-admin/src/main/java/org/apache/ranger/security/web/filter/RangerUsernamePasswordAuthenticationFilter.java 62e23c0
> security-admin/src/main/java/org/apache/ranger/service/AbstractBaseResourceService.java 9a4aa3b
> security-admin/src/main/java/org/apache/ranger/service/RangerBaseModelService.java 482f10c
> security-admin/src/main/java/org/apache/ranger/service/RangerPolicyService.java 8d9776a
> security-admin/src/main/java/org/apache/ranger/service/RangerServiceService.java 004524b
> security-admin/src/main/java/org/apache/ranger/service/XAssetService.java 81c720d
> security-admin/src/main/java/org/apache/ranger/service/XAuditMapService.java 1dfe19f
> security-admin/src/main/java/org/apache/ranger/service/XGroupService.java c478dbc
> security-admin/src/main/java/org/apache/ranger/service/XGroupUserService.java 0d735da
> security-admin/src/main/java/org/apache/ranger/service/XPermMapService.java bc335cc
> security-admin/src/main/java/org/apache/ranger/service/XPolicyService.java f3f7c80
> security-admin/src/main/java/org/apache/ranger/service/XPortalUserService.java bb12e3e
> security-admin/src/main/java/org/apache/ranger/service/XResourceService.java 817fdda
> security-admin/src/main/java/org/apache/ranger/service/XUserService.java 0f8156a
> security-admin/src/main/java/org/apache/ranger/solr/SolrAccessAuditsService.java 917c760
> security-admin/src/main/java/org/apache/ranger/solr/SolrUtil.java a851c3e
> security-admin/src/main/java/org/apache/ranger/view/VXKmsKey.java d7a0b4d
> security-admin/src/main/java/org/apache/ranger/view/VXMetricPolicyCount.java bb18775
> security-admin/src/test/java/org/apache/ranger/audit/TestAuditQueue.java dee3156
>
> Diff: https://reviews.apache.org/r/56890/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Zsombor Gegesy
>
>
Re: Review Request 56890: [RANGER-1377] eliminate unnecessary toString
methods, and use String.valueOf properly
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56890/#review166286
-----------------------------------------------------------
I would suggest to not update a large number of sources for style compliance or minor improvements. Instead, I would recommend such updates be done when source files are changed to address a bug or enhancement. This would help minimize the chances of a new bug getting introduced in massive updates.
- Madhan Neethiraj
On Feb. 21, 2017, 3:49 p.m., Zsombor Gegesy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56890/
> -----------------------------------------------------------
>
> (Updated Feb. 21, 2017, 3:49 p.m.)
>
>
> Review request for ranger.
>
>
> Bugs: RANGER-1377
> https://issues.apache.org/jira/browse/RANGER-1377
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Calling toString on a String is meaningless, or when it's already added to a string.
> Concatenating strings inside a String.append is wasteful, as "" + obj instead of String.valueOf(obj)
>
>
> Diffs
> -----
>
> security-admin/src/main/java/org/apache/ranger/biz/RangerBizUtil.java 5521ae8
> security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java 15f205a
> security-admin/src/main/java/org/apache/ranger/biz/ServiceMgr.java f512049
> security-admin/src/main/java/org/apache/ranger/common/DateUtil.java 7babd80
> security-admin/src/main/java/org/apache/ranger/common/PropertiesUtil.java 22d4b89
> security-admin/src/main/java/org/apache/ranger/common/RangerSearchUtil.java 4fb52a4
> security-admin/src/main/java/org/apache/ranger/common/SearchGroup.java 77119b1
> security-admin/src/main/java/org/apache/ranger/common/SearchUtil.java f4fcfb2
> security-admin/src/main/java/org/apache/ranger/common/StringUtil.java da7231e
> security-admin/src/main/java/org/apache/ranger/db/XXResourceDao.java 9fa77f2
> security-admin/src/main/java/org/apache/ranger/entity/XXServiceResource.java 961627a
> security-admin/src/main/java/org/apache/ranger/entity/XXServiceResourceElement.java 16dca97
> security-admin/src/main/java/org/apache/ranger/entity/XXServiceResourceElementValue.java 82ce8a0
> security-admin/src/main/java/org/apache/ranger/entity/XXTag.java 9155385
> security-admin/src/main/java/org/apache/ranger/entity/XXTagAttribute.java 1c88288
> security-admin/src/main/java/org/apache/ranger/entity/XXTagAttributeDef.java 5c6ff58
> security-admin/src/main/java/org/apache/ranger/entity/XXTagDef.java 818908b
> security-admin/src/main/java/org/apache/ranger/entity/XXTagResourceMap.java 4b8b3ec
> security-admin/src/main/java/org/apache/ranger/patch/PatchTagModulePermission_J10005.java 6f9350d
> security-admin/src/main/java/org/apache/ranger/patch/cliutil/DbToSolrMigrationUtil.java 1ddd367
> security-admin/src/main/java/org/apache/ranger/rest/PublicAPIs.java d3c22d7
> security-admin/src/main/java/org/apache/ranger/security/handler/RangerAuthenticationProvider.java 3fdd5c2
> security-admin/src/main/java/org/apache/ranger/security/web/filter/RangerKRBAuthenticationFilter.java c8d22aa
> security-admin/src/main/java/org/apache/ranger/security/web/filter/RangerSSOAuthenticationFilter.java 7d8fdb2
> security-admin/src/main/java/org/apache/ranger/security/web/filter/RangerUsernamePasswordAuthenticationFilter.java 62e23c0
> security-admin/src/main/java/org/apache/ranger/service/AbstractBaseResourceService.java 9a4aa3b
> security-admin/src/main/java/org/apache/ranger/service/RangerBaseModelService.java 482f10c
> security-admin/src/main/java/org/apache/ranger/service/RangerPolicyService.java 8d9776a
> security-admin/src/main/java/org/apache/ranger/service/RangerServiceService.java 004524b
> security-admin/src/main/java/org/apache/ranger/service/XAssetService.java 81c720d
> security-admin/src/main/java/org/apache/ranger/service/XAuditMapService.java 1dfe19f
> security-admin/src/main/java/org/apache/ranger/service/XGroupService.java c478dbc
> security-admin/src/main/java/org/apache/ranger/service/XGroupUserService.java 0d735da
> security-admin/src/main/java/org/apache/ranger/service/XPermMapService.java bc335cc
> security-admin/src/main/java/org/apache/ranger/service/XPolicyService.java f3f7c80
> security-admin/src/main/java/org/apache/ranger/service/XPortalUserService.java bb12e3e
> security-admin/src/main/java/org/apache/ranger/service/XResourceService.java 817fdda
> security-admin/src/main/java/org/apache/ranger/service/XUserService.java 0f8156a
> security-admin/src/main/java/org/apache/ranger/solr/SolrAccessAuditsService.java 917c760
> security-admin/src/main/java/org/apache/ranger/solr/SolrUtil.java a851c3e
> security-admin/src/main/java/org/apache/ranger/view/VXKmsKey.java d7a0b4d
> security-admin/src/main/java/org/apache/ranger/view/VXMetricPolicyCount.java bb18775
> security-admin/src/test/java/org/apache/ranger/audit/TestAuditQueue.java dee3156
>
> Diff: https://reviews.apache.org/r/56890/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Zsombor Gegesy
>
>
Re: Review Request 56890: [RANGER-1377] eliminate unnecessary toString
methods, and use String.valueOf properly
Posted by Colm O hEigeartaigh <co...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56890/#review171137
-----------------------------------------------------------
Ship it!
Ship It!
- Colm O hEigeartaigh
On Feb. 21, 2017, 3:49 p.m., Zsombor Gegesy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56890/
> -----------------------------------------------------------
>
> (Updated Feb. 21, 2017, 3:49 p.m.)
>
>
> Review request for ranger.
>
>
> Bugs: RANGER-1377
> https://issues.apache.org/jira/browse/RANGER-1377
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Calling toString on a String is meaningless, or when it's already added to a string.
> Concatenating strings inside a String.append is wasteful, as "" + obj instead of String.valueOf(obj)
>
>
> Diffs
> -----
>
> security-admin/src/main/java/org/apache/ranger/biz/RangerBizUtil.java 5521ae8
> security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java 15f205a
> security-admin/src/main/java/org/apache/ranger/biz/ServiceMgr.java f512049
> security-admin/src/main/java/org/apache/ranger/common/DateUtil.java 7babd80
> security-admin/src/main/java/org/apache/ranger/common/PropertiesUtil.java 22d4b89
> security-admin/src/main/java/org/apache/ranger/common/RangerSearchUtil.java 4fb52a4
> security-admin/src/main/java/org/apache/ranger/common/SearchGroup.java 77119b1
> security-admin/src/main/java/org/apache/ranger/common/SearchUtil.java f4fcfb2
> security-admin/src/main/java/org/apache/ranger/common/StringUtil.java da7231e
> security-admin/src/main/java/org/apache/ranger/db/XXResourceDao.java 9fa77f2
> security-admin/src/main/java/org/apache/ranger/entity/XXServiceResource.java 961627a
> security-admin/src/main/java/org/apache/ranger/entity/XXServiceResourceElement.java 16dca97
> security-admin/src/main/java/org/apache/ranger/entity/XXServiceResourceElementValue.java 82ce8a0
> security-admin/src/main/java/org/apache/ranger/entity/XXTag.java 9155385
> security-admin/src/main/java/org/apache/ranger/entity/XXTagAttribute.java 1c88288
> security-admin/src/main/java/org/apache/ranger/entity/XXTagAttributeDef.java 5c6ff58
> security-admin/src/main/java/org/apache/ranger/entity/XXTagDef.java 818908b
> security-admin/src/main/java/org/apache/ranger/entity/XXTagResourceMap.java 4b8b3ec
> security-admin/src/main/java/org/apache/ranger/patch/PatchTagModulePermission_J10005.java 6f9350d
> security-admin/src/main/java/org/apache/ranger/patch/cliutil/DbToSolrMigrationUtil.java 1ddd367
> security-admin/src/main/java/org/apache/ranger/rest/PublicAPIs.java d3c22d7
> security-admin/src/main/java/org/apache/ranger/security/handler/RangerAuthenticationProvider.java 3fdd5c2
> security-admin/src/main/java/org/apache/ranger/security/web/filter/RangerKRBAuthenticationFilter.java c8d22aa
> security-admin/src/main/java/org/apache/ranger/security/web/filter/RangerSSOAuthenticationFilter.java 7d8fdb2
> security-admin/src/main/java/org/apache/ranger/security/web/filter/RangerUsernamePasswordAuthenticationFilter.java 62e23c0
> security-admin/src/main/java/org/apache/ranger/service/AbstractBaseResourceService.java 9a4aa3b
> security-admin/src/main/java/org/apache/ranger/service/RangerBaseModelService.java 482f10c
> security-admin/src/main/java/org/apache/ranger/service/RangerPolicyService.java 8d9776a
> security-admin/src/main/java/org/apache/ranger/service/RangerServiceService.java 004524b
> security-admin/src/main/java/org/apache/ranger/service/XAssetService.java 81c720d
> security-admin/src/main/java/org/apache/ranger/service/XAuditMapService.java 1dfe19f
> security-admin/src/main/java/org/apache/ranger/service/XGroupService.java c478dbc
> security-admin/src/main/java/org/apache/ranger/service/XGroupUserService.java 0d735da
> security-admin/src/main/java/org/apache/ranger/service/XPermMapService.java bc335cc
> security-admin/src/main/java/org/apache/ranger/service/XPolicyService.java f3f7c80
> security-admin/src/main/java/org/apache/ranger/service/XPortalUserService.java bb12e3e
> security-admin/src/main/java/org/apache/ranger/service/XResourceService.java 817fdda
> security-admin/src/main/java/org/apache/ranger/service/XUserService.java 0f8156a
> security-admin/src/main/java/org/apache/ranger/solr/SolrAccessAuditsService.java 917c760
> security-admin/src/main/java/org/apache/ranger/solr/SolrUtil.java a851c3e
> security-admin/src/main/java/org/apache/ranger/view/VXKmsKey.java d7a0b4d
> security-admin/src/main/java/org/apache/ranger/view/VXMetricPolicyCount.java bb18775
> security-admin/src/test/java/org/apache/ranger/audit/TestAuditQueue.java dee3156
>
>
> Diff: https://reviews.apache.org/r/56890/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Zsombor Gegesy
>
>
Re: Review Request 56890: [RANGER-1377] eliminate unnecessary toString
methods, and use String.valueOf properly
Posted by Colm O hEigeartaigh <co...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56890/#review170416
-----------------------------------------------------------
I would suggest just leaving the ".toString()" changes as they are. However the String.valueOf changes as well as the changes to use StringBuilder.append() instead of String concatenation are valuable. Could you resubmit a working patch with just the latter two changes?
- Colm O hEigeartaigh
On Feb. 21, 2017, 3:49 p.m., Zsombor Gegesy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56890/
> -----------------------------------------------------------
>
> (Updated Feb. 21, 2017, 3:49 p.m.)
>
>
> Review request for ranger.
>
>
> Bugs: RANGER-1377
> https://issues.apache.org/jira/browse/RANGER-1377
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Calling toString on a String is meaningless, or when it's already added to a string.
> Concatenating strings inside a String.append is wasteful, as "" + obj instead of String.valueOf(obj)
>
>
> Diffs
> -----
>
> security-admin/src/main/java/org/apache/ranger/biz/RangerBizUtil.java 5521ae8
> security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java 15f205a
> security-admin/src/main/java/org/apache/ranger/biz/ServiceMgr.java f512049
> security-admin/src/main/java/org/apache/ranger/common/DateUtil.java 7babd80
> security-admin/src/main/java/org/apache/ranger/common/PropertiesUtil.java 22d4b89
> security-admin/src/main/java/org/apache/ranger/common/RangerSearchUtil.java 4fb52a4
> security-admin/src/main/java/org/apache/ranger/common/SearchGroup.java 77119b1
> security-admin/src/main/java/org/apache/ranger/common/SearchUtil.java f4fcfb2
> security-admin/src/main/java/org/apache/ranger/common/StringUtil.java da7231e
> security-admin/src/main/java/org/apache/ranger/db/XXResourceDao.java 9fa77f2
> security-admin/src/main/java/org/apache/ranger/entity/XXServiceResource.java 961627a
> security-admin/src/main/java/org/apache/ranger/entity/XXServiceResourceElement.java 16dca97
> security-admin/src/main/java/org/apache/ranger/entity/XXServiceResourceElementValue.java 82ce8a0
> security-admin/src/main/java/org/apache/ranger/entity/XXTag.java 9155385
> security-admin/src/main/java/org/apache/ranger/entity/XXTagAttribute.java 1c88288
> security-admin/src/main/java/org/apache/ranger/entity/XXTagAttributeDef.java 5c6ff58
> security-admin/src/main/java/org/apache/ranger/entity/XXTagDef.java 818908b
> security-admin/src/main/java/org/apache/ranger/entity/XXTagResourceMap.java 4b8b3ec
> security-admin/src/main/java/org/apache/ranger/patch/PatchTagModulePermission_J10005.java 6f9350d
> security-admin/src/main/java/org/apache/ranger/patch/cliutil/DbToSolrMigrationUtil.java 1ddd367
> security-admin/src/main/java/org/apache/ranger/rest/PublicAPIs.java d3c22d7
> security-admin/src/main/java/org/apache/ranger/security/handler/RangerAuthenticationProvider.java 3fdd5c2
> security-admin/src/main/java/org/apache/ranger/security/web/filter/RangerKRBAuthenticationFilter.java c8d22aa
> security-admin/src/main/java/org/apache/ranger/security/web/filter/RangerSSOAuthenticationFilter.java 7d8fdb2
> security-admin/src/main/java/org/apache/ranger/security/web/filter/RangerUsernamePasswordAuthenticationFilter.java 62e23c0
> security-admin/src/main/java/org/apache/ranger/service/AbstractBaseResourceService.java 9a4aa3b
> security-admin/src/main/java/org/apache/ranger/service/RangerBaseModelService.java 482f10c
> security-admin/src/main/java/org/apache/ranger/service/RangerPolicyService.java 8d9776a
> security-admin/src/main/java/org/apache/ranger/service/RangerServiceService.java 004524b
> security-admin/src/main/java/org/apache/ranger/service/XAssetService.java 81c720d
> security-admin/src/main/java/org/apache/ranger/service/XAuditMapService.java 1dfe19f
> security-admin/src/main/java/org/apache/ranger/service/XGroupService.java c478dbc
> security-admin/src/main/java/org/apache/ranger/service/XGroupUserService.java 0d735da
> security-admin/src/main/java/org/apache/ranger/service/XPermMapService.java bc335cc
> security-admin/src/main/java/org/apache/ranger/service/XPolicyService.java f3f7c80
> security-admin/src/main/java/org/apache/ranger/service/XPortalUserService.java bb12e3e
> security-admin/src/main/java/org/apache/ranger/service/XResourceService.java 817fdda
> security-admin/src/main/java/org/apache/ranger/service/XUserService.java 0f8156a
> security-admin/src/main/java/org/apache/ranger/solr/SolrAccessAuditsService.java 917c760
> security-admin/src/main/java/org/apache/ranger/solr/SolrUtil.java a851c3e
> security-admin/src/main/java/org/apache/ranger/view/VXKmsKey.java d7a0b4d
> security-admin/src/main/java/org/apache/ranger/view/VXMetricPolicyCount.java bb18775
> security-admin/src/test/java/org/apache/ranger/audit/TestAuditQueue.java dee3156
>
>
> Diff: https://reviews.apache.org/r/56890/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Zsombor Gegesy
>
>