You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nifi.apache.org by ij...@apache.org on 2019/07/16 04:43:58 UTC

[nifi] branch master updated: NIFI-6432 Updating get, containsKey, and remove in HBase_1_1_2_ClientMapCacheService and HBase_2_ClientMapCacheService so that they use the column family and qualifier specified in the service

This is an automated email from the ASF dual-hosted git repository.

ijokarumawak pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/nifi.git


The following commit(s) were added to refs/heads/master by this push:
     new f2db153  NIFI-6432 Updating get, containsKey, and remove in HBase_1_1_2_ClientMapCacheService and HBase_2_ClientMapCacheService so that they use the column family and qualifier specified in the service
f2db153 is described below

commit f2db1539a84c4e265edc9ad0c403fe61e7c57c6c
Author: Bryan Bende <bb...@apache.org>
AuthorDate: Thu Jul 11 14:31:13 2019 -0400

    NIFI-6432 Updating get, containsKey, and remove in HBase_1_1_2_ClientMapCacheService and HBase_2_ClientMapCacheService so that they use the column family and qualifier specified in the service
    
    This closes #3581.
    
    Signed-off-by: Koji Kawamura <ij...@apache.org>
---
 .../hbase/HBase_1_1_2_ClientMapCacheService.java   | 32 +++++++++++-----------
 .../nifi/hbase/HBase_2_ClientMapCacheService.java  | 32 +++++++++++-----------
 2 files changed, 32 insertions(+), 32 deletions(-)

diff --git a/nifi-nar-bundles/nifi-standard-services/nifi-hbase_1_1_2-client-service-bundle/nifi-hbase_1_1_2-client-service/src/main/java/org/apache/nifi/hbase/HBase_1_1_2_ClientMapCacheService.java b/nifi-nar-bundles/nifi-standard-services/nifi-hbase_1_1_2-client-service-bundle/nifi-hbase_1_1_2-client-service/src/main/java/org/apache/nifi/hbase/HBase_1_1_2_ClientMapCacheService.java
index 0690db6..d2dc155 100755
--- a/nifi-nar-bundles/nifi-standard-services/nifi-hbase_1_1_2-client-service-bundle/nifi-hbase_1_1_2-client-service/src/main/java/org/apache/nifi/hbase/HBase_1_1_2_ClientMapCacheService.java
+++ b/nifi-nar-bundles/nifi-standard-services/nifi-hbase_1_1_2-client-service-bundle/nifi-hbase_1_1_2-client-service/src/main/java/org/apache/nifi/hbase/HBase_1_1_2_ClientMapCacheService.java
@@ -16,12 +16,6 @@
  */
 package org.apache.nifi.hbase;
 
-import java.io.ByteArrayOutputStream;
-import java.io.IOException;
-import java.util.ArrayList;
-import java.util.Arrays;
-import java.util.List;
-
 import org.apache.nifi.annotation.documentation.CapabilityDescription;
 import org.apache.nifi.annotation.documentation.SeeAlso;
 import org.apache.nifi.annotation.documentation.Tags;
@@ -29,22 +23,25 @@ import org.apache.nifi.annotation.lifecycle.OnEnabled;
 import org.apache.nifi.components.PropertyDescriptor;
 import org.apache.nifi.controller.AbstractControllerService;
 import org.apache.nifi.controller.ConfigurationContext;
-
 import org.apache.nifi.distributed.cache.client.AtomicCacheEntry;
 import org.apache.nifi.distributed.cache.client.AtomicDistributedMapCacheClient;
+import org.apache.nifi.distributed.cache.client.Deserializer;
 import org.apache.nifi.distributed.cache.client.Serializer;
 import org.apache.nifi.expression.ExpressionLanguageScope;
-import org.apache.nifi.distributed.cache.client.Deserializer;
-import org.apache.nifi.reporting.InitializationException;
-
-import java.nio.charset.StandardCharsets;
+import org.apache.nifi.hbase.put.PutColumn;
+import org.apache.nifi.hbase.scan.Column;
 import org.apache.nifi.hbase.scan.ResultCell;
 import org.apache.nifi.hbase.scan.ResultHandler;
-import org.apache.nifi.hbase.scan.Column;
-import org.apache.nifi.hbase.put.PutColumn;
-
-
 import org.apache.nifi.processor.util.StandardValidators;
+import org.apache.nifi.reporting.InitializationException;
+
+import java.io.ByteArrayOutputStream;
+import java.io.IOException;
+import java.nio.charset.StandardCharsets;
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.Collections;
+import java.util.List;
 
 import static org.apache.nifi.hbase.VisibilityLabelUtils.AUTHORIZATIONS;
 
@@ -164,6 +161,7 @@ public class HBase_1_1_2_ClientMapCacheService extends AbstractControllerService
       final HBaseRowHandler handler = new HBaseRowHandler();
 
       final List<Column> columnsList = new ArrayList<Column>(0);
+      columnsList.add(new Column(hBaseColumnFamilyBytes, hBaseColumnQualifierBytes));
 
       hBaseClientService.scan(hBaseCacheTableName, rowIdBytes, rowIdBytes, columnsList, authorizations, handler);
       return (handler.numRows() > 0);
@@ -196,6 +194,7 @@ public class HBase_1_1_2_ClientMapCacheService extends AbstractControllerService
       final HBaseRowHandler handler = new HBaseRowHandler();
 
       final List<Column> columnsList = new ArrayList<Column>(0);
+      columnsList.add(new Column(hBaseColumnFamilyBytes, hBaseColumnQualifierBytes));
 
       hBaseClientService.scan(hBaseCacheTableName, rowIdBytes, rowIdBytes, columnsList, authorizations, handler);
       if (handler.numRows() > 1) {
@@ -212,7 +211,8 @@ public class HBase_1_1_2_ClientMapCacheService extends AbstractControllerService
         final boolean contains = containsKey(key, keySerializer);
         if (contains) {
             final byte[] rowIdBytes = serialize(key, keySerializer);
-            hBaseClientService.delete(hBaseCacheTableName, rowIdBytes);
+            final DeleteRequest deleteRequest = new DeleteRequest(rowIdBytes, hBaseColumnFamilyBytes, hBaseColumnQualifierBytes, null);
+            hBaseClientService.deleteCells(hBaseCacheTableName, Collections.singletonList(deleteRequest));
         }
         return contains;
     }
diff --git a/nifi-nar-bundles/nifi-standard-services/nifi-hbase_2-client-service-bundle/nifi-hbase_2-client-service/src/main/java/org/apache/nifi/hbase/HBase_2_ClientMapCacheService.java b/nifi-nar-bundles/nifi-standard-services/nifi-hbase_2-client-service-bundle/nifi-hbase_2-client-service/src/main/java/org/apache/nifi/hbase/HBase_2_ClientMapCacheService.java
index cd3b684..8744276 100755
--- a/nifi-nar-bundles/nifi-standard-services/nifi-hbase_2-client-service-bundle/nifi-hbase_2-client-service/src/main/java/org/apache/nifi/hbase/HBase_2_ClientMapCacheService.java
+++ b/nifi-nar-bundles/nifi-standard-services/nifi-hbase_2-client-service-bundle/nifi-hbase_2-client-service/src/main/java/org/apache/nifi/hbase/HBase_2_ClientMapCacheService.java
@@ -16,12 +16,6 @@
  */
 package org.apache.nifi.hbase;
 
-import java.io.ByteArrayOutputStream;
-import java.io.IOException;
-import java.util.ArrayList;
-import java.util.Arrays;
-import java.util.List;
-
 import org.apache.nifi.annotation.documentation.CapabilityDescription;
 import org.apache.nifi.annotation.documentation.SeeAlso;
 import org.apache.nifi.annotation.documentation.Tags;
@@ -29,22 +23,25 @@ import org.apache.nifi.annotation.lifecycle.OnEnabled;
 import org.apache.nifi.components.PropertyDescriptor;
 import org.apache.nifi.controller.AbstractControllerService;
 import org.apache.nifi.controller.ConfigurationContext;
-
 import org.apache.nifi.distributed.cache.client.AtomicCacheEntry;
 import org.apache.nifi.distributed.cache.client.AtomicDistributedMapCacheClient;
+import org.apache.nifi.distributed.cache.client.Deserializer;
 import org.apache.nifi.distributed.cache.client.Serializer;
 import org.apache.nifi.expression.ExpressionLanguageScope;
-import org.apache.nifi.distributed.cache.client.Deserializer;
-import org.apache.nifi.reporting.InitializationException;
-
-import java.nio.charset.StandardCharsets;
+import org.apache.nifi.hbase.put.PutColumn;
+import org.apache.nifi.hbase.scan.Column;
 import org.apache.nifi.hbase.scan.ResultCell;
 import org.apache.nifi.hbase.scan.ResultHandler;
-import org.apache.nifi.hbase.scan.Column;
-import org.apache.nifi.hbase.put.PutColumn;
-
-
 import org.apache.nifi.processor.util.StandardValidators;
+import org.apache.nifi.reporting.InitializationException;
+
+import java.io.ByteArrayOutputStream;
+import java.io.IOException;
+import java.nio.charset.StandardCharsets;
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.Collections;
+import java.util.List;
 
 import static org.apache.nifi.hbase.VisibilityLabelUtils.AUTHORIZATIONS;
 
@@ -164,6 +161,7 @@ public class HBase_2_ClientMapCacheService extends AbstractControllerService imp
       final HBaseRowHandler handler = new HBaseRowHandler();
 
       final List<Column> columnsList = new ArrayList<Column>(0);
+      columnsList.add(new Column(hBaseColumnFamilyBytes, hBaseColumnQualifierBytes));
 
       hBaseClientService.scan(hBaseCacheTableName, rowIdBytes, rowIdBytes, columnsList, authorizations, handler);
       return (handler.numRows() > 0);
@@ -196,6 +194,7 @@ public class HBase_2_ClientMapCacheService extends AbstractControllerService imp
       final HBaseRowHandler handler = new HBaseRowHandler();
 
       final List<Column> columnsList = new ArrayList<Column>(0);
+      columnsList.add(new Column(hBaseColumnFamilyBytes, hBaseColumnQualifierBytes));
 
       hBaseClientService.scan(hBaseCacheTableName, rowIdBytes, rowIdBytes, columnsList, authorizations, handler);
       if (handler.numRows() > 1) {
@@ -212,7 +211,8 @@ public class HBase_2_ClientMapCacheService extends AbstractControllerService imp
         final boolean contains = containsKey(key, keySerializer);
         if (contains) {
             final byte[] rowIdBytes = serialize(key, keySerializer);
-            hBaseClientService.delete(hBaseCacheTableName, rowIdBytes);
+            final DeleteRequest deleteRequest = new DeleteRequest(rowIdBytes, hBaseColumnFamilyBytes, hBaseColumnQualifierBytes, null);
+            hBaseClientService.deleteCells(hBaseCacheTableName, Collections.singletonList(deleteRequest));
         }
         return contains;
     }