You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Paul Brett <pa...@twopensource.com> on 2015/05/30 01:23:38 UTC
Review Request 34835: Add constexpr to C++ whitelist
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34835/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman, Dave Lester, Ian Downes, and Vinod Kone.
Summary (updated)
-----------------
Add constexpr to C++ whitelist
Bugs: MESOS-2784
https://issues.apache.org/jira/browse/MESOS-2784
Repository: mesos
Description (updated)
-------
Add constexpr to C++11 whitelist
Diffs (updated)
-----
docs/mesos-c++-style-guide.md 13312f6f4fe1788791479bd768f60df0a8e80e69
Diff: https://reviews.apache.org/r/34835/diff/
Testing
-------
Thanks,
Paul Brett
Re: Review Request 34835: Add constexpr to C++ whitelist
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34835/#review85850
-----------------------------------------------------------
Patch looks great!
Reviews applied: [34835]
All tests passed.
- Mesos ReviewBot
On May 29, 2015, 11:23 p.m., Paul Brett wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34835/
> -----------------------------------------------------------
>
> (Updated May 29, 2015, 11:23 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Dave Lester, Ian Downes, and Vinod Kone.
>
>
> Bugs: MESOS-2784
> https://issues.apache.org/jira/browse/MESOS-2784
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add constexpr to C++11 whitelist
>
>
> Diffs
> -----
>
> docs/mesos-c++-style-guide.md 13312f6f4fe1788791479bd768f60df0a8e80e69
>
> Diff: https://reviews.apache.org/r/34835/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Paul Brett
>
>
Re: Review Request 34835: Add constexpr to C++ whitelist
Posted by Ian Downes <ia...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34835/#review86026
-----------------------------------------------------------
docs/mesos-c++-style-guide.md
<https://reviews.apache.org/r/34835/#comment137875>
Add full-stop punctuation for consistency.
docs/mesos-c++-style-guide.md
<https://reviews.apache.org/r/34835/#comment137873>
s/objections/objects/ ;-)
This is worded as how _you_ intend to use constexpr for constexpr static *variables* and one consequence of using them in that manner. Can you be a bit more general as to what it enables?
Can you explicitly state our policy on constexpr {variables, functions, constructors}?
Document some examples and explicitly state the requirement on literal types and that e.g., std::string is *not*?
Are we discussing a switch to 'constexpr char foo[] = "bar"'?
- Ian Downes
On May 29, 2015, 4:23 p.m., Paul Brett wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34835/
> -----------------------------------------------------------
>
> (Updated May 29, 2015, 4:23 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Dave Lester, Ian Downes, and Vinod Kone.
>
>
> Bugs: MESOS-2784
> https://issues.apache.org/jira/browse/MESOS-2784
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add constexpr to C++11 whitelist
>
>
> Diffs
> -----
>
> docs/mesos-c++-style-guide.md 13312f6f4fe1788791479bd768f60df0a8e80e69
>
> Diff: https://reviews.apache.org/r/34835/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Paul Brett
>
>
Re: Review Request 34835: Add constexpr to C++ whitelist
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34835/#review87954
-----------------------------------------------------------
Patch looks great!
Reviews applied: [34835]
All tests passed.
- Mesos ReviewBot
On June 15, 2015, 5:59 p.m., Paul Brett wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34835/
> -----------------------------------------------------------
>
> (Updated June 15, 2015, 5:59 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Dave Lester, Ian Downes, and Vinod Kone.
>
>
> Bugs: MESOS-2784
> https://issues.apache.org/jira/browse/MESOS-2784
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add constexpr to C++11 whitelist
>
>
> Diffs
> -----
>
> docs/mesos-c++-style-guide.md 94107ed21c6f09349ce691f9f4d36b43bbbe809e
>
> Diff: https://reviews.apache.org/r/34835/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Paul Brett
>
>
Re: Review Request 34835: Add constexpr to C++ whitelist
Posted by Paul Brett <pa...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34835/
-----------------------------------------------------------
(Updated June 15, 2015, 5:59 p.m.)
Review request for mesos, Benjamin Hindman, Dave Lester, Ian Downes, and Vinod Kone.
Changes
-------
Address review comments
Bugs: MESOS-2784
https://issues.apache.org/jira/browse/MESOS-2784
Repository: mesos
Description
-------
Add constexpr to C++11 whitelist
Diffs (updated)
-----
docs/mesos-c++-style-guide.md 94107ed21c6f09349ce691f9f4d36b43bbbe809e
Diff: https://reviews.apache.org/r/34835/diff/
Testing
-------
Thanks,
Paul Brett
Re: Review Request 34835: Add constexpr to C++ whitelist
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34835/#review85840
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On May 29, 2015, 11:23 p.m., Paul Brett wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34835/
> -----------------------------------------------------------
>
> (Updated May 29, 2015, 11:23 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Dave Lester, Ian Downes, and Vinod Kone.
>
>
> Bugs: MESOS-2784
> https://issues.apache.org/jira/browse/MESOS-2784
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add constexpr to C++11 whitelist
>
>
> Diffs
> -----
>
> docs/mesos-c++-style-guide.md 13312f6f4fe1788791479bd768f60df0a8e80e69
>
> Diff: https://reviews.apache.org/r/34835/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Paul Brett
>
>