You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2022/03/18 10:58:56 UTC
[GitHub] [cloudstack] davidjumani opened a new pull request #6139: agent: Pass uefi support status as part of ready command
davidjumani opened a new pull request #6139:
URL: https://github.com/apache/cloudstack/pull/6139
### Description
Fixes https://github.com/apache/cloudstack/issues/6087
Adds support to detect existing hosts with UEFI capability
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
#### Feature/Enhancement Scale
- [ ] Major
- [x] Minor
### How Has This Been Tested?
- Bring up a 4.13 env with VMware 6.5 (anything that supports UEFI)
- Upgrade to latest main
- Try to deploy a VM with UEFI
- Deployment now passes Previously failed to find a suitable host as none were UEFI compatible
#### Before :
```
MariaDB [cloud]> select * from host_details where name = 'host.uefi.enable' \G
Empty set (0.00 sec)
```
#### After :
```
MariaDB [cloud]> select * from host_details where name = 'host.uefi.enable' \G
*************************** 1. row ***************************
id: 34
host_id: 1
name: host.uefi.enable
value: true
*************************** 2. row ***************************
id: 40
host_id: 2
name: host.uefi.enable
value: true
2 rows in set (0.00 sec)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #6139: agent: Pass uefi support status as part of ready command
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #6139:
URL: https://github.com/apache/cloudstack/pull/6139#issuecomment-1072385030
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #6139: agent: Detect existing hosts with UEFI support
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #6139:
URL: https://github.com/apache/cloudstack/pull/6139#issuecomment-1081550176
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani removed a comment on pull request #6139: agent: Detect existing hosts with UEFI support
Posted by GitBox <gi...@apache.org>.
davidjumani removed a comment on pull request #6139:
URL: https://github.com/apache/cloudstack/pull/6139#issuecomment-1074771702
@blueorangutan test centos7 xenserver-71
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6139: agent: Pass uefi support status as part of ready command
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #6139:
URL: https://github.com/apache/cloudstack/pull/6139#issuecomment-1072848598
<b>Trillian test result (tid-3664)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 31374 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6139-t3664-kvm-centos7.zip
Smoke tests completed. 92 look OK, 0 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6139: agent: Detect existing hosts with UEFI support
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #6139:
URL: https://github.com/apache/cloudstack/pull/6139#issuecomment-1082208082
<b>Trillian test result (tid-3748)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 31855 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6139-t3748-kvm-centos7.zip
Smoke tests completed. 92 look OK, 0 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on a change in pull request #6139: agent: Pass uefi support status as part of ready command
Posted by GitBox <gi...@apache.org>.
nvazquez commented on a change in pull request #6139:
URL: https://github.com/apache/cloudstack/pull/6139#discussion_r829901470
##########
File path: plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/VmwareServerDiscoverer.java
##########
@@ -367,10 +367,6 @@ public VmwareServerDiscoverer() {
details.put("url", hostMo.getHostName());
details.put("username", username);
details.put("password", password);
- boolean uefiLegacySupported = hostMo.isUefiLegacySupported();
Review comment:
I think these could be kept, same for other discoverers
##########
File path: engine/orchestration/src/main/java/com/cloud/agent/manager/AgentManagerImpl.java
##########
@@ -600,6 +600,19 @@ protected AgentAttache notifyMonitorsOfConnection(final AgentAttache attache, fi
// return the attache instead of null, even it is disconnectede
handleDisconnectWithoutInvestigation(attache, Event.AgentDisconnected, true, true);
}
+ if (answer instanceof ReadyAnswer) {
+ ReadyAnswer readyAnswer = (ReadyAnswer)answer;
+ Map<String, String> detailsMap = readyAnswer.getDetailsMap();
+ if (detailsMap != null) {
+ String uefiEnabled = detailsMap.get(Host.HOST_UEFI_ENABLE);
+ s_logger.debug(String.format("Got HOST_UEFI_ENABLE [%s] for hostId [%s]:", uefiEnabled, host.getUuid()));
+ if (uefiEnabled != null) {
+ _hostDao.loadDetails(host);
+ host.getDetails().put(Host.HOST_UEFI_ENABLE, uefiEnabled);
+ _hostDao.saveDetails(host);
Review comment:
What about checking first and persisting only in case it was not present or the value changed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6139: agent: Pass uefi support status as part of ready command
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #6139:
URL: https://github.com/apache/cloudstack/pull/6139#issuecomment-1072585855
@weizhouapache a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #6139: agent: Pass uefi support status as part of ready command
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #6139:
URL: https://github.com/apache/cloudstack/pull/6139#issuecomment-1072299368
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6139: agent: Pass uefi support status as part of ready command
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #6139:
URL: https://github.com/apache/cloudstack/pull/6139#issuecomment-1072917902
<b>Trillian test result (tid-3671)</b>
Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7
Total time taken: 32668 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6139-t3671-vmware-65u2.zip
Intermittent failure detected: /marvin/tests/smoke/test_usage.py
Intermittent failure detected: /marvin/tests/smoke/test_iso.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #6139: agent: Detect existing hosts with UEFI support
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #6139:
URL: https://github.com/apache/cloudstack/pull/6139#issuecomment-1074769068
@blueorangutan help
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #6139: agent: Detect existing hosts with UEFI support
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #6139:
URL: https://github.com/apache/cloudstack/pull/6139#issuecomment-1081601423
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6139: agent: Detect existing hosts with UEFI support
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #6139:
URL: https://github.com/apache/cloudstack/pull/6139#issuecomment-1081596255
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 3004
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6139: agent: Detect existing hosts with UEFI support
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #6139:
URL: https://github.com/apache/cloudstack/pull/6139#issuecomment-1074770405
@davidjumani a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6139: agent: Detect existing hosts with UEFI support
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #6139:
URL: https://github.com/apache/cloudstack/pull/6139#issuecomment-1074771272
@davidjumani a Trillian-Jenkins test job (centos7 mgmt + xcpng82) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #6139: agent: Detect existing hosts with UEFI support
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #6139:
URL: https://github.com/apache/cloudstack/pull/6139#issuecomment-1074771702
@blueorangutan test centos7 xenserver-71
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6139: agent: Detect existing hosts with UEFI support
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #6139:
URL: https://github.com/apache/cloudstack/pull/6139#issuecomment-1075228976
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6139: agent: Detect existing hosts with UEFI support
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #6139:
URL: https://github.com/apache/cloudstack/pull/6139#issuecomment-1075848408
<b>Trillian test result (tid-3698)</b>
Environment: xcpng82 (x2), Advanced Networking with Mgmt server 7
Total time taken: 42933 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6139-t3698-xcpng82.zip
Smoke tests completed. 91 look OK, 1 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_12_resize_volume_with_only_size_parameter | `Error` | 1.06 | test_volumes.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6139: agent: Pass uefi support status as part of ready command
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #6139:
URL: https://github.com/apache/cloudstack/pull/6139#issuecomment-1072329363
@davidjumani a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on a change in pull request #6139: agent: Pass uefi support status as part of ready command
Posted by GitBox <gi...@apache.org>.
nvazquez commented on a change in pull request #6139:
URL: https://github.com/apache/cloudstack/pull/6139#discussion_r829901470
##########
File path: plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/VmwareServerDiscoverer.java
##########
@@ -367,10 +367,6 @@ public VmwareServerDiscoverer() {
details.put("url", hostMo.getHostName());
details.put("username", username);
details.put("password", password);
- boolean uefiLegacySupported = hostMo.isUefiLegacySupported();
Review comment:
I think these could be kept, same for other discoverers
##########
File path: engine/orchestration/src/main/java/com/cloud/agent/manager/AgentManagerImpl.java
##########
@@ -600,6 +600,19 @@ protected AgentAttache notifyMonitorsOfConnection(final AgentAttache attache, fi
// return the attache instead of null, even it is disconnectede
handleDisconnectWithoutInvestigation(attache, Event.AgentDisconnected, true, true);
}
+ if (answer instanceof ReadyAnswer) {
+ ReadyAnswer readyAnswer = (ReadyAnswer)answer;
+ Map<String, String> detailsMap = readyAnswer.getDetailsMap();
+ if (detailsMap != null) {
+ String uefiEnabled = detailsMap.get(Host.HOST_UEFI_ENABLE);
+ s_logger.debug(String.format("Got HOST_UEFI_ENABLE [%s] for hostId [%s]:", uefiEnabled, host.getUuid()));
+ if (uefiEnabled != null) {
+ _hostDao.loadDetails(host);
+ host.getDetails().put(Host.HOST_UEFI_ENABLE, uefiEnabled);
+ _hostDao.saveDetails(host);
Review comment:
What about checking first and persisting only in case it was not present or the value changed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #6139: agent: Detect existing hosts with UEFI support
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #6139:
URL: https://github.com/apache/cloudstack/pull/6139#issuecomment-1074769978
@blueorangutan test centos7 vmware-67u3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6139: agent: Detect existing hosts with UEFI support
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #6139:
URL: https://github.com/apache/cloudstack/pull/6139#issuecomment-1074774174
@davidjumani a Trillian-Jenkins test job (centos7 mgmt + xenserver-71) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6139: agent: Detect existing hosts with UEFI support
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #6139:
URL: https://github.com/apache/cloudstack/pull/6139#issuecomment-1075227373
@nvazquez a Trillian-Jenkins test job (centos7 mgmt + xcpng82) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6139: agent: Detect existing hosts with UEFI support
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #6139:
URL: https://github.com/apache/cloudstack/pull/6139#issuecomment-1074769503
@davidjumani I understand these words: "help", "hello", "thanks", "package", "test"
Test command usage: test [mgmt os] [hypervisor] [keepEnv]
Mgmt OS options: ['suse15', 'centos7', 'centos6', 'alma8', 'ubuntu18', 'ubuntu20', 'rocky8']
Hypervisor options: ['kvm-centos6', 'kvm-centos7', 'kvm-rocky8', 'kvm-alma8', 'kvm-ubuntu18', 'kvm-ubuntu20', 'kvm-suse15', 'vmware-55u3', 'vmware-60u2', 'vmware-65u2', 'vmware-67u3', 'vmware-70u1', 'vmware-70u2', 'vmware-70u3', 'xenserver-65sp1', 'xenserver-71', 'xenserver-74', 'xcpng74', 'xcpng76', 'xcpng80', 'xcpng81', 'xcpng82']
Note: when keepEnv is passed, you need to specify mgmt server os and hypervisor or use the `matrix` command.
Package command usage: package [all(default value),kvm,xen,vmware,hyperv,ovm] - a comma separated list can be passed with package command to bundle the required hypervisor's systemVM templates. Not passing any argument will bundle all - kvm,xen and vmware templates.
Blessed contributors for kicking Trillian test jobs: ['rohityadavcloud', 'nvazquez', 'borisstoyanov', 'DaanHoogland', 'shwstppr', 'andrijapanicsb', 'Pearl1594', 'davidjumani', 'harikrishna-patnala', 'vladimirpetrov', 'sureshanaparti', 'weizhouapache', 'NuxRo']
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #6139: agent: Pass uefi support status as part of ready command
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #6139:
URL: https://github.com/apache/cloudstack/pull/6139#issuecomment-1072328953
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6139: agent: Pass uefi support status as part of ready command
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #6139:
URL: https://github.com/apache/cloudstack/pull/6139#issuecomment-1072299541
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #6139: agent: Pass uefi support status as part of ready command
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #6139:
URL: https://github.com/apache/cloudstack/pull/6139#issuecomment-1072385030
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on a change in pull request #6139: agent: Pass uefi support status as part of ready command
Posted by GitBox <gi...@apache.org>.
davidjumani commented on a change in pull request #6139:
URL: https://github.com/apache/cloudstack/pull/6139#discussion_r829917852
##########
File path: plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/VmwareServerDiscoverer.java
##########
@@ -367,10 +367,6 @@ public VmwareServerDiscoverer() {
details.put("url", hostMo.getHostName());
details.put("username", username);
details.put("password", password);
- boolean uefiLegacySupported = hostMo.isUefiLegacySupported();
Review comment:
It would be redundant as the code to check the UEFI support is subsequently called while adding a host
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6139: agent: Detect existing hosts with UEFI support
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #6139:
URL: https://github.com/apache/cloudstack/pull/6139#issuecomment-1081550922
@weizhouapache a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #6139: agent: Pass uefi support status as part of ready command
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #6139:
URL: https://github.com/apache/cloudstack/pull/6139#issuecomment-1072585700
@blueorangutan test matrix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #6139: agent: Pass uefi support status as part of ready command
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #6139:
URL: https://github.com/apache/cloudstack/pull/6139#issuecomment-1074767326
@blueorangutan help
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6139: agent: Detect existing hosts with UEFI support
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #6139:
URL: https://github.com/apache/cloudstack/pull/6139#issuecomment-1075224874
<b>Trillian test result (tid-3691)</b>
Environment: xcpng82 (x2), Advanced Networking with Mgmt server 7
Total time taken: 27824 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6139-t3691-xcpng82.zip
Intermittent failure detected: /marvin/tests/smoke/test_volumes.py
Intermittent failure detected: /marvin/tests/smoke/test_metrics_api.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #6139: agent: Detect existing hosts with UEFI support
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #6139:
URL: https://github.com/apache/cloudstack/pull/6139#issuecomment-1075226522
@blueorangutan test centos7 xcpng82
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6139: agent: Detect existing hosts with UEFI support
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #6139:
URL: https://github.com/apache/cloudstack/pull/6139#issuecomment-1081601817
@weizhouapache a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #6139: agent: Pass uefi support status as part of ready command
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #6139:
URL: https://github.com/apache/cloudstack/pull/6139#issuecomment-1072299368
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6139: agent: Pass uefi support status as part of ready command
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #6139:
URL: https://github.com/apache/cloudstack/pull/6139#issuecomment-1072356307
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 2930
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6139: agent: Pass uefi support status as part of ready command
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #6139:
URL: https://github.com/apache/cloudstack/pull/6139#issuecomment-1072385428
@nvazquez a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6139: agent: Pass uefi support status as part of ready command
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #6139:
URL: https://github.com/apache/cloudstack/pull/6139#issuecomment-1072299541
@davidjumani a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on a change in pull request #6139: agent: Pass uefi support status as part of ready command
Posted by GitBox <gi...@apache.org>.
davidjumani commented on a change in pull request #6139:
URL: https://github.com/apache/cloudstack/pull/6139#discussion_r829917852
##########
File path: plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/VmwareServerDiscoverer.java
##########
@@ -367,10 +367,6 @@ public VmwareServerDiscoverer() {
details.put("url", hostMo.getHostName());
details.put("username", username);
details.put("password", password);
- boolean uefiLegacySupported = hostMo.isUefiLegacySupported();
Review comment:
It would be redundant as the code to check the UEFI support is subsequently called while adding a host
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #6139: agent: Detect existing hosts with UEFI support
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #6139:
URL: https://github.com/apache/cloudstack/pull/6139#issuecomment-1074773680
@blueorangutan test centos7 xenserver-71
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #6139: agent: Detect existing hosts with UEFI support
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #6139:
URL: https://github.com/apache/cloudstack/pull/6139#issuecomment-1074771066
@blueorangutan test centos7 xcpng82
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org