You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by uce <gi...@git.apache.org> on 2016/02/08 16:08:52 UTC
[GitHub] flink pull request: [FLINK-3367] [core] Drop AbstractID#toShortStr...
GitHub user uce opened a pull request:
https://github.com/apache/flink/pull/1601
[FLINK-3367] [core] Drop AbstractID#toShortString()
Drops the `toShortString` method in `AbstractID`.
@aljoscha Is that OK in the RocksDB state backend?
@gyfora As discussed offline, I've still shortened the ID in the DB state backend, because this a requirement from certain DBs for table names.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/uce/flink 3357-drop_short
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/1601.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1601
----
commit 0fd11a9ce65755dee2be3d42ae8dff9dcca28787
Author: Ufuk Celebi <uc...@apache.org>
Date: 2016-02-08T15:05:27Z
[FLINK-3367] [core] Drop AbstractID#toShortString()
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3357] [core] Drop AbstractID#toShortStr...
Posted by aljoscha <gi...@git.apache.org>.
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/1601#issuecomment-181436492
In RocksDB it should work. It is just local filesystem paths and FileSystem paths that are affected by this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3357] [core] Drop AbstractID#toShortStr...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1601
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3357] [core] Drop AbstractID#toShortStr...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1601#issuecomment-181523979
Looks good, merging this...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---