[GitHub] [iotdb] wangchao316 commented on a change in pull request #3502: [IOTDB-1463] Implement builder pattern for Session and SessionPool

[GitBox <gi...@apache.org>]

wangchao316 commented on a change in pull request #3502:
URL: https://github.com/apache/iotdb/pull/3502#discussion_r663586657



##########
File path: session/src/test/java/org/apache/iotdb/session/SessionUT.java
##########
@@ -244,4 +245,25 @@ public void createDeviceTemplate() throws IoTDBConnectionException, StatementExe
         "template1", schemaNames, measurementList, dataTypeList, encodingList, compressionTypes);
     session.setSchemaTemplate("template1", "root.sg.1");
   }
+
+  @Test
+  public void testBuilder() {
+    Session.Builder builder = new Session.Builder("localhost", 1234);

Review comment:
       hi
   I found this implementation to be inconsistent with the use cases on jira.
   We need to return a session through sessionbuild.
   Session session = new SessionBuilder().build()

##########
File path: session/src/test/java/org/apache/iotdb/session/SessionUT.java
##########
@@ -43,6 +43,7 @@
 
 import static org.junit.Assert.assertArrayEquals;
 import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertTrue;
 import static org.junit.Assert.fail;
 
 public class SessionUT {

Review comment:
       generate, Generally, UT ends with Test,
   IT ends with IT.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org