You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/12/15 17:07:26 UTC

[GitHub] [flink] zentol commented on a change in pull request #14390: [hotfix] Various hotfixes from a static code analysis

zentol commented on a change in pull request #14390:
URL: https://github.com/apache/flink/pull/14390#discussion_r543523100



##########
File path: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/netty/NettyMessageClientDecoderDelegateTest.java
##########
@@ -162,8 +162,9 @@ private void testNettyMessageClientDecoding(
 		try {
 			List<BufferResponse> messages = createMessageList(
 				hasEmptyBuffer,
-				hasBufferForReleasedChannel,
-				hasBufferForRemovedChannel);
+				hasBufferForRemovedChannel,

Review comment:
       These could just as well be naming errors in the method parameters.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org