You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2023/01/19 14:27:05 UTC

[GitHub] [skywalking] mikechengwei opened a new pull request, #10298: feature: windows monitoring

mikechengwei opened a new pull request, #10298:
URL: https://github.com/apache/skywalking/pull/10298

   <!--
       ⚠️ Please make sure to read this template first, pull requests that don't accord with this template
       maybe closed without notice.
       Texts surrounded by `<` and `>` are meant to be replaced by you, e.g. <framework name>, <issue number>.
       Put an `x` in the `[ ]` to mark the item as CHECKED. `[x]`
   -->
   
   <!-- ==== πŸ› Remove this line WHEN AND ONLY WHEN you're fixing a bug, follow the checklist πŸ‘‡ ====
   ### Fix <bug description or the bug issue number or bug issue link>
   - [ ] Add a unit test to verify that the fix works.
   - [ ] Explain briefly why the bug exists and how to fix it.
        ==== πŸ› Remove this line WHEN AND ONLY WHEN you're fixing a bug, follow the checklist πŸ‘† ==== -->
   
   <!-- ==== πŸ“ˆ Remove this line WHEN AND ONLY WHEN you're improving the performance, follow the checklist πŸ‘‡ ====
   ### Improve the performance of <class or module or ...>
   - [ ] Add a benchmark for the improvement, refer to [the existing ones](https://github.com/apache/skywalking/blob/master/apm-commons/apm-datacarrier/src/test/java/org/apache/skywalking/apm/commons/datacarrier/LinkedArrayBenchmark.java)
   - [ ] The benchmark result.
   ```text
   <Paste the benchmark results here>
   ```
   - [ ] Links/URLs to the theory proof or discussion articles/blogs. <links/URLs here>
        ==== πŸ“ˆ Remove this line WHEN AND ONLY WHEN you're improving the performance, follow the checklist πŸ‘† ==== -->
   
   <!-- ==== πŸ†• Remove this line WHEN AND ONLY WHEN you're adding a new feature, follow the checklist πŸ‘‡ ====
   ### <Feature description>
   - [ ] If this is non-trivial feature, paste the links/URLs to the design doc.
   - [ ] Update the documentation to include this new feature.
   - [ ] Tests(including UT, IT, E2E) are added to verify the new feature.
   - [ ] If it's UI related, attach the screenshots below.
        ==== πŸ†• Remove this line WHEN AND ONLY WHEN you're adding a new feature, follow the checklist πŸ‘† ==== -->
   
   - [ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #10242 .
   - [ ] Update the [`CHANGES` log](https://github.com/apache/skywalking/blob/master/docs/en/changes/changes.md).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wankai123 commented on pull request #10298: feature: windows monitoring

Posted by GitBox <gi...@apache.org>.
wankai123 commented on PR #10298:
URL: https://github.com/apache/skywalking/pull/10298#issuecomment-1397865868

   > The E2E is running on docker, you can use the wins_exporter image to run it.
   
   Or you can base on `windows/nanoserver` to build a image, if you can't find a official one.
   This might help: https://github.com/prometheus-community/windows_exporter/blob/master/Dockerfile
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng commented on pull request #10298: feature: windows monitoring

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on PR #10298:
URL: https://github.com/apache/skywalking/pull/10298#issuecomment-1397877093

   You could use a window server for CI.
   
   https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners#supported-runners-and-hardware-resources
   
   @kezhenxu94 Does our e2e support Windows?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] mikechengwei commented on pull request #10298: feature: windows monitoring

Posted by "mikechengwei (via GitHub)" <gi...@apache.org>.
mikechengwei commented on PR #10298:
URL: https://github.com/apache/skywalking/pull/10298#issuecomment-1417842721

   > @mikechengwei Have you been back on this?
   
   sorry, i will finish it as soon as possible.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wankai123 commented on a diff in pull request #10298: feature: windows monitoring

Posted by "wankai123 (via GitHub)" <gi...@apache.org>.
wankai123 commented on code in PR #10298:
URL: https://github.com/apache/skywalking/pull/10298#discussion_r1104079733


##########
test/e2e-v2/cases/win/expected/service.yml:
##########
@@ -0,0 +1,24 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+  {{- contains . }}
+- id: {{ b64enc "win::SkyWalking" }}.1
+  name: win::SkyWalking

Review Comment:
   The service name should be the IP or host name?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] mikechengwei commented on pull request #10298: feature: windows monitoring

Posted by "mikechengwei (via GitHub)" <gi...@apache.org>.
mikechengwei commented on PR #10298:
URL: https://github.com/apache/skywalking/pull/10298#issuecomment-1426860456

   > @mikechengwei One week passed. Any update?
   
   I have added e2e test mock code.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng commented on pull request #10298: feature: windows monitoring

Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #10298:
URL: https://github.com/apache/skywalking/pull/10298#issuecomment-1427455157

   I mean something like this https://github.com/apache/skywalking-booster-ui/pull/227. You have to finish that and we can see the Windows monitoring on the UI menu like other existing items.
   Right now, you could only access this dashboard through dashboard management page, right?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng commented on pull request #10298: feature: windows monitoring

Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #10298:
URL: https://github.com/apache/skywalking/pull/10298#issuecomment-1431457727

   I just reopen it to trigger the task. Your first PR of this repo needs to wait for maintainer's approval, but you submit two commits too quickly, which triggered an unknown bug of GHA, then nothing happens.
   
   I think it is back to work now.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] mikechengwei commented on pull request #10298: feature: windows monitoring

Posted by "mikechengwei (via GitHub)" <gi...@apache.org>.
mikechengwei commented on PR #10298:
URL: https://github.com/apache/skywalking/pull/10298#issuecomment-1431997218

   > Tests passed. @mikechengwei Please finish UI side pull request.
   > 
   > @wankai123 PTAL
   
   okk, thanks for a lot.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] mikechengwei commented on pull request #10298: feature: windows monitoring

Posted by "mikechengwei (via GitHub)" <gi...@apache.org>.
mikechengwei commented on PR #10298:
URL: https://github.com/apache/skywalking/pull/10298#issuecomment-1428987944

   > Your tests are still failing. Why don't you verify before submitting the changes? I can't see the point we keep eyes on a PR of keeping updated but failing.
   
   I thought the manual test passed, and e2e was fine. Now let me see how the e2e test runs locally.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng commented on pull request #10298: feature: windows monitoring

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on PR #10298:
URL: https://github.com/apache/skywalking/pull/10298#issuecomment-1397112050

   > OK, I just successfully ran through the process, I will continue to improve the pr. @wu-sheng
   
   Take your time. I just pointed out which may be missed as you have labeled this PR ready for review. :)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] mikechengwei commented on pull request #10298: feature: windows monitoring

Posted by GitBox <gi...@apache.org>.
mikechengwei commented on PR #10298:
URL: https://github.com/apache/skywalking/pull/10298#issuecomment-1397855253

   > The expressions LGTM, let's wait the e2e codes and others to finish this.
   
   I have a question to ask you, i need install wins_exporter in a windows machine implement in e2e test
   , how should I implement this logic? @wankai123 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng commented on a diff in pull request #10298: feature: windows monitoring

Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on code in PR #10298:
URL: https://github.com/apache/skywalking/pull/10298#discussion_r1113778748


##########
test/e2e-v2/cases/win/expected/metrics-has-value.yml:
##########
@@ -0,0 +1,19 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+{{- contains . }}
+- key: {{ notEmpty .key }}
+  value: {{ ge .value 0 }}

Review Comment:
   @mikechengwei `ge 0` actually means nothing in testing. When we try to correct this, tests fail.
   
   https://github.com/pg-yang/skywalking/pull/14



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] mikechengwei commented on pull request #10298: feature: windows monitoring

Posted by "mikechengwei (via GitHub)" <gi...@apache.org>.
mikechengwei commented on PR #10298:
URL: https://github.com/apache/skywalking/pull/10298#issuecomment-1427085893

   > @mikechengwei You need to add your e2e to GHA control file. Otherwise, it never runs through CI system.
   
   I have done.
   Dashboard screenshots:
   <img width="622" alt="Screen Shot 2023-02-13 at 12 45 12 AM" src="https://user-images.githubusercontent.com/13257127/218326507-e6c1ac4f-8784-4dfa-9fa2-584ac3508e42.png">
   <img width="1529" alt="Screen Shot 2023-02-13 at 1 21 02 AM" src="https://user-images.githubusercontent.com/13257127/218326512-50736e01-acdc-42f9-8db4-d6046339fe79.png">
   
   
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wankai123 commented on a diff in pull request #10298: feature: windows monitoring

Posted by "wankai123 (via GitHub)" <gi...@apache.org>.
wankai123 commented on code in PR #10298:
URL: https://github.com/apache/skywalking/pull/10298#discussion_r1106844950


##########
test/e2e-v2/cases/win/e2e.yaml:
##########
@@ -25,8 +25,8 @@ setup:
       command: export PATH=/tmp/skywalking-infra-e2e/bin:$PATH
     - name: install yq
       command: bash test/e2e-v2/script/prepare/setup-e2e-shell/install.sh yq
-    - name: install swctl
-      command: bash test/e2e-v2/script/prepare/setup-e2e-shell/install.sh swctl
+#    - name: install swctl
+#      command: bash test/e2e-v2/script/prepare/setup-e2e-shell/install.sh swctl
 

Review Comment:
   I think this changes for your local test, should rollback



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] mikechengwei commented on a diff in pull request #10298: feature: windows monitoring

Posted by "mikechengwei (via GitHub)" <gi...@apache.org>.
mikechengwei commented on code in PR #10298:
URL: https://github.com/apache/skywalking/pull/10298#discussion_r1104606109


##########
test/e2e-v2/cases/win/eks-cases.yaml:
##########
@@ -18,11 +18,7 @@
   cases:
     - query: swctl --display yaml --base-url=http://${oap_host}:${oap_12800}/graphql service ls
       expected: expected/service.yml
-    - query: swctl --display yaml --base-url=http://${oap_host}:${oap_12800}/graphql instance ls --service-name=SkyWalking
-      expected:  expected/instance.yml
-    - query: swctl --display yaml --base-url=http://${oap_host}:${oap_12800}/graphql endpoint ls --service-name=SkyWalking
-      expected:  expected/endpoint.yml
-    - query: swctl --display yaml --base-url=http://${oap_host}:${oap_12800}/graphql metrics linear --name=meter_win_cpu_total_percentage --service-name=SkyWalking --net.host.name=10.211.55.3 | yq e 'to_entries' -
+    - query: swctl --display yaml --base-url=http://${oap_host}:${oap_12800}/graphql metrics linear --name=meter_win_cpu_total_percentage --service-name=10.211.55.3 --instance-name=10.211.55.3 | yq e 'to_entries' -
       expected: expected/metrics-has-value.yml
-    - query: swctl --display yaml --base-url=http://${oap_host}:${oap_12800}/graphql metrics linear --name=meter_win_memory_swap_total --service-name=SkyWalking --endpoint-name=kube-dns  | yq e 'to_entries' -
+    - query: swctl --display yaml --base-url=http://${oap_host}:${oap_12800}/graphql metrics linear --name=meter_win_memory_swap_total --service-name=10.211.55.3 --endpoint-name=kube-dns  | yq e 'to_entries' -

Review Comment:
   This is windows case, are service-name must `SkyWalking`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng commented on pull request #10298: feature: windows monitoring

Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #10298:
URL: https://github.com/apache/skywalking/pull/10298#issuecomment-1426918875

   And please provide your final screenshots or videos for your new dashboard.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng commented on pull request #10298: feature: windows monitoring

Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #10298:
URL: https://github.com/apache/skywalking/pull/10298#issuecomment-1427164068

   Why do you put each metrics per line?
   Generally, we put relative 3-4 metrics in a line, and put all metrics in one page without scrolling if possible


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] mikechengwei commented on pull request #10298: feature: windows monitoring

Posted by "mikechengwei (via GitHub)" <gi...@apache.org>.
mikechengwei commented on PR #10298:
URL: https://github.com/apache/skywalking/pull/10298#issuecomment-1430975010

   > The tests fail due to the expected data not match your mock data. Try it on a Mac or Linux. It is easy to run.
   
   I have solved ci problem and commit new code.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] mikechengwei commented on pull request #10298: feature: windows monitoring

Posted by GitBox <gi...@apache.org>.
mikechengwei commented on PR #10298:
URL: https://github.com/apache/skywalking/pull/10298#issuecomment-1397875061

   @wankai123 I find windows image can't build and run in linux physical machine，it will throw exception below 
   ```
   docker: no matching manifest for linux/amd64 in the manifest list entries.
   ```
   Ref: https://stackoverflow.com/questions/42158596/can-windows-containers-be-hosted-on-linux
   
   I think our CI machine is linux, right?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] kezhenxu94 commented on pull request #10298: feature: windows monitoring

Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on PR #10298:
URL: https://github.com/apache/skywalking/pull/10298#issuecomment-1398140149

   If we cannot run the exporter on a Windows system, does it make sense to mock the data and run a test, what actually is tested? The MAL engine?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wankai123 commented on a diff in pull request #10298: feature: windows monitoring

Posted by "wankai123 (via GitHub)" <gi...@apache.org>.
wankai123 commented on code in PR #10298:
URL: https://github.com/apache/skywalking/pull/10298#discussion_r1104076020


##########
test/e2e-v2/cases/win/expected/instance.yml:
##########
@@ -0,0 +1,22 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+  {{- contains . }}

Review Comment:
   same here.



##########
test/e2e-v2/cases/win/expected/endpoint.yml:
##########
@@ -0,0 +1,19 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+{{- contains .}}

Review Comment:
   I think we don't need verify `Endpoint` and `Instance`,  your MAL didn't refer to these.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wankai123 commented on a diff in pull request #10298: feature: windows monitoring

Posted by "wankai123 (via GitHub)" <gi...@apache.org>.
wankai123 commented on code in PR #10298:
URL: https://github.com/apache/skywalking/pull/10298#discussion_r1104056779


##########
test/e2e-v2/java-test-service/e2e-mock-sender/src/main/java/org/apache/skywalking/e2e/controller/OtelMetricsSender.java:
##########
@@ -80,7 +80,7 @@ public String sendMetricsByTemplate() throws IOException {
             return msg;
         }
         for (File file : files) {
-            final ExportMetricsServiceRequest.Builder builder = ExportMetricsServiceRequest.newBuilder();
+            final win::SkyWalking.Builder builder = ExportMetricsServiceRequest.newBuilder();

Review Comment:
   Why do you change this?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng commented on pull request #10298: feature: windows monitoring

Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #10298:
URL: https://github.com/apache/skywalking/pull/10298#issuecomment-1428990483

   The tests fail due to the expected data not match your mock data.
   Try it on a Mac or Linux. It is easy to run.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng commented on a diff in pull request #10298: feature: windows monitoring

Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on code in PR #10298:
URL: https://github.com/apache/skywalking/pull/10298#discussion_r1106846723


##########
docs/en/setup/backend/backend-win-monitoring.md:
##########
@@ -0,0 +1,34 @@
+# Windows Monitoring
+SkyWalking leverages Prometheus windows_exporter to collect metrics data from the Windows and leverages OpenTelemetry Collector to transfer the metrics to
+[OpenTelemetry receiver](opentelemetry-receiver.md) and into the [Meter System](./../../concepts-and-designs/meter.md).
+Windows entity as a `Service` in OAP and on the `Layer: OS_WINDOWS`.
+
+## Data flow
+**For OpenTelemetry receiver:**
+1. The Prometheus windows_exporter collects metrics data from the VMs.
+2. The OpenTelemetry Collector fetches metrics from windows_exporter via Prometheus Receiver and pushes metrics to the SkyWalking OAP Server via the OpenCensus gRPC Exporter or OpenTelemetry gRPC exporter.
+3. The SkyWalking OAP Server parses the expression with [MAL](../../concepts-and-designs/mal.md) to filter/calculate/aggregate and store the results.
+
+## Setup
+**For OpenTelemetry receiver:**
+1. Setup [Prometheus windows_exporter](https://github.com/prometheus-community/windows_exporter).
+2. Setup [OpenTelemetry Collector ](https://opentelemetry.io/docs/collector/). This is an example for OpenTelemetry Collector configuration [otel-collector-config.yaml](../../../../test/e2e-v2/cases/vm/prometheus-node-exporter/otel-collector-config.yaml).

Review Comment:
   I think you should provide your own OTEL config.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] mikechengwei commented on a diff in pull request #10298: feature: windows monitoring

Posted by "mikechengwei (via GitHub)" <gi...@apache.org>.
mikechengwei commented on code in PR #10298:
URL: https://github.com/apache/skywalking/pull/10298#discussion_r1106855459


##########
test/e2e-v2/cases/win/e2e.yaml:
##########
@@ -0,0 +1,44 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+# This file is used to show how to write configuration files and can be used to test.
+
+setup:
+  env: compose
+  file: docker-compose.yml
+  timeout: 20m
+  init-system-environment: ../../script/env
+  steps:
+    - name: set PATH
+      command: export PATH=/tmp/skywalking-infra-e2e/bin:$PATH
+    - name: install yq
+      command: bash test/e2e-v2/script/prepare/setup-e2e-shell/install.sh yq
+#    - name: install swctl
+#      command: bash test/e2e-v2/script/prepare/setup-e2e-shell/install.sh swctl

Review Comment:
   revert.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] mikechengwei commented on pull request #10298: feature: windows monitoring

Posted by GitBox <gi...@apache.org>.
mikechengwei commented on PR #10298:
URL: https://github.com/apache/skywalking/pull/10298#issuecomment-1398019334

   > This is an example of OTEL data mock for EKS monitoring.
   > 
   > * https://github.com/apache/skywalking/tree/master/test/e2e-v2/cases/aws/eks
   > * Mock sender is here, https://github.com/apache/skywalking/blob/master/test/e2e-v2/java-test-service/e2e-mock-sender/src/main/java/org/apache/skywalking/e2e/controller/OtelMetricsSender.java
   
   ok, I thought I'd try to use the mock data way.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng commented on a diff in pull request #10298: feature: windows monitoring

Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on code in PR #10298:
URL: https://github.com/apache/skywalking/pull/10298#discussion_r1104574917


##########
test/e2e-v2/cases/win/eks-cases.yaml:
##########
@@ -18,11 +18,7 @@
   cases:
     - query: swctl --display yaml --base-url=http://${oap_host}:${oap_12800}/graphql service ls
       expected: expected/service.yml
-    - query: swctl --display yaml --base-url=http://${oap_host}:${oap_12800}/graphql instance ls --service-name=SkyWalking
-      expected:  expected/instance.yml
-    - query: swctl --display yaml --base-url=http://${oap_host}:${oap_12800}/graphql endpoint ls --service-name=SkyWalking
-      expected:  expected/endpoint.yml
-    - query: swctl --display yaml --base-url=http://${oap_host}:${oap_12800}/graphql metrics linear --name=meter_win_cpu_total_percentage --service-name=SkyWalking --net.host.name=10.211.55.3 | yq e 'to_entries' -
+    - query: swctl --display yaml --base-url=http://${oap_host}:${oap_12800}/graphql metrics linear --name=meter_win_cpu_total_percentage --service-name=10.211.55.3 --instance-name=10.211.55.3 | yq e 'to_entries' -
       expected: expected/metrics-has-value.yml
-    - query: swctl --display yaml --base-url=http://${oap_host}:${oap_12800}/graphql metrics linear --name=meter_win_memory_swap_total --service-name=SkyWalking --endpoint-name=kube-dns  | yq e 'to_entries' -
+    - query: swctl --display yaml --base-url=http://${oap_host}:${oap_12800}/graphql metrics linear --name=meter_win_memory_swap_total --service-name=10.211.55.3 --endpoint-name=kube-dns  | yq e 'to_entries' -

Review Comment:
   Oh, you are nto changing EKS case, but copied file name? Please fix.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng commented on a diff in pull request #10298: feature: windows monitoring

Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on code in PR #10298:
URL: https://github.com/apache/skywalking/pull/10298#discussion_r1104610089


##########
test/e2e-v2/cases/win/e2e.yaml:
##########
@@ -0,0 +1,44 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+# This file is used to show how to write configuration files and can be used to test.
+
+setup:
+  env: compose
+  file: docker-compose.yml
+  timeout: 20m
+  init-system-environment: ../../script/env
+  steps:
+    - name: set PATH
+      command: export PATH=/tmp/skywalking-infra-e2e/bin:$PATH
+    - name: install yq
+      command: bash test/e2e-v2/script/prepare/setup-e2e-shell/install.sh yq
+    - name: install swctl
+      command: bash test/e2e-v2/script/prepare/setup-e2e-shell/install.sh swctl
+
+trigger:
+  action: http
+  interval: 3s
+  times: 10
+  url: http://localhost:9093/otel-metrics/send
+  method: GET
+
+verify:
+  retry:
+    count: 10
+    interval: 3s
+  cases:
+    - includes:
+        - ./eks-cases.yaml

Review Comment:
   You need to follow this, rather than applying only.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] kezhenxu94 commented on pull request #10298: feature: windows monitoring

Posted by "kezhenxu94 (via GitHub)" <gi...@apache.org>.
kezhenxu94 commented on PR #10298:
URL: https://github.com/apache/skywalking/pull/10298#issuecomment-1431466952

   > Your first PR of this repo needs to wait for maintainer's approval, 
   
   FYI, asf infra will start to set a new policy to require maintainers' approval to run CI for PRs from all non-committer since this month 19th.  


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng merged pull request #10298: feature: windows monitoring

Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng merged PR #10298:
URL: https://github.com/apache/skywalking/pull/10298


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] mikechengwei commented on a diff in pull request #10298: feature: windows monitoring

Posted by "mikechengwei (via GitHub)" <gi...@apache.org>.
mikechengwei commented on code in PR #10298:
URL: https://github.com/apache/skywalking/pull/10298#discussion_r1106855810


##########
test/e2e-v2/cases/win/e2e.yaml:
##########
@@ -25,8 +25,8 @@ setup:
       command: export PATH=/tmp/skywalking-infra-e2e/bin:$PATH
     - name: install yq
       command: bash test/e2e-v2/script/prepare/setup-e2e-shell/install.sh yq
-    - name: install swctl
-      command: bash test/e2e-v2/script/prepare/setup-e2e-shell/install.sh swctl
+#    - name: install swctl
+#      command: bash test/e2e-v2/script/prepare/setup-e2e-shell/install.sh swctl
 

Review Comment:
   revert.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] mikechengwei commented on pull request #10298: feature: windows monitoring

Posted by GitBox <gi...@apache.org>.
mikechengwei commented on PR #10298:
URL: https://github.com/apache/skywalking/pull/10298#issuecomment-1397075052

   <img width="1658" alt="Screen Shot 2023-01-19 at 10 20 57 PM" src="https://user-images.githubusercontent.com/13257127/213469648-dd5fbf7a-e3c8-4eb4-9e8a-a3dd688f23b3.png">
   
   OK, I just successfully ran through the process, I will continue to improve the pr. @wu-sheng 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng commented on pull request #10298: feature: windows monitoring

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on PR #10298:
URL: https://github.com/apache/skywalking/pull/10298#issuecomment-1397877993

   I am feeling there are tools we can't support on Windows.
   
   @pg-yang Could you share your OTEL mock service? I think we need to use that to mock the telemetry on Windows.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] mikechengwei commented on pull request #10298: feature: windows monitoring

Posted by GitBox <gi...@apache.org>.
mikechengwei commented on PR #10298:
URL: https://github.com/apache/skywalking/pull/10298#issuecomment-1397824068

   > Take your time. I just pointed out what may be missed as you have labeled this PR ready for review. :)
   
   Thanks for your trust, I will improve this pr as soon as possible.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] mikechengwei commented on a diff in pull request #10298: feature: windows monitoring

Posted by "mikechengwei (via GitHub)" <gi...@apache.org>.
mikechengwei commented on code in PR #10298:
URL: https://github.com/apache/skywalking/pull/10298#discussion_r1104699813


##########
test/e2e-v2/cases/win/mock-data/otel-mock-metrics.json:
##########
@@ -6,7 +6,7 @@
           {
             "key": "service.name",
             "value": {
-              "stringValue": "SkyWalking"

Review Comment:
   ok.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng commented on pull request #10298: feature: windows monitoring

Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #10298:
URL: https://github.com/apache/skywalking/pull/10298#issuecomment-1426758500

   @mikechengwei One week passed. Any update?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] mikechengwei commented on pull request #10298: feature: windows monitoring

Posted by "mikechengwei (via GitHub)" <gi...@apache.org>.
mikechengwei commented on PR #10298:
URL: https://github.com/apache/skywalking/pull/10298#issuecomment-1427280759

   > Yes, you should submit that as an official one, polished words with better layout.. And you should submit a pull request to the UI, which lists the Windows on the menu with Linux.
   
   I know, i will quickly finish the dashboard template and docs.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wankai123 commented on a diff in pull request #10298: feature: windows monitoring

Posted by GitBox <gi...@apache.org>.
wankai123 commented on code in PR #10298:
URL: https://github.com/apache/skywalking/pull/10298#discussion_r1081373409


##########
oap-server/server-starter/src/main/resources/otel-rules/windows.yaml:
##########
@@ -0,0 +1,72 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+# This will parse a textual representation of a duration. The formats
+# accepted are based on the ISO-8601 duration format {@code PnDTnHnMn.nS}
+# with days considered to be exactly 24 hours.
+# <p>
+# Examples:
+# <pre>
+#    "PT20.345S" -- parses as "20.345 seconds"
+#    "PT15M"     -- parses as "15 minutes" (where a minute is 60 seconds)
+#    "PT10H"     -- parses as "10 hours" (where an hour is 3600 seconds)
+#    "P2D"       -- parses as "2 days" (where a day is 24 hours or 86400 seconds)
+#    "P2DT3H4M"  -- parses as "2 days, 3 hours and 4 minutes"
+#    "P-6H3M"    -- parses as "-6 hours and +3 minutes"
+#    "-P6H3M"    -- parses as "-6 hours and -3 minutes"
+#    "-P-6H+3M"  -- parses as "+6 hours and -3 minutes"
+# </pre>
+filter: "{ tags -> tags.job_name == 'windows-monitoring' }" # The OpenTelemetry job name
+expSuffix: service(['node_identifier_host_name'] , Layer.OS_WINDOWS)
+metricPrefix: meter_win
+metricsRules:
+  #cpu windows don't expose cpu load metrics
+  - name: cpu_total_percentage
+    exp: (windows_cpu_time_total * 100).tagNotEqual('mode' , 'idle').sum(['node_identifier_host_name']).rate('PT1M')
+  - name: cpu_average_used
+    exp: (windows_cpu_time_total * 100).sum(['node_identifier_host_name' , 'mode']).rate('PT1M')
+
+  #memory
+  - name: memory_total
+    exp: windows_cs_physical_memory_bytes
+  - name: memory_available
+    exp: windows_os_physical_memory_free_bytes
+  - name: memory_used
+    exp: windows_cs_physical_memory_bytes-windows_os_physical_memory_free_bytes

Review Comment:
   ```suggestion
       exp: windows_cs_physical_memory_bytes - windows_os_physical_memory_free_bytes
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng commented on pull request #10298: feature: windows monitoring

Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #10298:
URL: https://github.com/apache/skywalking/pull/10298#issuecomment-1410224618

   @mikechengwei Have you been back on this?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wankai123 commented on pull request #10298: feature: windows monitoring

Posted by GitBox <gi...@apache.org>.
wankai123 commented on PR #10298:
URL: https://github.com/apache/skywalking/pull/10298#issuecomment-1397856615

   > > The expressions LGTM, let's wait the e2e codes and others to finish this.
   > 
   > I have a question to ask you, i need install wins_exporter in a windows machine implement in e2e test , how should I implement this logic? @wankai123
   
   The E2E is running on docker, you can use the wins_exporter image to run it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng commented on pull request #10298: feature: windows monitoring

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on PR #10298:
URL: https://github.com/apache/skywalking/pull/10298#issuecomment-1398149225

   > If we cannot run the exporter on a Windows system, does it make sense to mock the data and run a test, what actually is tested? The MAL engine?
   
   We need to test MAL expressions. At least we did this for EKS monitoring last time.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] kezhenxu94 commented on pull request #10298: feature: windows monitoring

Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on PR #10298:
URL: https://github.com/apache/skywalking/pull/10298#issuecomment-1397881095

   > You could use a window server for CI.
   > 
   > https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners#supported-runners-and-hardware-resources
   > 
   > @kezhenxu94 Does our e2e support Windows?
   
   I don't see any need to run the e2e on Windows, just refer to the existing e2e for Linux monitoring
   
   https://github.com/apache/skywalking/blob/263c2b442c8b9318d839d868b503bc61c8ed6eb7/test/e2e-v2/cases/vm/prometheus-node-exporter/Dockerfile.nodeExporter#L16-L21
   
   and replace the base Docker image with a [Windows one](https://mcr.microsoft.com/en-us/product/windows/tags), replace the exporter to a [Windows exporter](https://github.com/prometheus-community/windows_exporter/releases/download/v0.20.0/windows_exporter-0.20.0-386.exe)
   
   In short, you can run the Windows system in a Docker container and monitor that system inside the container, no need to run the e2e on a real Windows system


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] mikechengwei commented on pull request #10298: feature: windows monitoring

Posted by "mikechengwei (via GitHub)" <gi...@apache.org>.
mikechengwei commented on PR #10298:
URL: https://github.com/apache/skywalking/pull/10298#issuecomment-1427274304

   > Meanwhile, where are your dashboard official settings? I can find it in the PR. And your screenshots are in Chinese, we need that in English.
   
   The dashboard is customized by me, where should I put the optimized dashboard json file in the project?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng commented on pull request #10298: feature: windows monitoring

Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #10298:
URL: https://github.com/apache/skywalking/pull/10298#issuecomment-1427277397

   Yes, you should submit that as an official one, polished words with better layout.. And you should submit a pull request to the UI, which lists the Windows on the menu with Linux.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng commented on pull request #10298: feature: windows monitoring

Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #10298:
URL: https://github.com/apache/skywalking/pull/10298#issuecomment-1431499657

   Tests passed. @mikechengwei Please finish UI side pull request.
   
   @wankai123 PTAL


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng commented on a diff in pull request #10298: feature: windows monitoring

Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on code in PR #10298:
URL: https://github.com/apache/skywalking/pull/10298#discussion_r1104573507


##########
test/e2e-v2/cases/win/mock-data/otel-mock-metrics.json:
##########
@@ -6,7 +6,7 @@
           {
             "key": "service.name",
             "value": {
-              "stringValue": "SkyWalking"

Review Comment:
   If a mock e2e test needs a static service name, it is fine.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] mikechengwei commented on pull request #10298: feature: windows monitoring

Posted by "mikechengwei (via GitHub)" <gi...@apache.org>.
mikechengwei commented on PR #10298:
URL: https://github.com/apache/skywalking/pull/10298#issuecomment-1427450210

   <img width="1529" alt="Screen Shot 2023-02-13 at 3 03 48 PM" src="https://user-images.githubusercontent.com/13257127/218392895-fe9950bf-9d85-4b21-b62d-c7457b787e9f.png">
   <img width="1515" alt="Screen Shot 2023-02-13 at 3 04 59 PM" src="https://user-images.githubusercontent.com/13257127/218392910-b5ec8fca-cdea-45ee-b375-fd85ec9e7965.png">
   
   @wu-sheng dashboard example.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng commented on a diff in pull request #10298: feature: windows monitoring

Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on code in PR #10298:
URL: https://github.com/apache/skywalking/pull/10298#discussion_r1103954030


##########
oap-server/server-starter/src/main/resources/otel-rules/windows.yaml:
##########
@@ -39,7 +39,7 @@ metricsRules:
     exp: (windows_cpu_time_total * 100).sum(['node_identifier_host_name' , 'mode']).rate('PT1M')
 
   #memory
-  - name: memory_total
+    - name: memory_total

Review Comment:
   Mistake?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] mikechengwei commented on pull request #10298: feature: windows monitoring

Posted by "mikechengwei (via GitHub)" <gi...@apache.org>.
mikechengwei commented on PR #10298:
URL: https://github.com/apache/skywalking/pull/10298#issuecomment-1427453732

   > We need another PR on the booster UI side.
   
   Do you mean that the dashboard and docs are not completed in this pr?I will wait for you to read the example, and I will delete this part.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng commented on a diff in pull request #10298: feature: windows monitoring

Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on code in PR #10298:
URL: https://github.com/apache/skywalking/pull/10298#discussion_r1104090015


##########
.github/workflows/skywalking.yaml:
##########
@@ -662,6 +662,8 @@ jobs:
             config: test/e2e-v2/cases/virtual-mq/e2e.yaml
           - name: AWS Cloud EKS
             config: test/e2e-v2/cases/aws/eks/e2e.yaml
+          - name: WINDOWS

Review Comment:
   The tests are still failing, it is better you could verify locally rather than costing a lot of upstream CI resources.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng commented on a diff in pull request #10298: feature: windows monitoring

Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on code in PR #10298:
URL: https://github.com/apache/skywalking/pull/10298#discussion_r1104089635


##########
.github/workflows/skywalking.yaml:
##########
@@ -662,6 +662,8 @@ jobs:
             config: test/e2e-v2/cases/virtual-mq/e2e.yaml
           - name: AWS Cloud EKS
             config: test/e2e-v2/cases/aws/eks/e2e.yaml
+          - name: WINDOWS

Review Comment:
   ```suggestion
             - name: Windows
   ```
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] mikechengwei commented on a diff in pull request #10298: feature: windows monitoring

Posted by "mikechengwei (via GitHub)" <gi...@apache.org>.
mikechengwei commented on code in PR #10298:
URL: https://github.com/apache/skywalking/pull/10298#discussion_r1104112643


##########
.github/workflows/skywalking.yaml:
##########
@@ -662,6 +662,8 @@ jobs:
             config: test/e2e-v2/cases/virtual-mq/e2e.yaml
           - name: AWS Cloud EKS
             config: test/e2e-v2/cases/aws/eks/e2e.yaml
+          - name: WINDOWS

Review Comment:
   Ok, this is my first time writing e2e of skywalking,  I will follow your suggestion and run successfully locally first.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng commented on pull request #10298: feature: windows monitoring

Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #10298:
URL: https://github.com/apache/skywalking/pull/10298#issuecomment-1427183839

   Meanwhile, where are your dashboard official settings? I can find it in the PR. And your screenshots are in Chinese, we need that in English.
   
   Please refer to Linux dashboard style.
   
   e2e fails, E2E test (WINDOWS, test/e2e-v2/cases/win/e2e.yaml), https://github.com/apache/skywalking/actions/runs/4157326407/jobs/7194365580, please fix.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] mikechengwei commented on a diff in pull request #10298: feature: windows monitoring

Posted by "mikechengwei (via GitHub)" <gi...@apache.org>.
mikechengwei commented on code in PR #10298:
URL: https://github.com/apache/skywalking/pull/10298#discussion_r1106853067


##########
docs/en/setup/backend/backend-win-monitoring.md:
##########
@@ -0,0 +1,34 @@
+# Windows Monitoring
+SkyWalking leverages Prometheus windows_exporter to collect metrics data from the Windows and leverages OpenTelemetry Collector to transfer the metrics to
+[OpenTelemetry receiver](opentelemetry-receiver.md) and into the [Meter System](./../../concepts-and-designs/meter.md).
+Windows entity as a `Service` in OAP and on the `Layer: OS_WINDOWS`.
+
+## Data flow
+**For OpenTelemetry receiver:**
+1. The Prometheus windows_exporter collects metrics data from the VMs.
+2. The OpenTelemetry Collector fetches metrics from windows_exporter via Prometheus Receiver and pushes metrics to the SkyWalking OAP Server via the OpenCensus gRPC Exporter or OpenTelemetry gRPC exporter.
+3. The SkyWalking OAP Server parses the expression with [MAL](../../concepts-and-designs/mal.md) to filter/calculate/aggregate and store the results.
+
+## Setup
+**For OpenTelemetry receiver:**
+1. Setup [Prometheus windows_exporter](https://github.com/prometheus-community/windows_exporter).
+2. Setup [OpenTelemetry Collector ](https://opentelemetry.io/docs/collector/). This is an example for OpenTelemetry Collector configuration [otel-collector-config.yaml](../../../../test/e2e-v2/cases/vm/prometheus-node-exporter/otel-collector-config.yaml).

Review Comment:
   done.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wankai123 commented on a diff in pull request #10298: feature: windows monitoring

Posted by "wankai123 (via GitHub)" <gi...@apache.org>.
wankai123 commented on code in PR #10298:
URL: https://github.com/apache/skywalking/pull/10298#discussion_r1106866885


##########
test/e2e-v2/cases/win/e2e.yaml:
##########
@@ -0,0 +1,44 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+# This file is used to show how to write configuration files and can be used to test.
+
+setup:
+  env: compose
+  file: docker-compose.yml
+  timeout: 20m
+  init-system-environment: ../../script/env
+  steps:
+    - name: set PATH
+      command: export PATH=/tmp/skywalking-infra-e2e/bin:$PATH
+    - name: install yq
+      command: bash test/e2e-v2/script/prepare/setup-e2e-shell/install.sh yq
+    - name: install swctl
+      command: bash test/e2e-v2/script/prepare/setup-e2e-shell/install.sh swctl
+
+trigger:
+  action: http
+  interval: 3s
+  times: 10
+  url: http://localhost:9093/otel-metrics/send

Review Comment:
   ```suggestion
     url: http://${sender_host}:${sender_9093}/otel-metrics/send
   ```



##########
test/e2e-v2/cases/win/docker-compose.yml:
##########
@@ -0,0 +1,51 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+version: '2.1'
+
+services:
+  oap:
+    extends:
+      file: ../../script/docker-compose/base-compose.yml
+      service: oap
+    ports:
+      - 12800
+    networks:
+      e2e:
+
+  sender:
+    image: "eclipse-temurin:8-jre"
+    volumes:
+      - ./../../java-test-service/e2e-mock-sender/target/e2e-mock-sender-2.0.0.jar:/e2e-mock-sender-2.0.0.jar
+      - ./mock-data:/data/otel-metrics
+    command: [ "java", "-jar", "/e2e-mock-sender-2.0.0.jar" ]
+    environment:
+      OAP_HOST: oap
+      OAP_GRPC_PORT: 11800
+      OTEL_METRICS_DATA_PATH: /data/otel-metrics
+    networks:
+      - e2e
+    ports:
+      - 9093:9093

Review Comment:
   ```suggestion
         - 9093
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng closed pull request #10298: feature: windows monitoring

Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng closed pull request #10298: feature: windows  monitoring
URL: https://github.com/apache/skywalking/pull/10298


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] kezhenxu94 commented on pull request #10298: feature: windows monitoring

Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on PR #10298:
URL: https://github.com/apache/skywalking/pull/10298#issuecomment-1397891241

   Anyway, if you have a Windows machine, just try to run the e2e and if it fail then switch to the mocking method


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng commented on pull request #10298: feature: windows monitoring

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on PR #10298:
URL: https://github.com/apache/skywalking/pull/10298#issuecomment-1397067644

   We should build a CI on GHA/Windows to test and verify the metrics. And we could provide the OTEL configuration you provided.
   Further, we should have a dashboard setup for Windows, including UI side updates to add a menu item.
   The last thing, the official dashboard docs should be added. You could refer to the Linux one.
   - https://skywalking.apache.org/docs/main/next/en/setup/backend/backend-vm-monitoring/
   - https://skywalking.apache.org/docs/main/next/en/setup/backend/opentelemetry-receiver/


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng commented on pull request #10298: feature: windows monitoring

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on PR #10298:
URL: https://github.com/apache/skywalking/pull/10298#issuecomment-1397113669

   FYI @Donadominic


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng commented on pull request #10298: feature: windows monitoring

Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #10298:
URL: https://github.com/apache/skywalking/pull/10298#issuecomment-1417878385

   Thanks for updating. I will remove the `no update`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng commented on a diff in pull request #10298: feature: windows monitoring

Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on code in PR #10298:
URL: https://github.com/apache/skywalking/pull/10298#discussion_r1104580424


##########
test/e2e-v2/cases/win/e2e.yaml:
##########
@@ -0,0 +1,44 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+# This file is used to show how to write configuration files and can be used to test.
+
+setup:
+  env: compose
+  file: docker-compose.yml
+  timeout: 20m
+  init-system-environment: ../../script/env
+  steps:
+    - name: set PATH
+      command: export PATH=/tmp/skywalking-infra-e2e/bin:$PATH
+    - name: install yq
+      command: bash test/e2e-v2/script/prepare/setup-e2e-shell/install.sh yq
+    - name: install swctl
+      command: bash test/e2e-v2/script/prepare/setup-e2e-shell/install.sh swctl
+
+trigger:
+  action: http
+  interval: 3s
+  times: 10
+  url: http://localhost:9093/otel-metrics/send
+  method: GET
+
+verify:
+  retry:
+    count: 10
+    interval: 3s
+  cases:
+    - includes:
+        - ./eks-cases.yaml

Review Comment:
   ```suggestion
           - ./win-cases.yaml
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng commented on a diff in pull request #10298: feature: windows monitoring

Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on code in PR #10298:
URL: https://github.com/apache/skywalking/pull/10298#discussion_r1104572888


##########
test/e2e-v2/cases/win/eks-cases.yaml:
##########
@@ -18,11 +18,7 @@
   cases:
     - query: swctl --display yaml --base-url=http://${oap_host}:${oap_12800}/graphql service ls
       expected: expected/service.yml
-    - query: swctl --display yaml --base-url=http://${oap_host}:${oap_12800}/graphql instance ls --service-name=SkyWalking
-      expected:  expected/instance.yml
-    - query: swctl --display yaml --base-url=http://${oap_host}:${oap_12800}/graphql endpoint ls --service-name=SkyWalking
-      expected:  expected/endpoint.yml
-    - query: swctl --display yaml --base-url=http://${oap_host}:${oap_12800}/graphql metrics linear --name=meter_win_cpu_total_percentage --service-name=SkyWalking --net.host.name=10.211.55.3 | yq e 'to_entries' -
+    - query: swctl --display yaml --base-url=http://${oap_host}:${oap_12800}/graphql metrics linear --name=meter_win_cpu_total_percentage --service-name=10.211.55.3 --instance-name=10.211.55.3 | yq e 'to_entries' -
       expected: expected/metrics-has-value.yml
-    - query: swctl --display yaml --base-url=http://${oap_host}:${oap_12800}/graphql metrics linear --name=meter_win_memory_swap_total --service-name=SkyWalking --endpoint-name=kube-dns  | yq e 'to_entries' -
+    - query: swctl --display yaml --base-url=http://${oap_host}:${oap_12800}/graphql metrics linear --name=meter_win_memory_swap_total --service-name=10.211.55.3 --endpoint-name=kube-dns  | yq e 'to_entries' -

Review Comment:
   Why do you change the EKS case? This is not relative.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng commented on pull request #10298: feature: windows monitoring

Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #10298:
URL: https://github.com/apache/skywalking/pull/10298#issuecomment-1428880452

   Your tests are still failing. Why don't you verify before submitting the changes? I can't see the point we keep eyes on a PR of keeping updated but failing.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] mikechengwei commented on pull request #10298: feature: windows monitoring

Posted by "mikechengwei (via GitHub)" <gi...@apache.org>.
mikechengwei commented on PR #10298:
URL: https://github.com/apache/skywalking/pull/10298#issuecomment-1431437974

   @wu-sheng Hi, how to trigger e2e test?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng commented on a diff in pull request #10298: feature: windows monitoring

Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on code in PR #10298:
URL: https://github.com/apache/skywalking/pull/10298#discussion_r1106845210


##########
test/e2e-v2/cases/win/e2e.yaml:
##########
@@ -0,0 +1,44 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+# This file is used to show how to write configuration files and can be used to test.
+
+setup:
+  env: compose
+  file: docker-compose.yml
+  timeout: 20m
+  init-system-environment: ../../script/env
+  steps:
+    - name: set PATH
+      command: export PATH=/tmp/skywalking-infra-e2e/bin:$PATH
+    - name: install yq
+      command: bash test/e2e-v2/script/prepare/setup-e2e-shell/install.sh yq
+#    - name: install swctl
+#      command: bash test/e2e-v2/script/prepare/setup-e2e-shell/install.sh swctl

Review Comment:
   I think this is a mistake?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng commented on pull request #10298: feature: windows monitoring

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on PR #10298:
URL: https://github.com/apache/skywalking/pull/10298#issuecomment-1397882042

   > In short, you can run the Windows system in a Docker container and monitor that system inside the container, no need to run the e2e on a real Windows system
   
   I am afraid Windows is not in that case. You could run a Linux container on Windows, but can't be reversed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] mikechengwei commented on pull request #10298: feature: windows monitoring

Posted by GitBox <gi...@apache.org>.
mikechengwei commented on PR #10298:
URL: https://github.com/apache/skywalking/pull/10298#issuecomment-1397857748

   > wins_exporter
   
   ok, i get.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng commented on pull request #10298: feature: windows monitoring

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on PR #10298:
URL: https://github.com/apache/skywalking/pull/10298#issuecomment-1397894118

   This is an example of OTEL data mock for EKS monitoring.
   - https://github.com/apache/skywalking/tree/master/test/e2e-v2/cases/aws/eks
   - Mock sender is here, https://github.com/apache/skywalking/blob/master/test/e2e-v2/java-test-service/e2e-mock-sender/src/main/java/org/apache/skywalking/e2e/controller/OtelMetricsSender.java


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] mikechengwei commented on pull request #10298: feature: windows monitoring

Posted by GitBox <gi...@apache.org>.
mikechengwei commented on PR #10298:
URL: https://github.com/apache/skywalking/pull/10298#issuecomment-1397888119

   ![image](https://user-images.githubusercontent.com/13257127/213613051-8bc2c0ab-9552-4125-b4fe-d67ce190def4.png)
   
   windows_exporter also use windows operate system to run e2e test. @kezhenxu94 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] mikechengwei commented on pull request #10298: feature: windows monitoring

Posted by GitBox <gi...@apache.org>.
mikechengwei commented on PR #10298:
URL: https://github.com/apache/skywalking/pull/10298#issuecomment-1397866600

   > > The E2E is running on docker, you can use the wins_exporter image to run it.
   > 
   > Or you can base on `windows/nanoserver` to build a image, if you can't find a official one. This might help: https://github.com/prometheus-community/windows_exporter/blob/master/Dockerfile
   
   Ok.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng commented on pull request #10298: feature: windows monitoring

Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #10298:
URL: https://github.com/apache/skywalking/pull/10298#issuecomment-1426918780

   @mikechengwei You need to add your e2e to GHA control file. Otherwise, it never runs through CI system.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng commented on pull request #10298: feature: windows monitoring

Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #10298:
URL: https://github.com/apache/skywalking/pull/10298#issuecomment-1427424354

   We need another PR on the booster UI side.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] mikechengwei commented on a diff in pull request #10298: feature: windows monitoring

Posted by "mikechengwei (via GitHub)" <gi...@apache.org>.
mikechengwei commented on code in PR #10298:
URL: https://github.com/apache/skywalking/pull/10298#discussion_r1104066116


##########
test/e2e-v2/java-test-service/e2e-mock-sender/src/main/java/org/apache/skywalking/e2e/controller/OtelMetricsSender.java:
##########
@@ -80,7 +80,7 @@ public String sendMetricsByTemplate() throws IOException {
             return msg;
         }
         for (File file : files) {
-            final ExportMetricsServiceRequest.Builder builder = ExportMetricsServiceRequest.newBuilder();
+            final win::SkyWalking.Builder builder = ExportMetricsServiceRequest.newBuilder();

Review Comment:
   sorry,my error.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] mikechengwei commented on pull request #10298: feature: windows monitoring

Posted by "mikechengwei (via GitHub)" <gi...@apache.org>.
mikechengwei commented on PR #10298:
URL: https://github.com/apache/skywalking/pull/10298#issuecomment-1427456238

   > I mean something like this [apache/skywalking-booster-ui#227](https://github.com/apache/skywalking-booster-ui/pull/227). You have to finish that and we can see the Windows monitoring on the UI menu like other existing items. Right now, you could only access this dashboard through dashboard management page, right?
   
   Ok, i know.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org