You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pekko.apache.org by PJ Fanning <fa...@apache.org> on 2023/07/19 11:34:19 UTC
[VOTE] accept http cors code donation
See the original thread below:
https://lists.apache.org/thread/qx31xljn6bf7rwcd3kbb9btcdvoxmmwy
Despite messages on the thread saying that we didn't need a vote, we
have had our HTTP RC1 rejected due to IP Clearance issues associated
with this code.
https://incubator.apache.org/ip-clearance/
Part of IP clearance appears to require us to do a vote and even if we
don't absolutely need one, all the clearance requests I've seen have
one. So we are better off having one.
I'll leave the vote open for 72 hrs. 3 approvals (+1) are required
from PPMC members. If there are more total approvals than rejections
(-1), the vote carries.
Here is my +1.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pekko.apache.org
For additional commands, e-mail: dev-help@pekko.apache.org
Re: [VOTE] accept http cors code donation
Posted by Matthew de Detrich <ma...@aiven.io.INVALID>.
> The CORS contribution is a tiny fraction of the overall release. None
of the issues highlighted in the -1 relate to the CORS contribution.
> All the issues highlighted relate to the original Akka code.
Thanks for clarifying, can we please just stick to talking about the
pekko-http-cors vote in this thread, it's hard enough as it is to
track what's going on.
On Wed, Jul 19, 2023 at 6:03 PM PJ Fanning <fa...@gmail.com> wrote:
> The CORS contribution is a tiny fraction of the overall release. None
> of the issues highlighted in the -1 relate to the CORS contribution.
>
> All the issues highlighted relate to the original Akka code.
>
> On Wed, 19 Jul 2023 at 16:28, Justin Mclean <ju...@classsoftware.com>
> wrote:
> >
> > Hi,
> >
> > > I just checked through the entire git commit history of the code, the
> > > entire implementation was written from scratch by the author (Lomig
> Mégard)
> >
> > Except there are multiple pieces of 3rd party code in the RC, which he
> clearly did not write.
> >
> > Kind Regards,
> > Justin
> >
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@pekko.apache.org
> > For additional commands, e-mail: dev-help@pekko.apache.org
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@pekko.apache.org
> For additional commands, e-mail: dev-help@pekko.apache.org
>
>
--
Matthew de Detrich
*Aiven Deutschland GmbH*
Immanuelkirchstraße 26, 10405 Berlin
Amtsgericht Charlottenburg, HRB 209739 B
Geschäftsführer: Oskari Saarenmaa & Hannu Valtonen
*m:* +491603708037
*w:* aiven.io *e:* matthew.dedetrich@aiven.io
Re: [VOTE] accept http cors code donation
Posted by PJ Fanning <fa...@gmail.com>.
The CORS contribution is a tiny fraction of the overall release. None
of the issues highlighted in the -1 relate to the CORS contribution.
All the issues highlighted relate to the original Akka code.
On Wed, 19 Jul 2023 at 16:28, Justin Mclean <ju...@classsoftware.com> wrote:
>
> Hi,
>
> > I just checked through the entire git commit history of the code, the
> > entire implementation was written from scratch by the author (Lomig Mégard)
>
> Except there are multiple pieces of 3rd party code in the RC, which he clearly did not write.
>
> Kind Regards,
> Justin
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@pekko.apache.org
> For additional commands, e-mail: dev-help@pekko.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pekko.apache.org
For additional commands, e-mail: dev-help@pekko.apache.org
Re: [VOTE] accept http cors code donation
Posted by Matthew de Detrich <ma...@aiven.io.INVALID>.
Also if it's not clear, all of my comments are referring to pekko-http-cors
**specifically** and **not** pekko-http in general.
If there are issues with pekko-http in general then can we please use the
appropriate thread, not this one which is a [VOTE] for pekko-http-cors.
On Wed, 19 July 2023, 17:34 Matthew de Detrich, <ma...@aiven.io>
wrote:
> https://github.com/apache/incubator-pekko-http/pull/208
>
> This the PR that introduced pekko-http-cors. The code being included was
> either originally from him or myself (I.e. amending the documentation so
> its consistent with Pekko Http).
>
> Can you please point me to the 3rd party code you are referring to?
>
>
> On Wed, 19 July 2023, 17:28 Justin Mclean, <ju...@classsoftware.com>
> wrote:
>
>> Hi,
>>
>> > I just checked through the entire git commit history of the code, the
>> > entire implementation was written from scratch by the author (Lomig
>> Mégard)
>>
>> Except there are multiple pieces of 3rd party code in the RC, which he
>> clearly did not write.
>>
>> Kind Regards,
>> Justin
>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@pekko.apache.org
>> For additional commands, e-mail: dev-help@pekko.apache.org
>>
>>
Re: [VOTE] accept http cors code donation
Posted by Matthew de Detrich <ma...@aiven.io.INVALID>.
https://github.com/apache/incubator-pekko-http/pull/208
This the PR that introduced pekko-http-cors. The code being included was
either originally from him or myself (I.e. amending the documentation so
its consistent with Pekko Http).
Can you please point me to the 3rd party code you are referring to?
On Wed, 19 July 2023, 17:28 Justin Mclean, <ju...@classsoftware.com> wrote:
> Hi,
>
> > I just checked through the entire git commit history of the code, the
> > entire implementation was written from scratch by the author (Lomig
> Mégard)
>
> Except there are multiple pieces of 3rd party code in the RC, which he
> clearly did not write.
>
> Kind Regards,
> Justin
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@pekko.apache.org
> For additional commands, e-mail: dev-help@pekko.apache.org
>
>
Re: [VOTE] accept http cors code donation
Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,
> I just checked through the entire git commit history of the code, the
> entire implementation was written from scratch by the author (Lomig Mégard)
Except there are multiple pieces of 3rd party code in the RC, which he clearly did not write.
Kind Regards,
Justin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pekko.apache.org
For additional commands, e-mail: dev-help@pekko.apache.org
Re: [VOTE] accept http cors code donation
Posted by Matthew de Detrich <ma...@aiven.io.INVALID>.
> My suggestion is that before taking a vote, you might want to look and
discuss what is being donated and what, if any, license and IP issues
migaht be in the donation.
I just checked through the entire git commit history of the code, the
entire implementation was written from scratch by the author (Lomig Mégard)
who is the same person that donated the code and almost all of the changes
(aside from trivial commits such as bumping versions) was also committed by
the author.
There shouldn't be any issues in this regard
On Wed, Jul 19, 2023 at 3:24 PM Justin Mclean <ju...@classsoftware.com>
wrote:
> Hi,
>
> To be clear, I didn't vote -1 on the RC because a vote on IP Clearance
> procedure wasn't followed. Other issues in that RC are the reasons for my
> -1 vote.
>
> My suggestion is that before taking a vote, you might want to look and
> discuss what is being donated and what, if any, license and IP issues
> migaht be in the donation.
>
> Kind Regards,
> Justin
>
> > On 19 Jul 2023, at 9:34 pm, PJ Fanning <fa...@apache.org> wrote:
> >
> > See the original thread below:
> >
> > https://lists.apache.org/thread/qx31xljn6bf7rwcd3kbb9btcdvoxmmwy
> >
> > Despite messages on the thread saying that we didn't need a vote, we
> > have had our HTTP RC1 rejected due to IP Clearance issues associated
> > with this code.
> >
> > https://incubator.apache.org/ip-clearance/
> >
> > Part of IP clearance appears to require us to do a vote and even if we
> > don't absolutely need one, all the clearance requests I've seen have
> > one. So we are better off having one.
> >
> > I'll leave the vote open for 72 hrs. 3 approvals (+1) are required
> > from PPMC members. If there are more total approvals than rejections
> > (-1), the vote carries.
> >
> > Here is my +1.
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@pekko.apache.org
> > For additional commands, e-mail: dev-help@pekko.apache.org
> >
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@pekko.apache.org
> For additional commands, e-mail: dev-help@pekko.apache.org
>
>
--
Matthew de Detrich
*Aiven Deutschland GmbH*
Immanuelkirchstraße 26, 10405 Berlin
Amtsgericht Charlottenburg, HRB 209739 B
Geschäftsführer: Oskari Saarenmaa & Hannu Valtonen
*m:* +491603708037
*w:* aiven.io *e:* matthew.dedetrich@aiven.io
Re: [VOTE] accept http cors code donation
Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,
To be clear, I didn't vote -1 on the RC because a vote on IP Clearance procedure wasn't followed. Other issues in that RC are the reasons for my -1 vote.
My suggestion is that before taking a vote, you might want to look and discuss what is being donated and what, if any, license and IP issues migaht be in the donation.
Kind Regards,
Justin
> On 19 Jul 2023, at 9:34 pm, PJ Fanning <fa...@apache.org> wrote:
>
> See the original thread below:
>
> https://lists.apache.org/thread/qx31xljn6bf7rwcd3kbb9btcdvoxmmwy
>
> Despite messages on the thread saying that we didn't need a vote, we
> have had our HTTP RC1 rejected due to IP Clearance issues associated
> with this code.
>
> https://incubator.apache.org/ip-clearance/
>
> Part of IP clearance appears to require us to do a vote and even if we
> don't absolutely need one, all the clearance requests I've seen have
> one. So we are better off having one.
>
> I'll leave the vote open for 72 hrs. 3 approvals (+1) are required
> from PPMC members. If there are more total approvals than rejections
> (-1), the vote carries.
>
> Here is my +1.
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@pekko.apache.org
> For additional commands, e-mail: dev-help@pekko.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pekko.apache.org
For additional commands, e-mail: dev-help@pekko.apache.org
Re: [VOTE] accept http cors code donation
Posted by Sean Glover <se...@seanglover.com>.
+1
On Wed, Jul 19, 2023 at 8:11 AM Matthew de Detrich
<ma...@aiven.io.invalid> wrote:
> +1
>
> Regards
>
> On Wed, Jul 19, 2023 at 1:34 PM PJ Fanning <fa...@apache.org> wrote:
>
> > See the original thread below:
> >
> > https://lists.apache.org/thread/qx31xljn6bf7rwcd3kbb9btcdvoxmmwy
> >
> > Despite messages on the thread saying that we didn't need a vote, we
> > have had our HTTP RC1 rejected due to IP Clearance issues associated
> > with this code.
> >
> > https://incubator.apache.org/ip-clearance/
> >
> > Part of IP clearance appears to require us to do a vote and even if we
> > don't absolutely need one, all the clearance requests I've seen have
> > one. So we are better off having one.
> >
> > I'll leave the vote open for 72 hrs. 3 approvals (+1) are required
> > from PPMC members. If there are more total approvals than rejections
> > (-1), the vote carries.
> >
> > Here is my +1.
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@pekko.apache.org
> > For additional commands, e-mail: dev-help@pekko.apache.org
> >
> >
>
> --
>
> Matthew de Detrich
>
> *Aiven Deutschland GmbH*
>
> Immanuelkirchstraße 26, 10405 Berlin
>
> Amtsgericht Charlottenburg, HRB 209739 B
>
> Geschäftsführer: Oskari Saarenmaa & Hannu Valtonen
>
> *m:* +491603708037
>
> *w:* aiven.io *e:* matthew.dedetrich@aiven.io
>
Re: [VOTE] accept http cors code donation
Posted by Matthew de Detrich <ma...@aiven.io.INVALID>.
+1
Regards
On Wed, Jul 19, 2023 at 1:34 PM PJ Fanning <fa...@apache.org> wrote:
> See the original thread below:
>
> https://lists.apache.org/thread/qx31xljn6bf7rwcd3kbb9btcdvoxmmwy
>
> Despite messages on the thread saying that we didn't need a vote, we
> have had our HTTP RC1 rejected due to IP Clearance issues associated
> with this code.
>
> https://incubator.apache.org/ip-clearance/
>
> Part of IP clearance appears to require us to do a vote and even if we
> don't absolutely need one, all the clearance requests I've seen have
> one. So we are better off having one.
>
> I'll leave the vote open for 72 hrs. 3 approvals (+1) are required
> from PPMC members. If there are more total approvals than rejections
> (-1), the vote carries.
>
> Here is my +1.
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@pekko.apache.org
> For additional commands, e-mail: dev-help@pekko.apache.org
>
>
--
Matthew de Detrich
*Aiven Deutschland GmbH*
Immanuelkirchstraße 26, 10405 Berlin
Amtsgericht Charlottenburg, HRB 209739 B
Geschäftsführer: Oskari Saarenmaa & Hannu Valtonen
*m:* +491603708037
*w:* aiven.io *e:* matthew.dedetrich@aiven.io
Re: [VOTE] accept http cors code donation
Posted by Greg Methvin <gr...@apache.org>.
+1
On Wed, Jul 19, 2023 at 04:34 PJ Fanning <fa...@apache.org> wrote:
> See the original thread below:
>
> https://lists.apache.org/thread/qx31xljn6bf7rwcd3kbb9btcdvoxmmwy
>
> Despite messages on the thread saying that we didn't need a vote, we
> have had our HTTP RC1 rejected due to IP Clearance issues associated
> with this code.
>
> https://incubator.apache.org/ip-clearance/
>
> Part of IP clearance appears to require us to do a vote and even if we
> don't absolutely need one, all the clearance requests I've seen have
> one. So we are better off having one.
>
> I'll leave the vote open for 72 hrs. 3 approvals (+1) are required
> from PPMC members. If there are more total approvals than rejections
> (-1), the vote carries.
>
> Here is my +1.
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@pekko.apache.org
> For additional commands, e-mail: dev-help@pekko.apache.org
>
>