[GitHub] [ozone] kaijchen commented on a diff in pull request #4269: HDDS-7931. EC: ManagedChannelImpl not cleaned up properly

["kaijchen (via GitHub)" <gi...@apache.org>]

kaijchen commented on code in PR #4269:
URL: https://github.com/apache/ozone/pull/4269#discussion_r1104054335


##########
hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/io/ECKeyOutputStream.java:
##########
@@ -548,7 +553,7 @@ private void addStripeToQueue(ECChunkBuffers stripe) throws IOException {
   private boolean flushStripeFromQueue() throws IOException {
     try {
       ECChunkBuffers stripe = ecStripeQueue.take();
-      while (!(stripe instanceof EOFDummyStripe)) {
+      while (!closing && !(stripe instanceof EOFDummyStripe)) {

Review Comment:
   There might be some stripes buffered in `ecStripeQueue`, and `EOFDummyStripe` is used as signal of there is no more stripes left. Is it intended to drop the buffered stripes when `closing`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org