You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@guacamole.apache.org by GitBox <gi...@apache.org> on 2022/06/07 12:07:57 UTC

[GitHub] [guacamole-client] necouchman commented on a diff in pull request #734: GUACAMOLE-1611: Update French translations.

necouchman commented on code in PR #734:
URL: https://github.com/apache/guacamole-client/pull/734#discussion_r891132735


##########
doc/guacamole-branding-example/guac-manifest.json:
##########
@@ -29,6 +29,7 @@
     },
     
     "translations" : [
-        "translations/en.json"
+        "translations/en.json",
+		"translations/fr.json"

Review Comment:
   Two issues, here:
   1. Please make sure you use 4-space tabs, in keeping with the standards of the rest of the code.
   2. You added the fr.json entry, here, but there is no fr.json file added to this. There's no reason to add entries if you're not going to add the translation file.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org