You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues-all@impala.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2020/10/30 17:04:00 UTC

[jira] [Commented] (IMPALA-10294) Improvement to test_skew_reporting_in_runtime_profile

    [ https://issues.apache.org/jira/browse/IMPALA-10294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17223773#comment-17223773 ] 

ASF subversion and git services commented on IMPALA-10294:
----------------------------------------------------------

Commit d164bf42f9fd8ec65db44a5904730587d2b961ec in impala's branch refs/heads/master from Qifan Chen
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=d164bf4 ]

IMPALA-10294: Improvement to test_skew_reporting_in_runtime_profile

This fix improved the skew reporting test by lowering the threshold
to 0 and by taking care of the extreme case of no skews.

Testing:
1. Unit testing.

Change-Id: I7a36551f2507d724891707d26b7394fbe3a5657b
Reviewed-on: http://gerrit.cloudera.org:8080/16662
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>


> Improvement to test_skew_reporting_in_runtime_profile
> -----------------------------------------------------
>
>                 Key: IMPALA-10294
>                 URL: https://issues.apache.org/jira/browse/IMPALA-10294
>             Project: IMPALA
>          Issue Type: Bug
>          Components: Backend
>            Reporter: Qifan Chen
>            Assignee: Qifan Chen
>            Priority: Major
>
> In /impala-asf-master-exhaustive build, the following error is seen.
> query_test.test_observability.TestObservability.test_skew_reporting_in_runtime_profile
>  Error Details
> {code:java}
> query_test/test_observability.py:753: in test_skew_reporting_in_runtime_profile     assert len(re.findall(skews_found, results.runtime_profile, re.M)) == 1 E   assert 0 == 1 E    +  where 0 = len([]) E    +    where [] = <function findall at 0x7f3069f938c0>('skew\\(s\\) found at:.*HASH_JOIN.*HASH_JOIN.*HDFS_SCAN_NODE', 'Query (id=5c4b97e5ed63435c:5aa154be00000000):\n  DEBUG MODE WARNING: Query profile created while running a DEBUG buil...: 0.000ns\n             - WriteIoBytes: 0\n             - WriteIoOps: 0 (0)\n             - WriteIoWaitTime: 0.000ns\n', 8) E    +      where <function findall at 0x7f3069f938c0> = re.findall E    +      and   'Query (id=5c4b97e5ed63435c:5aa154be00000000):\n  DEBUG MODE WARNING: Query profile created while running a DEBUG buil...: 0.000ns\n             - WriteIoBytes: 0\n             - WriteIoOps: 0 (0)\n             - WriteIoWaitTime: 0.000ns\n' = <tests.beeswax.impala_beeswax.ImpalaBeeswaxResult object at 0x7f304ac15190>.runtime_profile E    +      and   8 = re.M
> {code}
>  Stack Trace
> {code:java}
> query_test/test_observability.py:753: in test_skew_reporting_in_runtime_profile
>     assert len(re.findall(skews_found, results.runtime_profile, re.M)) == 1
> E   assert 0 == 1
> E    +  where 0 = len([])
> E    +    where [] = <function findall at 0x7f3069f938c0>('skew\\(s\\) found at:.*HASH_JOIN.*HASH_JOIN.*HDFS_SCAN_NODE', 'Query (id=5c4b97e5ed63435c:5aa154be00000000):\n  DEBUG MODE WARNING: Query profile created while running a DEBUG buil...: 0.000ns\n             - WriteIoBytes: 0\n             - WriteIoOps: 0 (0)\n             - WriteIoWaitTime: 0.000ns\n', 8)
> E    +      where <function findall at 0x7f3069f938c0> = re.findall
> E    +      and   'Query (id=5c4b97e5ed63435c:5aa154be00000000):\n  DEBUG MODE WARNING: Query profile created while running a DEBUG buil...: 0.000ns\n             - WriteIoBytes: 0\n             - WriteIoOps: 0 (0)\n             - WriteIoWaitTime: 0.000ns\n' = <tests.beeswax.impala_beeswax.ImpalaBeeswaxResult object at 0x7f304ac15190>.runtime_profile
> E    +      and   8 = re.M
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscribe@impala.apache.org
For additional commands, e-mail: issues-all-help@impala.apache.org