[jira] [Work logged] (LANG-1603) Deprecate the "Fraction" class

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/LANG-1603?focusedWorklogId=814954&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-814954 ]

ASF GitHub Bot logged work on LANG-1603:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 08/Oct/22 12:50
            Start Date: 08/Oct/22 12:50
    Worklog Time Spent: 10m 
      Work Description: garydgregory commented on code in PR #935:
URL: https://github.com/apache/commons-lang/pull/935#discussion_r990638476


##########
src/main/java/org/apache/commons/lang3/math/Fraction.java:
##########
@@ -31,8 +31,11 @@
  * based and thus suffers from various overflow issues. For a BigInteger based
  * equivalent, please see the Commons Math BigFraction class. </p>
  *
+ * @deprecated for <a href="https://commons.apache.org/proper/commons-math/javadocs/api-3.6.1/org/apache/commons/math3/fraction/Fraction.html">Fraction</a>

Review Comment:
   We can't just deprecate the class without documenting how to port your current code to the other API IMO. For example, what do you do with `Fraction#invert()`? Each method must be documented, otherwise, it's a disservice, and everyone using the class is left having to do their own investigation and mapping.





Issue Time Tracking
-------------------

    Worklog Id:     (was: 814954)
    Time Spent: 1h 40m  (was: 1.5h)

> Deprecate the "Fraction" class
> ------------------------------
>
>                 Key: LANG-1603
>                 URL: https://issues.apache.org/jira/browse/LANG-1603
>             Project: Commons Lang
>          Issue Type: Sub-task
>            Reporter: Gilles Sadowski
>            Priority: Major
>             Fix For: 4.0
>
>          Time Spent: 1h 40m
>  Remaining Estimate: 0h
>
> [Fraction|https://gitbox.apache.org/repos/asf?p=commons-lang.git;a=blob;f=src/main/java/org/apache/commons/lang3/math/Fraction.java;h=e90e340ac5578126492471841f4a97548dbb49f7;hb=HEAD] in [Lang] vs [Fraction|https://gitbox.apache.org/repos/asf?p=commons-numbers.git;a=blob;f=commons-numbers-fraction/src/main/java/org/apache/commons/numbers/fraction/Fraction.java;h=f1bc54278a9a65538638ddbe9d17a28452a60ca4;hb=HEAD] in [Numbers].



--
This message was sent by Atlassian Jira
(v8.20.10#820010)