[GitHub] [incubator-druid] clintropolis commented on a change in pull request #7414: Adding ability to pass configs in and fixing misc bugs

[GitBox <gi...@apache.org>]

clintropolis commented on a change in pull request #7414: Adding ability to pass configs in and fixing misc bugs
URL: https://github.com/apache/incubator-druid/pull/7414#discussion_r272397011
 
 

 ##########
 File path: web-console/console-config.js
 ##########
 @@ -0,0 +1,19 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+window.consoleConfig = { /* future configs may go here */ };
 
 Review comment:
   Since this get's built into the Druid package, it's not really _configurable_ unless you build your own package. Would it make sense as a follow up to improve the Druid side that serves this path to optionally wire up to a Druid config option that points to an alternate file to use for `console-config.js` so that an operator might supply their own js file with config values to override the defaults?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org